Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 859901 - media-libs/gegl-0.4.36-r1 fails to compile (lto): gegl-op.h:201:8: error: type struct _GeglOp violates the C++ One Definition Rule [-Werror=odr]
Summary: media-libs/gegl-0.4.36-r1 fails to compile (lto): gegl-op.h:201:8: error: typ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-22 06:43 UTC by Agostino Sarubbo
Modified: 2022-08-31 22:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,39.04 KB, application/x-xz)
2022-07-22 06:43 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-22 06:43:38 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/gegl-0.4.36-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-22 06:43:41 UTC
Created attachment 792989 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-22 06:43:43 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: operations/common-cxx/gegl-common-cxx-x86_64-v2.so 
FAILED: operations/common-cxx/gegl-common-cxx-x86_64-v3.so 
FAILED: operations/common-cxx/gegl-common-cxx.so 
Program asciidoc found: NO
Program dot found: NO
Program gtkdoc-scan found: NO
Program source-highlight found: NO
Run-time dependency gexiv2 found: NO (tried pkgconfig and cmake)
Run-time dependency maxflow found: NO (tried pkgconfig and cmake)
Run-time dependency poly2tri-c found: NO (tried pkgconfig and cmake)
../gegl-0.4.36/gegl/gegl-op.h:201:8: error: type ‘struct _GeglOp’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:26 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 4 Larry the Git Cow gentoo-dev 2022-08-31 22:26:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf8d9fa7c9bf8fd6f4291216eacbcc2cea9d6ddb

commit bf8d9fa7c9bf8fd6f4291216eacbcc2cea9d6ddb
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2022-08-29 22:28:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-31 22:26:33 +0000

    media-libs/gegl: 0.4.38 version bump
    
    Use 'filter-lto' to allow build in LTO profiles.
    Add USE="sdl2" flag.
    
    Closes: https://bugs.gentoo.org/859901
    Closes: https://bugs.gentoo.org/860246
    
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/gegl/Manifest           |   1 +
 media-libs/gegl/gegl-0.4.38.ebuild | 156 +++++++++++++++++++++++++++++++++++++
 media-libs/gegl/gegl-9999.ebuild   |  14 ++--
 media-libs/gegl/metadata.xml       |   1 +
 4 files changed, 167 insertions(+), 5 deletions(-)