https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-misc/typespeed-0.6.5-r2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 792149 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=205386500401a626968efb6b5e5dba531e752fe8 commit 205386500401a626968efb6b5e5dba531e752fe8 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-04 05:12:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-04 05:16:30 +0000 games-misc/typespeed: update EAPI 7 -> 8, fix build with LTO, fix group for leaderboard * EAPI 8 * Fix build with LTO (-Wlto-type-mismatch) * Fix group for leaderboard (tried to use 'games', move to 'gamestat') * Wire up tests Closes: https://bugs.gentoo.org/858785 Signed-off-by: Sam James <sam@gentoo.org> .../typespeed/files/typespeed-0.6.5-gamestat.patch | 15 +++++ .../typespeed/files/typespeed-0.6.5-lto.patch | 54 ++++++++++++++++++ games-misc/typespeed/typespeed-0.6.5-r3.ebuild | 64 ++++++++++++++++++++++ 3 files changed, 133 insertions(+)
*** Bug 926142 has been marked as a duplicate of this bug. ***
