https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-arcade/commandergenius-2.4.0 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 791870 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: src/CGeniusExe /var/tmp/portage/games-arcade/commandergenius-2.4.0/work/Commander-Genius-v2.4.0/src/engine/refkeen/kdreams/../be_st.h:72:6: error: type of ‘BE_ST_SetTimer’ does not match original declaration [-Werror=lto-type-mismatch]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=646df5c2d8bb035184b8d01273356ad5600c7e13 commit 646df5c2d8bb035184b8d01273356ad5600c7e13 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2023-02-25 09:41:14 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2023-02-25 10:19:43 +0000 games-arcade/commandergenius: EAPI7->8, enable py3.11, filter-lto Still needs a bump, but that will need closer looking into and ideally someone more familiar with this and having the game files. wrt python, support for 3.11 falls back on users given it's used for their own scripts (later versions replace python by lua). Albeit may already have been using 3.11 or 3.12 given cmake wasn't told which interpreter library to link with before. Just a lazy fix wrt bug #858530 to do at same time as revbump, haven't looked closer. Closes: https://bugs.gentoo.org/858530 Closes: https://bugs.gentoo.org/896954 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> ....4.0.ebuild => commandergenius-2.4.0-r1.ebuild} | 53 +++++++++++----------- 1 file changed, 26 insertions(+), 27 deletions(-)
