https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-util/colm-0.14.7-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 791699 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a1e08ac5ed37555aafc8f09748fb942d9b7255c commit 1a1e08ac5ed37555aafc8f09748fb942d9b7255c Author: Sam James <sam@gentoo.org> AuthorDate: 2024-02-29 07:30:43 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-29 07:33:54 +0000 dev-util/colm: filter LTO, no-SA ragel and colm are *very* fragile. Bug: https://bugs.gentoo.org/858341 Bug: https://bugs.gentoo.org/883993 Bug: https://bugs.gentoo.org/924163 Signed-off-by: Sam James <sam@gentoo.org> dev-util/colm/colm-0.14.7-r3.ebuild | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d333828408e6230ce3a7aef9ce6fba2fb5ec945 commit 5d333828408e6230ce3a7aef9ce6fba2fb5ec945 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-02-29 07:29:44 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-29 07:33:54 +0000 dev-util/ragel: filter LTO, no-SA ragel and colm are *very* fragile. Bug: https://bugs.gentoo.org/858341 Bug: https://bugs.gentoo.org/883993 Bug: https://bugs.gentoo.org/924163 Signed-off-by: Sam James <sam@gentoo.org> dev-util/ragel/ragel-7.0.4-r3.ebuild | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
OK, there's the following upstream for this: * https://github.com/adrian-thurston/colm/pull/136 * https://github.com/adrian-thurston/colm/pull/141 but I don't really want to try backport it, and given the huge amount of problems we've had with colm, I'm not really inclined to lift the restriction either.
