Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 858338 - dev-util/codeblocks-20.03-r4 fails to compile (lto): sqplus.h:1810:70: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: dev-util/codeblocks-20.03-r4 fails to compile (lto): sqplus.h:1810:70: error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-16 09:12 UTC by Agostino Sarubbo
Modified: 2022-11-25 05:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,126.58 KB, text/plain)
2022-07-16 09:12 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-16 09:12:50 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/codeblocks-20.03-r4 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-16 09:12:52 UTC
Created attachment 791696 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:01:25 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Sergey Torokhov 2022-09-02 12:18:25 UTC
`sqplus` was removed from codebase of Codeblocks [1] so I just will use disabling option `-fno-strict-aliasing`

There are also related issues [2] in other places with dev-util/codeblocks-9999 (reported to upstream).


[1] https://sourceforge.net/p/codeblocks/code/12416/
[2] https://sourceforge.net/p/codeblocks/tickets/1303/
Comment 4 Larry the Git Cow gentoo-dev 2022-11-25 05:41:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22bdf13582b47bb942ec7ba51660947e84fbc1f4

commit 22bdf13582b47bb942ec7ba51660947e84fbc1f4
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2022-09-02 12:18:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-25 05:40:30 +0000

    dev-util/codeblocks: pass '-fno-strict-aliasing' to fix compile error (lto)
    
    The related reported upstream issue for dev-util/codeblocks-9999:
    https://sourceforge.net/p/codeblocks/tickets/1303/
    
    Closes: https://bugs.gentoo.org/858338
    
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Closes: https://github.com/gentoo/gentoo/pull/25758
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/codeblocks/codeblocks-20.03-r4.ebuild | 5 ++++-
 dev-util/codeblocks/codeblocks-20.03-r5.ebuild | 5 ++++-
 dev-util/codeblocks/codeblocks-9999.ebuild     | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)