https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-python/thriftpy2-0.4.14-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 790736 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
lto_tinderbox has reproduced this issue with version 0.4.17 - Updating summary.
thriftpy2/protocol/cybin/cybin.c: In function ‘__pyx_f_5cybin_write_double’: thriftpy2/protocol/cybin/cybin.c:4623:51: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] 4623 | __pyx_v_v = htobe64((((int64_t *)(&__pyx_v_val))[0])); | ^ thriftpy2/protocol/cybin/cybin.c: In function ‘__pyx_f_5cybin_c_read_val’: thriftpy2/protocol/cybin/cybin.c:6850:61: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] 6850 | __pyx_t_2 = PyFloat_FromDouble((((double *)(&__pyx_v_n))[0])); if (unlikely(!__pyx_t_2)) __PYX_ERR(0, 290, __pyx_L1_error) It's a cython codegen problem.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae86d7ab3871e5ebe8f54d4b751f84470b43c9f9 commit ae86d7ab3871e5ebe8f54d4b751f84470b43c9f9 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-03 22:00:38 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-03 23:18:16 +0000 dev-python/thriftpy2: mark as LTO-unsafe, strict-aliasing unsafe Closes: https://bugs.gentoo.org/857105 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/thriftpy2/thriftpy2-0.4.20.ebuild | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
