https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-emulation/vice-3.6.1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 787895 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
lto_tinderbox has reproduced this issue with version 3.6.1-r1 - Updating summary.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3fcffdf3e1a9c54fba9f664c6f11bb194f9986e commit c3fcffdf3e1a9c54fba9f664c6f11bb194f9986e Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2022-12-26 11:07:07 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2022-12-26 13:32:14 +0000 app-emulation/vice: add 3.7 ebuild changes: - drop IUSE=cpuhistory, new upstream default is enabled and just going with that (no deps, and impact should be minimal) - drop IUSE=jpeg, upstream removed support - drop --disable-static QA, not an issue with current portage and just harmless noise if still using an older one - replace deprecated atk dep - adjust for renamed configure options (may be some oversights given a lot of noise in build system changes). Upstream disabled catweasel/parsid/ssi2001 by default leaving only hardsid enabled out of this group. Given rather obscure, left disabled for now with the exception of parsid enabled with USE=parport. If someone use/know these and feel may make sense to enable with USE=pci, parport, or their own USE please file a bug. wrt bug #834359, unfortunately still broken and upstream instead added an explicit check: configure: error: ffmpeg version is not compatible. Use 4.x So keeping the <ffmpeg-5 dep, albeit it remains not overly important (could be removed/masked) and is off by default, shouldn't be a worry if ffmpeg-5 is to be unmasked. wrt bug #854537, odr issues seem fixed upstream Bug: https://bugs.gentoo.org/834359 Closes: https://bugs.gentoo.org/854537 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> app-emulation/vice/Manifest | 1 + app-emulation/vice/vice-3.7.ebuild | 189 +++++++++++++++++++++++++++++++++++++ 2 files changed, 190 insertions(+)
