Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 853898 - sys-devel/gdb-12.1-r2 fails to compile: ada-exp.c.tmp:576:7: error: type union YYSTYPE violates the C++ One Definition Rule [-Werror=odr]
Summary: sys-devel/gdb-12.1-r2 fails to compile: ada-exp.c.tmp:576:7: error: type unio...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-06-23 16:08 UTC by Agostino Sarubbo
Modified: 2024-03-05 06:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,50.54 KB, application/x-xz)
2022-06-23 16:08 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-06-23 16:08:07 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-devel/gdb-12.1-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-06-23 16:08:10 UTC
Created attachment 787118 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-23 16:24:22 UTC
Upstream are working on the ODR violations. Bunch fixed in master but not this one yet.
Comment 3 Agostino Sarubbo gentoo-dev 2022-06-24 07:04:58 UTC
(In reply to Agostino Sarubbo from comment #0)
> Discovered on: amd64 (internal ref: tinderbox)

internal ref is: lto_tinderbox
Comment 4 Agostino Sarubbo gentoo-dev 2022-07-26 09:00:05 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 5 Agostino Sarubbo gentoo-dev 2022-11-08 10:57:15 UTC
lto_tinderbox has reproduced this issue with version 12.1-r2 - Updating summary.
Comment 6 Larry the Git Cow gentoo-dev 2023-08-13 23:39:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0262b1c837e178a7d955d13f463d8ce648ee00ad

commit 0262b1c837e178a7d955d13f463d8ce648ee00ad
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-13 10:35:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-13 23:38:01 +0000

    sys-devel/gdb: filter-lto
    
    Lots of LTO warnings acknowledged upstream.
    
    Closes: https://bugs.gentoo.org/853898
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/gdb/gdb-13.2-r2.ebuild | 3 +++
 sys-devel/gdb/gdb-9999.ebuild    | 3 +++
 2 files changed, 6 insertions(+)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-15 05:51:26 UTC
There's some upstream activity so this may even get fixed for 14...
Comment 8 Larry the Git Cow gentoo-dev 2023-09-27 07:44:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=250e119954afe9ad63a4a2bd4afae50b6cc37001

commit 250e119954afe9ad63a4a2bd4afae50b6cc37001
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-09-27 07:43:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-27 07:44:09 +0000

    sys-devel/gdb: drop filter-lto for 9999
    
    Fixed upstream.
    
    Bug: https://bugs.gentoo.org/853898
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/gdb/gdb-9999.ebuild | 8 --------
 1 file changed, 8 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2024-03-05 06:57:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff36734275bc5264ea066b3e112f06acb879ca16

commit ff36734275bc5264ea066b3e112f06acb879ca16
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-05 06:57:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-05 06:57:18 +0000

    dev-util/crash: filter LTO
    
    It's based on an old version of gdb currently which isn't LTO-safe.
    
    Bug: https://bugs.gentoo.org/853898
    Closes: https://bugs.gentoo.org/858344
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/crash/crash-8.0.3-r1.ebuild | 11 +++++++++--
 dev-util/crash/crash-8.0.4.ebuild    | 11 +++++++++--
 dev-util/crash/crash-9999.ebuild     | 11 +++++++++--
 3 files changed, 27 insertions(+), 6 deletions(-)