Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 853124 - sci-mathematics/singular patch to set htmldir has a bug
Summary: sci-mathematics/singular patch to set htmldir has a bug
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: François Bissey
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-20 00:50 UTC by François Bissey
Modified: 2022-06-22 02:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description François Bissey 2022-06-20 00:50:26 UTC
While working to upstream my current patch to install html documentation in a location defined by configure I noticed that I introduced a bug now present in all available version of singular in Gentoo. At some point the patch must have been correct but now there is a mistake which should make it impossible to access html documentation from inside singular.

In line https://github.com/gentoo/gentoo/blob/master/sci-mathematics/singular/files/singular-4.1.3-doc_install.patch#L46
AC_DEFINE_UNQUOTED([HTML_DIR],"$config_datadir",[htmldir])
should actually be
AC_DEFINE_UNQUOTED([HTML_DIR],"$config_htmldir",[htmldir])

The mistake is also found in "doc-install" patch for previous versions.

For reference upstream is rejecting the current patch because they want a relative  location in feRessource.cc - which is fair enough.
https://github.com/Singular/Singular/pull/1138
it is while working on improving the PR that I noticed the mistake,.

Reproducible: Always
Comment 1 François Bissey 2022-06-22 02:28:07 UTC
I have been developing a new comprehensive solution at https://github.com/cschwan/sage-on-gentoo/tree/vbraun/sci-mathematics/singular and I will be feeding bits of it upstream progressively.

But the previous solution was half baked and missed bits. It looks like no one has ever used the bits that I was touching.