Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 852974 - dev-qt/qtcore: FORTIFY_SOURCE=3 crash in reverse dependencies despite flag downgrade (was: kde-apps/dolphin: Crash with FORTIFY_SOURCE=3)
Summary: dev-qt/qtcore: FORTIFY_SOURCE=3 crash in reverse dependencies despite flag do...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard: qtcore F_S=3 demotion isn't enough; n...
Keywords:
Depends on:
Blocks: 847148
  Show dependency tree
 
Reported: 2022-06-19 03:20 UTC by Sam James
Modified: 2023-10-08 15:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 03:20:37 UTC
As usual, filing this to start, and then I'll add more as I go.

[ebuild   R    ] kde-apps/dolphin-22.04.2:5::gentoo  USE="activities semantic-desktop telemetry -debug -handbook -test" 0 KiB
----
Portage 3.0.30 (python 3.11.0-beta-3, default/linux/amd64/17.1/hardened, gcc-12.1.1, glibc-2.35-r7, 5.15.48-adry x86_64)
=================================================================
System uname: Linux-5.15.48-adry-x86_64-11th_Gen_Intel-R-_Core-TM-_i7-11800H_@_2.30GHz-with-glibc2.35
KiB Mem:    16101456 total,   2208432 free
KiB Swap:    8388604 total,   8388604 free
Timestamp of repository gentoo: Sat, 18 Jun 2022 00:32:59 +0000
Head commit of repository gentoo: 9bd8e4ff7cf780faee9a5d0a9cb6b13685273efa

Timestamp of repository emacs: Tue, 17 May 2022 03:23:07 +0000
Head commit of repository emacs: f3d3ec487583382d3b706340f14b04a65a274ad6

Timestamp of repository kde: Tue, 14 Jun 2022 13:03:14 +0000
Head commit of repository kde: 8fe646f8bcaaae5dd552d38e1680e7e2e272563a

Timestamp of repository qt: Wed, 15 Jun 2022 17:33:14 +0000
Head commit of repository qt: 35cd98ad729e9d2e81e80fe7de6f5c0070f4e192

sh dash 0.5.11.5
ld GNU ld (Gentoo 2.38 p4) 2.38
ccache version 4.6.1 [disabled]
app-misc/pax-utils:        1.3.4::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           3.8.13_p2::gentoo, 3.9.13::gentoo, 3.10.5::gentoo, 3.11.0_beta3::gentoo
dev-lang/rust-bin:         1.61.0::gentoo
dev-util/ccache:           4.6.1::gentoo
dev-util/cmake:            3.23.2::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           9999::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r3::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           13.0.1::gentoo, 14.0.5::gentoo
sys-devel/gcc:             11.3.1_p20220610::gentoo, 12.1.1_p20220611::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.5::gentoo
sys-devel/llvm:            13.0.1::gentoo, 14.0.5::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.18-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now
    sync-git-verify-commit-signature: yes

emacs
    location: /var/db/repos/emacs
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/emacs.git
    masters: gentoo

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo

local
    location: /var/db/repos/local
    masters: gentoo

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo

sam_c
    location: /home/sjames/git/overlay
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -ggdb3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -D_GLIBCXX_ASSERTIONS -ggdb3"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going=y --complete-graph --deep --changed-deps-report=y --usepkg=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg-exclude nvidia-drivers --usepkg-exclude gentoo-kernel --implicit-system-deps=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg buildpkg-live compressdebug config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles installsources ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/ http://mirrors.gethosted.online/gentoo"
LANG="en_GB.utf8"
LDFLAGS="-fuse-ld=lld -Wl,--as-needed -Wl,-z,relro,-z,now"
LINGUAS="en en_GB"
MAKEOPTS="-j16"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp/portage.notmp"
RUSTFLAGS="-C target-cpu=native"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 avx512bw avx512cd avx512dq avx512f avx512vbmi avx512vl bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang crypt dbus declarative dist-kernel dri dts dvd dvdr elogind emacs encode exif f16c flac fma3 fortran gif gles2 gmp gpm graphite gtk gui hardened hunspell iconv icu ipv6 iwd jit jpeg kde kwallet lcms libglvnd libnotify libtirpc mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses networkmanager nptl ogg opengl openmp pam pango pclmul pcre pdf pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha smartcard spell split-usr sse sse2 sse3 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg syslog system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-jsoncpp system-leveldb system-libevent system-libs system-libvpx system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib threads tiff truetype udev udisks unicode upower usb vaapi verify-sig vorbis vulkan wayland widgets x264 xattr xcb xml xtpax xv xvid zlib zsh-completion zstd" ABI_X86="32 64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 avx512f avx512dq avx512cd avx512bw avx512vl avx512vbmi f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_9 python3_10 python3_11 python3_8" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="intel i965 iris nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 03:22:37 UTC
First noticed when trying to add a certificate in Firefox. Shrugged it off but xdg-desktop-kde portal kept closing (file picker).

Then later, tried to open Dolphin, navigate to homedir - crash!

```
$ dolphin
*** buffer overflow detected ***: terminated
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = dolphin path = /usr/bin pid = 24863
KCrash: Arguments: /usr/bin/dolphin 
KCrash: Attempting to start /usr/lib64/libexec/drkonqi
kf5idletime_kwayland: This plugin does not support polling idle time

[1]+  Stopped                 dolphin
```

```
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=0x6, no_tid=no_tid@entry=0x0) at pthread_kill.c:44
#1  0x00007ffff587b543 in __pthread_kill_internal (signo=0x6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007ffff582b766 in __GI_raise (sig=sig@entry=0x6) at ../sysdeps/posix/raise.c:26
#3  0x00007ffff58157f4 in __GI_abort () at abort.c:79
#4  0x00007ffff586f4a6 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff59a76ca "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:155
#5  0x00007ffff590e71a in __GI___fortify_fail (msg=msg@entry=0x7ffff59a7670 "buffer overflow detected") at fortify_fail.c:26
#6  0x00007ffff590d036 in __GI___chk_fail () at chk_fail.c:28
#7  0x00007ffff590d514 in __readlink_chk (path=<optimized out>, buf=<optimized out>, len=<optimized out>, buflen=<optimized out>) at readlink_chk.c:30
#8  0x00007fffe004a10f in readlink (__len=0x100, __buf=<optimized out>, __path=<optimized out>) at /usr/include/bits/unistd.h:119
#9  createUDSEntry (filename=..., path=..., entry=..., details=details@entry=..., fullPath=...) at /var/tmp/portage.notmp/portage/kde-frameworks/kio-5.95.0/work/kio-5.95.0/src/ioslaves/file/file_unix.cpp:396
#10 0x00007fffe004b35e in FileProtocol::listDir (this=0x7fff7c0049d0, url=...) at /usr/include/qt5/QtCore/qstringbuilder.h:164
#11 0x00007ffff78a81ad in KIO::SlaveBase::dispatch (this=0x7fff7c0049e0, command=0x47, data=...) at /var/tmp/portage.notmp/portage/kde-frameworks/kio-5.95.0/work/kio-5.95.0/src/core/slavebase.cpp:1283
#12 0x00007ffff78a8c56 in KIO::SlaveBase::dispatchLoop (this=0x7fff7c0049e0) at /var/tmp/portage.notmp/portage/kde-frameworks/kio-5.95.0/work/kio-5.95.0/src/core/slavebase.cpp:337
#13 0x00007ffff793bc50 in KIO::WorkerThread::run (this=0x555555ebe550) at /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/g++-v12/bits/unique_ptr.h:191
#14 0x00007ffff5cf4ec7 in QThreadPrivate::start (arg=0x555555ebe550) at /var/tmp/portage.notmp/portage/dev-qt/qtcore-5.15.4-r3/work/qtbase-everywhere-src-5.15.4/src/corelib/thread/qthread_unix.cpp:331
#15 0x00007ffff58796fd in start_thread (arg=<optimized out>) at pthread_create.c:442
#16 0x00007ffff58ff940 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
```
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 03:35:49 UTC
This really smells like bug 847145 again with the QArray bits, but I guess that's so generic that we can't be sure yet.

Interestingly, even with opensuse's patch (which should be enough for that problem), I still get the failure.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 03:53:30 UTC
I think we do actually need the openSUSE patch. Qt 5's QArray is broken without it and building qtcore w/o enhanced fortification is insufficient if its headers (and we're in C++ land) are bad.

- Build qtcore without the patch and then kio => broken
- Build qtcore without the patch, then kio, then qtcore with the patch => broken
- Build qtcore with the patch, then kio, then qtcore without the patch => works
- Build qtcore with the patch and then kio => works 

FWIW, the openSUSE patch wasn't criticised by Qt in the upstream bug, and it matches the instructions that Qt gave to a developer to fix the problem for (closed) 5.15. We'll see their patch in a year's time.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-19 03:54:18 UTC
(In reply to Sam James from comment #3)
> I think we do actually need the openSUSE patch. Qt 5's QArray is broken
> without it and building qtcore w/o enhanced fortification is insufficient if
> its headers (and we're in C++ land) are bad.

Patch being: https://bugs.gentoo.org/847145#c9.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-26 08:18:02 UTC
Patch was accepted in Qt5PatchCollection.
Comment 6 Larry the Git Cow gentoo-dev 2022-06-26 08:25:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb10b0356e62b2521c0d4592a35b5dfb6e5cd2ca

commit cb10b0356e62b2521c0d4592a35b5dfb6e5cd2ca
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-26 08:22:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-26 08:25:13 +0000

    dev-qt/qtcore: backport FORTIFY_SOURCE=3 patch
    
    GCC 12 is now in ~arch and we're likely to get more people trying
    out F_S=3 as a result. This patch is now in Qt5PatchCollection
    and given the previous workaround ended up being insufficient
    (it's not enough to force F_S=2 in qtcore, as reverse deps
    end up being broken if _they_ are built with F_S=3, even
    though the cause is in qtcore), let's backport the fix now.
    
    Bug: https://bugs.gentoo.org/847145
    Closes: https://bugs.gentoo.org/852974
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/qtcore-5.15.5-fortify-source-3.patch     |  61 ++++++++++++
 dev-qt/qtcore/qtcore-5.15.5-r1.ebuild              | 102 +++++++++++++++++++++
 2 files changed, 163 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2023-08-06 11:49:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a84e57a1963e12919d9b843324d70b12e992bc7

commit 5a84e57a1963e12919d9b843324d70b12e992bc7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:41:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-06 11:47:53 +0000

    dev-qt/qtcore: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847145
    Bug: https://bugs.gentoo.org/852974
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-qt/qtcore/qtcore-5.15.10-r1.ebuild | 5 +++--
 dev-qt/qtcore/qtcore-5.15.10.ebuild    | 7 +++----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2023-10-08 15:21:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=ec1cae0ebc814755c9cf1dd5b5a70d1777d422b8

commit ec1cae0ebc814755c9cf1dd5b5a70d1777d422b8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:41:48 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-10-08 15:20:41 +0000

    dev-qt/qtcore: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847145
    Bug: https://bugs.gentoo.org/852974
    Signed-off-by: Sam James <sam@gentoo.org>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtcore/qtcore-5.15.11.9999.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)