https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-video/mjpg-streamer-0_pre20200524-r1 installs shell script that uses non-POSIX features. Discovered on: amd64 (internal ref: tinderbox)
Created attachment 781403 [details] build.log build log and emerge --info
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a15764fea542d473a1abf67ccccd8fd5dee68d5 commit 1a15764fea542d473a1abf67ccccd8fd5dee68d5 Author: ChaosEngine <andrzej.pauli@gmail.com> AuthorDate: 2022-06-12 15:38:23 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-07-02 17:35:14 +0000 media-video/mjpg-streamer: fix init script's non-POSIX features Closes: https://bugs.gentoo.org/848474 Signed-off-by: Andrzej Pauli (@ChaosEngine) <andrzej.pauli@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/25865 Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-video/mjpg-streamer/files/mjpg-streamer.initd | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Re-opening because the referenced commit does not fix all of the POSIX violations. The matter of [[ vs [ is only one of several conformance issues in the runscript. If you don't mind waiting, I already have a commit that deals with all of them in a branch I'm presently working on (I'm examining all of the 609070 blockers in detail).
Created attachment 789647 [details, diff] 0001-media-video-mjpg-streamer-Avoid-non-POSIX-features-i.patch I didn't want to publish any patches before I'd finished but I'll make an exception in this case. This attachment actually rectifies all of the issues.
Thanks! I'm not too familiar with POSIX but dev-util/checkbashisms didn't complain if I remember correctly so I just trusted that.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e565ecb9cc44e7af96faf0f1b50c2a5a142dc7ca commit e565ecb9cc44e7af96faf0f1b50c2a5a142dc7ca Author: Kerin Millar <kfm@plushkava.net> AuthorDate: 2022-07-01 20:01:32 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-07-03 06:06:43 +0000 media-video/mjpg-streamer: Avoid non-POSIX features in runscript Use [ rather than [[ (SC3010). Don't use += (SC3024). Don't use string replacing forms of parameter expansion (SC3060); instead use tr(1). Closes: https://bugs.gentoo.org/848474 Signed-off-by: Kerin Millar <kfm@plushkava.net> Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-video/mjpg-streamer/files/mjpg-streamer.initd | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
Thanks (In reply to Kerin Millar from comment #4) > Created attachment 789647 [details, diff] [details, diff] > 0001-media-video-mjpg-streamer-Avoid-non-POSIX-features-i.patch > > I didn't want to publish any patches before I'd finished but I'll make an > exception in this case. This attachment actually rectifies all of the issues. Thanks Kerin, it never occurred to me that there may be other POSIX-bashism, never was a specialist on this matter. Much apprieciated.
(In reply to ChaosEngine from comment #7) > Thanks Kerin, it never occurred to me that there may be other POSIX-bashism, > never was a specialist on this matter. > Much apprieciated. You are quite welcome.