Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 847280 - sys-apps/acl: broken with FORTIFY_SOURCE=3, causes e.g. systemd-tmpfiles to crash
Summary: sys-apps/acl: broken with FORTIFY_SOURCE=3, causes e.g. systemd-tmpfiles to c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 847148
  Show dependency tree
 
Reported: 2022-05-24 16:58 UTC by Sam James
Modified: 2024-01-24 06:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-24 16:58:00 UTC
Noticed when the volatile directories/files service was hanging on boot.

Came down to:
```
# systemd-tmpfiles --create
/usr/lib/tmpfiles.d/dbus.conf:13: Line references path below legacy directory /var/run/, updating /var/run/dbus/containers → /run/dbus/containers; please update the tmpfiles.d/ drop-in file accordingly.
*** buffer overflow detected ***: terminated
Aborted (core dumped)
```

```
Core was generated by `systemd-tmpfiles --create'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f07875674ec in ?? () from /usr/lib64/libc.so.6
gef➤  bt
#0  0x00007f07875674ec in ?? () from /usr/lib64/libc.so.6
#1  0x00007f07875165e2 in raise () from /usr/lib64/libc.so.6
#2  0x00007f078750046c in abort () from /usr/lib64/libc.so.6
#3  0x00007f078755b126 in ?? () from /usr/lib64/libc.so.6
#4  0x00007f07875face2 in __fortify_fail () from /usr/lib64/libc.so.6
#5  0x00007f07875f96c2 in __chk_fail () from /usr/lib64/libc.so.6
#6  0x00007f07875f90e9 in __strncpy_chk () from /usr/lib64/libc.so.6
#7  0x00007f07876dff5e in strncpy (__len=0x4b, __src=0x557d9f5b2860 "adm", __dest=<optimized out>) at /usr/include/bits/string_fortified.h:95
#8  acl_entry_to_any_str (options=0x10, prefix=0x0, mask_d=0x0, size=0x4b, text_p=<optimized out>, entry_d=0x557d9f5b1dc0) at /usr/src/debug/sys-apps/acl-2.3.1/acl-2.3.1/libacl/__acl_to_any_text.c:188
#9  __acl_to_any_text (acl=<optimized out>, len_p=len_p@entry=0x0, prefix=prefix@entry=0x0, separator=separator@entry=0x2c, suffix=suffix@entry=0x0, options=options@entry=0x10) at /usr/src/debug/sys-apps/acl-2.3.1/acl-2.3.1/libacl/__acl_to_any_text.c:66
#10 0x00007f07876df2b3 in acl_to_any_text (acl=<optimized out>, prefix=prefix@entry=0x0, separator=separator@entry=0x2c, options=options@entry=0x10) at /usr/src/debug/sys-apps/acl-2.3.1/acl-2.3.1/libacl/acl_to_any_text.c:33
#11 0x0000557d9f21f79b in path_set_acl (path=path@entry=0x7fff83e33650 "/proc/self/fd/4", pretty=pretty@entry=0x557d9f5b3780 "/var/log/journal", type=type@entry=0x8000, acl=acl@entry=0x557d9f5ae8f8, modify=modify@entry=0x1) at ../systemd-251/src/tmpfiles/tmpfiles.c:1096
#12 0x0000557d9f229a3d in fd_set_acls (item=item@entry=0x557d9f5c3560, fd=fd@entry=0x4, path=path@entry=0x557d9f5b3780 "/var/log/journal", st=0x7fff83e335c0, st@entry=0x0) at ../systemd-251/src/tmpfiles/tmpfiles.c:1143
#13 0x0000557d9f229e2a in path_set_acls (item=0x557d9f5c3560, path=0x557d9f5b3780 "/var/log/journal") at ../systemd-251/src/tmpfiles/tmpfiles.c:1179
#14 0x0000557d9f220786 in glob_item (i=0x557d9f5c3560, action=0x557d9f229df0 <path_set_acls>) at ../systemd-251/src/tmpfiles/tmpfiles.c:1946
#15 0x0000557d9f228088 in create_item (i=<optimized out>) at ../systemd-251/src/tmpfiles/tmpfiles.c:2358
#16 process_item (operation=OPERATION_CREATE, i=0x557d9f5c3560) at ../systemd-251/src/tmpfiles/tmpfiles.c:2575
#17 process_item_array (array=<optimized out>, operation=operation@entry=OPERATION_CREATE) at ../systemd-251/src/tmpfiles/tmpfiles.c:2614
#18 0x0000557d9f21ea39 in run (argv=<optimized out>, argc=<optimized out>) at ../systemd-251/src/tmpfiles/tmpfiles.c:3851
#19 main (argc=<optimized out>, argv=<optimized out>) at ../systemd-251/src/tmpfiles/tmpfiles.c:3866
```
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-24 16:58:19 UTC
Portage 3.0.30 (python 3.11.0-beta-1, default/linux/amd64/17.1/hardened, gcc-12.1.1, glibc-2.35-r5, 5.15.41-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.15.41-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.35
KiB Mem:    65831160 total,  54249496 free
KiB Swap:   25067512 total,  25067512 free
Timestamp of repository gentoo: Tue, 24 May 2022 16:47:58 +0000
Head commit of repository gentoo: 929ecc96a3cb2154985262a003dda3b2c2676930

Timestamp of repository kde: Wed, 18 May 2022 12:47:53 +0000
Head commit of repository kde: db3a6d11f3516e4a0d7b675ece4c746bbaef5b86

Timestamp of repository qt: Fri, 20 May 2022 19:48:17 +0000
Head commit of repository qt: 7a50fd9809b2ec7b0f8cc8dcb78b01edc98e1264

Timestamp of repository sam_c: Thu, 19 May 2022 04:32:58 +0000
Head commit of repository sam_c: 1ffb82265b993e2816c583f06299a77de27aa6b6

Timestamp of repository steam-overlay: Sun, 22 May 2022 13:08:27 +0000
Head commit of repository steam-overlay: ee8335c18481d2f553de3f4ee3320d76cc8905fb

sh dash 0.5.11.5
ld GNU ld (Gentoo 2.38 p4) 2.38
ccache version 4.6.1 [disabled]
app-misc/pax-utils:        1.3.4::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.34.1-r3::gentoo
dev-lang/python:           2.7.18_p15::gentoo, 3.8.13_p2::gentoo, 3.9.13::gentoo, 3.10.4_p1::gentoo, 3.11.0_beta1-r2::gentoo
dev-lang/rust-bin:         1.60.0::gentoo
dev-util/ccache:           4.6.1::gentoo
dev-util/cmake:            3.23.1::gentoo
dev-util/meson:            0.62.1::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          251::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           13.0.1::gentoo, 14.0.3::gentoo
sys-devel/gcc:             9.4.0::gentoo, 10.3.1_p20211126::gentoo, 11.3.0::gentoo, 12.1.1_p20220521::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.3::gentoo
sys-devel/llvm:            13.0.1::gentoo, 14.0.3::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.17-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r5::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

test
    location: /var/db/repos/test
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -D_GLIBCXX_ASSERTIONS"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=2 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live cgroup clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS="en en_GB"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr clang crypt dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif f16c filecaps firewalld flac fma3 freetype gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libglvnd libnotify libtirpc llvm-libunwind mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd threads tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets x264 xattr xcb xml xtpax xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_9 pypy3 python3_10 python3_11 python3_8" QEMU_USER_TARGETS="aarch64 hppa ppc64le sparc64" RUBY_TARGETS="ruby30" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-24 16:58:54 UTC
Our friends at GCC already hit this and concluded it was an ACL bug, not a GCC one: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104964.

But it's not been reported upstream AFAICT.

opensuse has disabled F_S=3 for now in their ACL package.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-24 17:04:53 UTC
Reported upstream to acl at https://savannah.nongnu.org/bugs/index.php?62519.
Comment 4 Larry the Git Cow gentoo-dev 2022-05-24 17:19:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0bea576460def7e195e79059ed74e8725b884f9c

commit 0bea576460def7e195e79059ed74e8725b884f9c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-24 17:19:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-24 17:19:26 +0000

    sys-apps/acl: disable FORTIFY_SOURCE=3
    
    Known broken, bug in ACL, and reported upstream. Do as e.g. opensuse
    have done and disable it for this package for now.
    
    Closes: https://bugs.gentoo.org/847280
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/acl/acl-2.3.1-r1.ebuild | 78 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-05-24 22:40:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a78d96a1f00a35bf44e820c7c402741a92d34468

commit a78d96a1f00a35bf44e820c7c402741a92d34468
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-24 22:40:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-24 22:40:25 +0000

    sys-apps/acl: filter-flags for F_S=3
    
    Bug: https://bugs.gentoo.org/847280
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/acl/acl-2.3.1-r1.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-08-06 11:49:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc9abc19ceb0c3bb7d2632394c38f4772f490ca8

commit cc9abc19ceb0c3bb7d2632394c38f4772f490ca8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:43:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-06 11:48:37 +0000

    sys-apps/acl: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847280
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/acl/acl-2.3.1-r1.ebuild | 6 ++----
 sys-apps/acl/acl-2.3.1-r2.ebuild | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2024-01-24 06:28:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=480fa4246adb1700d8beb568b601db7cd6879c3e

commit 480fa4246adb1700d8beb568b601db7cd6879c3e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-24 06:24:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-24 06:27:10 +0000

    sys-apps/acl: add 2.3.2
    
    Bug: https://bugs.gentoo.org/847280
    Bug: https://bugs.gentoo.org/905910
    Closes: https://bugs.gentoo.org/912733
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/acl/Manifest         |  1 +
 sys-apps/acl/acl-2.3.2.ebuild | 62 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)