Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 846989 - dev-util/pkgcheck-0.10.10 UnusedInherits false positive
Summary: dev-util/pkgcheck-0.10.10 UnusedInherits false positive
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-22 13:20 UTC by Sebastian Pipping
Modified: 2022-05-22 23:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Pipping gentoo-dev 2022-05-22 13:20:25 UTC
Hi!

pkgcheck 0.10.10 reports…

  UnusedInherits: version 1.12-r6: unused eclass: gnome2-utils

…on x11-misc/redshift which turned out a false positive, given that the
ebuild's uses three gnome2_* functions from that very eclass.
Is there anything I can do on my end to not get false positives like that?

Thanks and best, Sebastian
Comment 1 Stephan Hartmann gentoo-dev 2022-05-22 13:27:21 UTC
gnome2_icon_savelist and gnome2_icon_cache_update are only defined for EAPI 5 and EAPI 6:
https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/gnome2-utils.eclass#n491

You should migrate to xdg-utils eclass.
Comment 2 Sebastian Pipping gentoo-dev 2022-05-22 14:21:24 UTC
That's a great point, but the warning is also produced for ebuilds that are indeed EAPI 6:

  DeprecatedEapi: version 1.12-r5: uses deprecated EAPI 6
  UnusedInherits: version 1.12-r5: unused eclass: gnome2-utils

So the eclass is not unused on those ebuilds.  Am I missing something else?
Comment 3 Mike Gilbert gentoo-dev 2022-05-22 15:49:13 UTC
I suspect the eclass parsing/caching code does not handle functions that are only defined for specific EAPI values. Therefore, pkgcheck does not think that gnome2-utils.eclass defines those functions.