Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 846398 - media-libs/xine-lib-1.2.11 fails to compile: dav1d.c:540:11: error: Dav1dSettings has no member named n_frame_threads
Summary: media-libs/xine-lib-1.2.11 fails to compile: dav1d.c:540:11: error: Dav1dSett...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-19 06:51 UTC by Agostino Sarubbo
Modified: 2022-05-19 22:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,297.01 KB, text/plain)
2022-05-19 06:51 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-05-19 06:51:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/xine-lib-1.2.11 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-05-19 06:51:07 UTC
Created attachment 779474 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-19 07:09:05 UTC
ugh, I forgot about this.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-19 07:10:08 UTC
likely to just mask the flag for this version
Comment 4 Ulrich Müller gentoo-dev 2022-05-19 09:27:46 UTC
xine-lib-1.2.11 $ ./configure --help | grep dav1d
  --with-dav1d            Enable dav1d AV1 decoder support (default: enabled)

Presumably the ebuild should have a dav1d use flag, plus a conditional dependency on <media-libs/dav1d-1.
Comment 5 Thomas Raschbacher gentoo-dev 2022-05-19 11:13:33 UTC
@sam there'S a patch on the debian mailinglist: 
https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1848864.html
Comment 6 Thomas Raschbacher gentoo-dev 2022-05-19 11:50:59 UTC
FreeBSD is using the same patch too

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262651

@sam If you want I can take care of this later if you are busy - just at work now so no dev box.
Comment 7 Kobboi 2022-05-19 14:16:58 UTC
Also, do we need to reopen bug #831483 because of this?
Comment 8 Kobboi 2022-05-19 14:59:28 UTC
The patch you are mentioning already is in the tree, applied to 1.2.12. Looks to me like we want to just copy xine-lib-1.2.12-r1 to 1.2.11 (and rename the patch).
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-19 15:33:21 UTC
(In reply to Ulrich Müller from comment #4)
> xine-lib-1.2.11 $ ./configure --help | grep dav1d
>   --with-dav1d            Enable dav1d AV1 decoder support (default: enabled)
> 
> Presumably the ebuild should have a dav1d use flag, plus a conditional
> dependency on <media-libs/dav1d-1.

The masked version has such a flag.

(In reply to Thomas Raschbacher from comment #6)
> FreeBSD is using the same patch too
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262651
> 
> @sam If you want I can take care of this later if you are busy - just at
> work now so no dev box.

Thanks! Please commit the patch from the crash bug if it works for you and drop the mask instead.

If the patch for the crashy version doesn't work, just --disable-dav1d for this older version.
Comment 10 Larry the Git Cow gentoo-dev 2022-05-19 22:46:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be42b487bdbb8acdb5c3765710a3a785f2e38c9e

commit be42b487bdbb8acdb5c3765710a3a785f2e38c9e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-19 22:40:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-19 22:45:42 +0000

    media-libs/xine-lib: disable dav1d for 1.2.11
    
    1.2.12 has dav1d support enabled properly (and a patch for >= 1.0.0)
    but in 1.2.11, it was automagic. Let's just disable it entirely
    in 1.2.11 given that it fails to build and we've had to mask (for now)
    1.2.12 because of crashes.
    
    Closes: https://bugs.gentoo.org/846398
    Bug: https://bugs.gentoo.org/835791
    Bug: https://bugs.gentoo.org/845396
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xine-lib/{xine-lib-1.2.11.ebuild => xine-lib-1.2.11-r1.ebuild}   | 5 +++--
 media-libs/xine-lib/xine-lib-1.2.9999.ebuild                         | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)