Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 845987 - games-strategy/0ad: needs upgrade to Python 3.10 (PythonCompatUpdate)
Summary: games-strategy/0ad: needs upgrade to Python 3.10 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: py310, python3.10-compat
  Show dependency tree
 
Reported: 2022-05-18 18:58 UTC by Sam James
Modified: 2022-06-07 00:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
compressed buil log with python 3.10 enabled (0ad-python-3.10.gz,174.66 KB, application/gzip)
2022-05-31 10:43 UTC, tt_1
Details
output of emerge --info (emerge-info,5.67 KB, text/plain)
2022-05-31 10:44 UTC, tt_1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-18 18:58:44 UTC
This package does not support Python 3.10. Please test it with Python 3.10 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://archives.gentoo.org/gentoo-dev/message/13aa993921f19b6b095297721ffb0d0b. Ask in #gentoo-python on IRC if need any help.

$ pkgcheck scan -k PythonCompatUpdate games-strategy/0ad
games-strategy/0ad
  PythonCompatUpdate: version 0.0.25b_alpha: PYTHON_COMPAT updates available: python3_10, python3_11
Comment 1 tt_1 2022-05-31 10:41:43 UTC
internal spidermonkey needs patching: 


Building SpiderMonkey...

SpiderMonkey build options: --disable-tests
           --disable-jemalloc
           --disable-js-shell
           --without-intl-api
           --enable-shared-js
           --disable-jitspew   --host=x86_64-pc-linux-gnu   
patching file js/src/build/moz.build
patching file mozglue/build/moz.build
patching file config/makefiles/target_binaries.mk
patching file js/src/moz.build
patching file js/src/old-configure
patching file js/public/StructuredClone.h
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 381 with fuzz 1 (offset 53 lines).
patching file js/public/AllocPolicy.h
Hunk #1 succeeded at 109 (offset 2 lines).
Hunk #2 succeeded at 175 (offset 3 lines).
patching file js/public/RootingAPI.h
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 931 with fuzz 1.
patching file build/moz.configure/toolchain.configure
patching file build/moz.configure/toolchain.configure
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 141 with fuzz 1.
patching file js/src/wasm/WasmSignalHandlers.cpp
patching file .cargo/config.in
patching file Cargo.lock
patching file Cargo.toml
patching file python/mozbuild/mozbuild/configure/__init__.py
Hunk #1 succeeded at 875 (offset -2 lines).
Hunk #2 succeeded at 950 (offset -2 lines).
Traceback (most recent call last):
  File "/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha/libraries/source/spidermonkey/mozjs-78.6.0/build-debug/../js/src/../../configure.py", line 25, in <module>
    from mozbuild.configure import (
  File "/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/configure/__init__.py", line 33, in <module>
    from mozbuild.util import (
  File "/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 760, in <module>
    class HierarchicalStringList(object):
  File "/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha/libraries/source/spidermonkey/mozjs-78.6.0/python/mozbuild/mozbuild/util.py", line 785, in HierarchicalStringList
    class StringListAdaptor(collections.Sequence):
AttributeError: module 'collections' has no attribute 'Sequence'
 * ERROR: games-strategy/0ad-0.0.25b_alpha::gentoo failed (compile phase):
 *   Failed to build bundled SpiderMonkey
 * 
 * Call stack:
 *     ebuild.sh, line 127:  Called src_compile
 *   environment, line 2953:  Called die
 * The specific snippet of code:
 *       XARGS="${EPREFIX}/usr/bin/xargs" JOBS="-j$(makeopts_jobs)" ./build.sh || die "Failed to build bundled SpiderMonkey";
 * 
 * If you need support, post the output of `emerge --info '=games-strategy/0ad-0.0.25b_alpha::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=games-strategy/0ad-0.0.25b_alpha::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/temp/environment'.
 * Working directory: '/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha/libraries/source/spidermonkey'
 * S: '/var/tmp/portage/games-strategy/0ad-0.0.25b_alpha/work/0ad-0.0.25b-alpha'
Comment 2 tt_1 2022-05-31 10:43:33 UTC
Created attachment 781631 [details]
compressed buil log with python 3.10 enabled
Comment 3 tt_1 2022-05-31 10:44:22 UTC
Created attachment 781634 [details]
output of emerge --info
Comment 4 tt_1 2022-05-31 10:47:45 UTC
official backport is here: 

https://github.com/0ad/0ad/commit/c2ec217eea6952c4877095969e11900b70c7cda3
Comment 5 tt_1 2022-05-31 11:18:13 UTC
to make things fly for 0.0.25b, you have to backport the changes to patch.sh locally and refresh the patch accordingly.
Comment 6 Larry the Git Cow gentoo-dev 2022-06-07 00:41:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1016e0bb4a875a396f1f46aa3cec3037251b934

commit a1016e0bb4a875a396f1f46aa3cec3037251b934
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-07 00:40:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-07 00:41:23 +0000

    games-strategy/0ad: backport build patches
    
    Given how fragile the build system can be, it's worth a revbump.
    
    Closes: https://bugs.gentoo.org/834578
    Closes: https://bugs.gentoo.org/845987
    Signed-off-by: Sam James <sam@gentoo.org>

 games-strategy/0ad/0ad-0.0.25b_alpha-r1.ebuild     | 264 +++++++++++++++++++++
 ...ad-0.0.25b_alpha-fix-name-collision-glibc.patch | 131 ++++++++++
 .../0ad/files/0ad-0.0.25b_alpha-python3.10.patch   | 156 ++++++++++++
 3 files changed, 551 insertions(+)