Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84285 - confusion of actions and options in emerge manpage
Summary: confusion of actions and options in emerge manpage
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Documentation (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 115839
  Show dependency tree
 
Reported: 2005-03-06 04:08 UTC by Benno Schulenberg
Modified: 2006-01-27 19:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
groups all actions together (emerge-actions-options.patch,6.68 KB, patch)
2005-03-06 04:09 UTC, Benno Schulenberg
Details | Diff
groups all actions together (emerge-actions-options.2.patch,7.86 KB, patch)
2006-01-08 05:39 UTC, Benno Schulenberg
Details | Diff
groups all actions together, on the portage_2_0 trunk (emerge-actions-options--trunk.patch,6.38 KB, patch)
2006-01-08 10:01 UTC, Benno Schulenberg
Details | Diff
adds --resume to the synopsis, makes the wording more uniform, and removes the mentioning of "inject" (emerge-actions-options--trunk-extras.patch,2.19 KB, patch)
2006-01-08 10:07 UTC, Benno Schulenberg
Details | Diff
groups all actions together (emerge-actions-options--again.patch,6.32 KB, patch)
2006-01-08 11:24 UTC, Benno Schulenberg
Details | Diff
adds --resume and --config to the synopsis for greater visibility, puts --config in its alphabetical place, and makes the wording more uniform (emerge-synopsis-language.patch,2.53 KB, patch)
2006-01-09 12:59 UTC, Benno Schulenberg
Details | Diff
cleans up the description of the letters printed by --pretend (emerge-pretend-letters.patch,1017 bytes, patch)
2006-01-09 13:19 UTC, Benno Schulenberg
Details | Diff
regroups the actions in the emerge --help text, and adds --nocolor to it (emergehelp.py-regroup-actions.patch,7.33 KB, patch)
2006-01-09 15:31 UTC, Benno Schulenberg
Details | Diff
adapted synopsis patch (emerge-synopsis-language.patch,2.49 KB, patch)
2006-01-17 07:23 UTC, Benno Schulenberg
Details | Diff
adapted letters patch (emerge-pretend-letters.patch,1018 bytes, patch)
2006-01-17 07:24 UTC, Benno Schulenberg
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Schulenberg 2005-03-06 04:08:57 UTC
The man page of emerge lists such things as --depclean and --sync, that 
do not take an argument, under Actions, but lists the comparable --resume 
under Options.  In my opinion a sensible division of actions and options 
is this: anything that doesn't combine with any other action is an action, 
anything that modifies one or more actions is an option.

Then --depclean, --info, --metadata, --regen, --resume, --sync and --version 
are (special) actions, and --help, --search and --searchdesc too.

And --clean, --inject, --prune, --unmerge, --update and --upgradeonly are 
normal actions: taking ebuilds and such as arguments.  The rest are options.

Attached patch groups all actions together.

(If desired, I can make a similar patch for 'emerge --help'.)


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Benno Schulenberg 2005-03-06 04:09:42 UTC
Created attachment 52776 [details, diff]
groups all actions together
Comment 2 SpanKY gentoo-dev 2005-03-08 19:22:38 UTC
this kind of logic needs to be decided on by the portage team before the docs will be touched up ...
Comment 3 Benno Schulenberg 2005-03-09 10:45:32 UTC
> this kind of logic needs to be decided on by the portage team
> before the docs will be touched up ...

Shall I post to portage-dev, or is this not a good time?  Or is it
already being discussed behind the scenes?

(Another possibility of course is to consider only normal actions (those that
can take an ebuild as argument) as actions, and all the others as options.
This probably comes closer to the usual naming scheme, where --version and
--help are special options that cancel the normal behaviour of a command.)

(A third possibility, and my preference, is to make three categories:
actions  -- those that can take an ebuild argument,
specials -- those that cancel the normal pacakage-installing behaviour
            and make emerge do something else instead,
options  -- those that modify most actions and some of the specials.)
Comment 4 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-01-07 10:53:50 UTC
+1 on this patch, we discussed this a while back when I wrote the action based emerge thats been sitting on my hard drive for quite some time.  I'd prefer if it made it into trunk sometime :)
Comment 5 Brian Harring (RETIRED) gentoo-dev 2006-01-07 16:35:54 UTC
update it and it's in.
Comment 6 Benno Schulenberg 2006-01-08 05:39:32 UTC
Created attachment 76518 [details, diff]
groups all actions together

Updated patch.  (It additionally doubles four single spaces between sentences; they caught my eye.)
Comment 7 Brian Harring (RETIRED) gentoo-dev 2006-01-08 06:11:35 UTC
err... what was that split against?  2.1_pre3?
Comment 8 Benno Schulenberg 2006-01-08 10:01:05 UTC
Created attachment 76537 [details, diff]
groups all actions together, on the portage_2_0 trunk

The previous patch was against HEAD (revision 1.74).  This new patch is against the portage_2_0 branch (revision 1.70.2.16).

Am I looking in the right place here?:
http://www.gentoo.org/cgi-bin/viewcvs.cgi/portage/man/emerge.1?root=gentoo-src&rev=1.74&sortby=date&view=log
Comment 9 Benno Schulenberg 2006-01-08 10:07:59 UTC
Created attachment 76539 [details, diff]
adds --resume to the synopsis, makes the wording more uniform, and removes the mentioning of "inject"

If this patch is accepted, I'll make a similar one for HEAD.
Comment 10 Brian Harring (RETIRED) gentoo-dev 2006-01-08 10:51:45 UTC
Nope, that's cvs head;
pull down the portage-2.1_pre3 tarball, and work from the manpages there- I'd tell you to use anonsvn, but we're still waiting on that.

Alternatively, viewcvstest.gentoo.org/portage/main/trunk/man is another route.

Pardon the 101 jumps here; literally, once I've got the patch, assuming it's sane it's in.

Thanks
Comment 11 Benno Schulenberg 2006-01-08 11:24:57 UTC
Created attachment 76543 [details, diff]
groups all actions together

This one's against viewcvstest.gentoo.org/portage/main/trunk/man/emerge.1, revision 2505.
Comment 12 Brian Harring (RETIRED) gentoo-dev 2006-01-08 18:52:08 UTC
insvn rev2553

Got any more? ;)
Comment 13 Benno Schulenberg 2006-01-09 12:59:05 UTC
Created attachment 76665 [details, diff]
adds --resume and --config to the synopsis for greater visibility, puts --config in its alphabetical place, and makes the wording more uniform

> Got any more? ;)

Sure.  :)  Here's the first.  More to come.

Question: isn't --inject long dead?  Any reason it is still in this man page?
Comment 14 Benno Schulenberg 2006-01-09 13:19:55 UTC
Created attachment 76667 [details, diff]
cleans up the description of the letters printed by --pretend
Comment 15 Benno Schulenberg 2006-01-09 15:31:03 UTC
Created attachment 76676 [details, diff]
regroups the actions in the emerge --help text, and adds --nocolor to it
Comment 16 Benno Schulenberg 2006-01-17 06:32:47 UTC
Ping.  Harring?  Any chance the last three patches could go in?
Comment 17 Brian Harring (RETIRED) gentoo-dev 2006-01-17 06:48:51 UTC
Pardon the delay- been getting schmucked by work/real life time wise.

patch 1
s:Make sure none of the output:Disable color output:

patch 2
s:better version:newer version:
Better being relative ;)
Not sure on the slot wording change offhand though

patch 3
Nice catch, kind of a forgotten file usually.  Any thoughts/ideas on how to auto generate that?  Whether generating a man page from emergehelp output, or generating emergehelp data/text from man page...

Reasoning being, at least in my case, I'm an idiot and suck at remembering to update something in two different places- one spot, yeah, I can get that, but two?  Taxes the brain ;)

Thoughts?
Comment 18 Benno Schulenberg 2006-01-17 07:22:30 UTC
> patch 1
> s:Make sure none of the output:Disable color output:

Yes, better, will make that change.

> patch 2
> s:better version:newer version:

Not quite: a better version is not always newer: when a newer version later appears to be borked, portage will sometimes downgrade to an older and 'better' version -- "U" is then accompanied by "D".  Also when manually installing an older version, "UD" will be shown -- so "U" seems to mean "different", not "newer".  Adapted patch is coming.

About the slot installation: there's no need to mention "new", as "S" is always accompanied by "N".

> patch 3
> Any thoughts/ideas on how to auto generate that?

No, but it's not needed, I think.  When no one files bugs on it, it apparently doesn't get used much.  :)  And personally I like it that the text isn't the same as the man page: some different wording and more examples are nice to see.
Comment 19 Benno Schulenberg 2006-01-17 07:23:46 UTC
Created attachment 77353 [details, diff]
adapted synopsis patch
Comment 20 Benno Schulenberg 2006-01-17 07:24:48 UTC
Created attachment 77354 [details, diff]
adapted letters patch
Comment 21 Jason Stubbs (RETIRED) gentoo-dev 2006-01-27 19:25:40 UTC
Released in 2.1_pre4