Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 842246 - rust-toolchain.eclass: needs major overhaul
Summary: rust-toolchain.eclass: needs major overhaul
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 671736
Blocks: 769452 769467
  Show dependency tree
 
Reported: 2022-05-02 21:49 UTC by Georgy Yakovlev
Modified: 2024-02-14 01:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2022-05-02 21:49:22 UTC
currently there are multiple problems with the eclass that need addressing:

* CHOST matcher assumes only upstream-provided triplets
* SRC_URI assumes only upstream dist tarballs
* the whole matching is hacky and hardcoded, it needs to be improved.
* mixes sh and bash syntax, should consistently use the latter
Comment 1 Larry the Git Cow gentoo-dev 2022-06-25 05:36:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0a82c42c13340743296461c0b594c5ad2f8a116

commit c0a82c42c13340743296461c0b594c5ad2f8a116
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-25 05:34:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-25 05:35:20 +0000

    profiles/arch/sparc: force dev-lang/rust[system-bootstrap]
    
    Needed for now until dev-lang/rust learns how to use our
    bootstrap tarball which we inject into dev-lang/rust-bin
    for sparc.
    
    Bug: https://bugs.gentoo.org/842246
    Bug: https://bugs.gentoo.org/769467
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/sparc/package.use.force | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2022-06-25 05:40:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e791aea82a45010c220f1101ce0485f4a5d6ca1

commit 0e791aea82a45010c220f1101ce0485f4a5d6ca1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-25 05:39:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-25 05:39:37 +0000

    profiles/arch/sparc: mask dev-lang/rust-bin[clippy,doc,rls,rustfmt]
    
    Bug: https://bugs.gentoo.org/769467
    Bug: https://bugs.gentoo.org/842246
    See: c0a82c42c13340743296461c0b594c5ad2f8a116
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/sparc/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-09-11 20:15:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=311dc338a9566052b660de5494e47ff9dd417173

commit 311dc338a9566052b660de5494e47ff9dd417173
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-11 20:15:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-11 20:15:24 +0000

    profiles/arch/sparc: add dev-lang/rust[system-bootstrap] to p.u.stable.force too
    
    Bug: https://bugs.gentoo.org/842246
    Closes: https://bugs.gentoo.org/869680
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/sparc/package.use.force        | 2 +-
 profiles/arch/sparc/package.use.stable.force | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-12 09:14:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=014c6629fcfb9011300931af6c460c910765e767

commit 014c6629fcfb9011300931af6c460c910765e767
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-12 09:14:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-12 09:14:29 +0000

    profiles/arch/sparc: un-stable-mask USE=system-bootstrap
    
    Thanks to Arfrever for noticing, doh.
    
    Bug: https://bugs.gentoo.org/842246
    Bug: https://bugs.gentoo.org/869680
    Fixes: 311dc338a9566052b660de5494e47ff9dd417173
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/sparc/package.use.stable.force | 8 --------
 profiles/arch/sparc/package.use.stable.mask  | 6 ++++++
 2 files changed, 6 insertions(+), 8 deletions(-)