Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84100 - net-p2p/mldonkey-2.5.30 (version bump)
Summary: net-p2p/mldonkey-2.5.30 (version bump)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
: 85962 92811 94889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-04 08:19 UTC by Ben
Modified: 2005-08-22 02:47 UTC (History)
16 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for newest mldonkey (mldonkey-2.5.30.ebuild,2.63 KB, text/plain)
2005-03-04 08:20 UTC, Ben
Details
Wrong ebuild upload. Fixed this now (mldonkey-2.5.30.ebuild,2.63 KB, text/plain)
2005-03-04 08:25 UTC, Ben
Details
Diff file between mldonkey-2.5.28-r4 and mldonkey-2.5.30 (mldonkey.diff,983 bytes, text/plain)
2005-03-04 08:55 UTC, Ben
Details
mldonkey-2.5.30.diff (mldoney-2.5.30.diff,937 bytes, patch)
2005-03-19 18:28 UTC, Tomislav Filipcic
Details | Diff
ebuild for mldonkey-2.5.30-1 (coming after 30c) (mldonkey-2.5.30-r1.ebuild,2.69 KB, text/plain)
2005-03-21 16:04 UTC, Michael
Details
MLDonkey version bump to 2.5.30-4 (mldonkey-2.5.30-r2.ebuild,2.68 KB, text/plain)
2005-04-08 01:12 UTC, Ben
Details
mldonkey-2.5.30.14.ebuild (mldonkey-2.5.30.14.ebuild,2.88 KB, text/plain)
2005-04-30 04:24 UTC, Laurento Frittella (mrfree)
Details
mldonkey-2.5.30.14.ebuild (mldonkey-2.5.30.14.ebuild,2.88 KB, text/plain)
2005-05-07 01:20 UTC, Michael Frister
Details
The ebuild for mldonkey-2.6.0 (mldonkey-2.6.0.ebuild,3.22 KB, text/plain)
2005-07-19 19:51 UTC, Sam Walliser
Details
mldonkey-2.6.0-r1 (mldonkey-2.6.0-r1.ebuild,3.57 KB, text/plain)
2005-07-21 02:52 UTC, Sam Walliser
Details
updated mldonkey-2.6.0 with gtk2 support (mldonkey-2.6.0.ebuild,3.84 KB, text/plain)
2005-07-21 03:07 UTC, Sam Walliser
Details
net-p2p/mldonkey-2.6.0.ebuild (ONLY CVS, read comment) (mldonkey-2.6.0.ebuild,4.20 KB, text/plain)
2005-07-22 05:00 UTC, Laurento Frittella (mrfree)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2005-03-04 08:19:38 UTC
Just another version bump to 2.5.30. 2.5.29 had a serious file corruption bug that was fixed in 2.5.30. A lot of fixes and improvements.

Reproducible: Always
Steps to Reproduce:
Comment 1 Ben 2005-03-04 08:20:14 UTC
Created attachment 52660 [details]
Ebuild for newest mldonkey
Comment 2 Ben 2005-03-04 08:25:53 UTC
Created attachment 52661 [details]
Wrong ebuild upload. Fixed this now
Comment 3 Stefan Schweizer (RETIRED) gentoo-dev 2005-03-04 08:42:06 UTC
Please attach an unified diff(diff -u old.ebuild new.ebuild) when you make changes to an ebuild.
Comment 4 Ben 2005-03-04 08:55:38 UTC
Created attachment 52664 [details]
Diff file between mldonkey-2.5.28-r4 and mldonkey-2.5.30
Comment 5 nobody 2005-03-12 16:11:54 UTC
I think it is best to keep the old version of the ebuild as the patch "Patchpack30a" has just been released.

Builds fine here when I use the USE flags "gtk gtk2".

When I use "-gtk -gtk2" to build mldonkey 2.5.30a I get an error message that the 2.5.30-config.patch couldn't be applied. I think this patch doesn't apply anymore to version 2.5.30.


Here is the diff I used:

--- mldonkey-2.5.28-r4.ebuild   2005-03-13 01:00:44.398872136 +0100
+++ mldonkey-2.5.30.ebuild      2005-03-12 21:49:29.836270800 +0100
@@ -6,7 +6,7 @@

 IUSE="gtk gtk2"

-PATCHPACK="patch_pack28h.gz"
+PATCHPACK="patch_pack30a.gz"

 DESCRIPTION="mldonkey is a new client to access the eDonkey network. It is written in Objective-Caml, and comes with its own GTK GUI, an HTTP interface and a telnet interface."
 HOMEPAGE="http://www.nongnu.org/mldonkey/"
Comment 6 Tomislav Filipcic 2005-03-19 18:28:07 UTC
Created attachment 53903 [details, diff]
mldonkey-2.5.30.diff

mldonkey-2.5.30 with patchpack 30c diff
Comment 7 Carsten Lohrke (RETIRED) gentoo-dev 2005-03-19 19:06:06 UTC
*** Bug 85962 has been marked as a duplicate of this bug. ***
Comment 8 Tomislav Filipcic 2005-03-20 04:39:02 UTC
Please note that this build depends on ocaml-3.08.2, so the dependencies in the ebuild should be changed.
Comment 9 Arudil 2005-03-20 07:27:21 UTC
Out of spiralvoice's info:

To build GTK1 newgui: ./configure 
To build GTK1 oldgui: ./configure --disable-newgui 
To build GTK2 GUI: ./configure --enable-gtk2 

Currently, the oldgui isn't supported by ebuild. Perhaps this could be changed.
Comment 10 Michael 2005-03-21 16:04:04 UTC
Created attachment 54117 [details]
ebuild for mldonkey-2.5.30-1 (coming after 30c)

This version now requieres dev-lang/ocaml-3.08.3 and the naming system is a
problem with portage and the ebuild thingy so i named the ebuild
mldonkey-2.5.30-r1 and modified the path for source and workdir. Wanted to make
it a new bugzilla bug because it is different to 2.5.30c but the branch was
killed ;)
The version should definitly stay hard masked!
Comment 11 Ben 2005-04-08 01:12:31 UTC
Created attachment 55638 [details]
MLDonkey version bump to 2.5.30-4

New version of mldonkey. Comes after 2.5.30-1 and fixes some minor bugs. Change
on gui protocol from version 30 to 31
Comment 12 spiralvoice 2005-04-16 12:50:10 UTC
2.5.30.6 was released today, numbering has changed to avoid problems with portage.
Comment 13 spiralvoice 2005-04-23 06:26:12 UTC
2.5.30.8 was released, grab tarball from here:
http://savannah.nongnu.org/download/mldonkey/mldonkey-2.5.30.8.tar.bz2
Comment 14 spiralvoice 2005-04-24 09:51:49 UTC
2.5.30.10 is out:
http://savannah.nongnu.org/download/mldonkey/mldonkey-2.5.30.10.tar.bz2
Comment 15 spiralvoice 2005-04-29 11:21:16 UTC
2.5.30.14 is out: http://savannah.nongnu.org/download/mldonkey/mldonkey-2.5.30.14.tar.bz2

You can verify the archive integrity with my public PGP key which
can be found here: http://savannah.nongnu.org/users/spiralvoice
Comment 16 Laurento Frittella (mrfree) 2005-04-30 04:23:04 UTC
I've added an ebuild for mldonkey-2.5.30.14 when I've added the "gd" use-flag because the new mlnet version can produce some bandwidth graph (in the statistic section of web-based interface) using gd library.

The gd useflag imply dependency on media-libs/gd and media-libs/freetype packages
Comment 17 Laurento Frittella (mrfree) 2005-04-30 04:24:09 UTC
Created attachment 57668 [details]
mldonkey-2.5.30.14.ebuild
Comment 18 Michael Frister 2005-05-07 01:20:51 UTC
Created attachment 58260 [details]
mldonkey-2.5.30.14.ebuild

fixed ocaml-3.08.3 dependency
Comment 19 spiralvoice 2005-05-07 04:43:51 UTC
2.5.30.15 was released...
Comment 20 spiralvoice 2005-05-07 04:47:23 UTC
I don
Comment 21 spiralvoice 2005-05-07 04:47:23 UTC
I don´t know if this is the right place for discussing this, if not please tell
me where a better place would be.

I wrote a patch enabling MLDonkey daemon to create a pid file:
http://savannah.nongnu.org/patch/?func=detailitem&item_id=3985

However in the patch there is a discussion about the naming of the pid file,
it would be nice if package admins would comment on that.
Comment 22 Jakub Moc (RETIRED) gentoo-dev 2005-05-26 01:51:16 UTC
*** Bug 92811 has been marked as a duplicate of this bug. ***
Comment 23 Jakub Moc (RETIRED) gentoo-dev 2005-06-03 05:11:00 UTC
*** Bug 94889 has been marked as a duplicate of this bug. ***
Comment 24 spiralvoice 2005-06-09 15:28:46 UTC
2.5.30.16 has been released.
http://bugs.gentoo.org/show_bug.cgi?id=89220 carries a new ebuild which
respects the GTK2 build flag.
Comment 25 Alex Efros 2005-06-12 08:45:39 UTC
Current stable version in portage is 2.5.16-r9. 
It's 1 year and 3 months old... and current version is 2.5.30.16.
I've found comment in package.mask:
# <squinky86@gentoo.org> (17 Aug 2004)
# Masked by request of upstream developers.
>=net-p2p/mldonkey-2.5.17

I'm new for mldonkey and just wondering: what's the best version now to install 
and try mldonkey for the first time? If it still 2.5.16, then is there any need 
to fetch newer .ini-files from somethere?
Comment 26 spiralvoice 2005-06-16 08:16:53 UTC
There is no need to refrain from 2.5.30.16 nowadays, especially if you want to
use BT.
Comment 27 Xake 2005-06-26 03:46:55 UTC
When will a new version be placed in portage?
Comment 28 spiralvoice 2005-07-05 09:01:38 UTC
2.5.30.17 was released today
Comment 29 Sam Walliser 2005-07-06 08:52:08 UTC
I made a bunch of GTK-disabled ebuilds for putting in
/usr/local/portage/net-p2p/mldonkey/

its still masked by ~* and package.mask, though.

You can find them at 
http://dabserver.dyndns.org/dabljuh/mldonkey/
Comment 30 Christian Schlotter 2005-07-19 15:45:52 UTC
2.6.0 was just released with really important changes (overnet/kad memleak solved)

see
http://savannah.nongnu.org/cgi-bin/viewcvs/mldonkey/mldonkey/distrib/ChangeLog?rev=release-2-6-0&content-type=text/vnd.viewcvs-markup
Comment 31 Sam Walliser 2005-07-19 19:51:51 UTC
Created attachment 63842 [details]
The ebuild for mldonkey-2.6.0

I just finished testing this new mldonkey-2.6.0 ebuild. It contains some fun
new use flags for your pleasure. Read the ebuild for more info.

Also, with 2.6.0 being a stable release, I recommend it to be put into the
regular portage tree soon, as well as removing the package.mask lines that keep
mldonkey at the soon ancient level of 2.5.16
Comment 32 Christian Schlotter 2005-07-19 23:26:26 UTC
Hi!

(In reply to comment #30)
> Also, with 2.6.0 being a stable release, I recommend it to be put into the
> regular portage tree soon, as well as removing the package.mask lines that keep
> mldonkey at the soon ancient level of 2.5.16

I don't agree: All the ebuilds for versions *between* 2.5.16 and 2.5.30 should
be removed from portage tree because they're not developed anymore and are buggy
as hell. 2.5.16 is still developed and will be soon be released unser the name
"mulus" and it's ebuild shall remain in portage until a mulus ebuild is marked
stable.

Until then, my ebuild for 2.5.16-w1 from bug #93894 should be added to portage
because it fixes important bugs which harmed the network and the other 2.5.16
versions should be removed.

Best regards
Christian
Comment 33 Sam Walliser 2005-07-20 00:10:29 UTC
Or that.

Anyway, the current situation of mldonkey in portage is quite desolate as no
ebuild ever seems to be moved into the rsync tree.
Comment 34 Sam Walliser 2005-07-21 02:52:13 UTC
Created attachment 63957 [details]
mldonkey-2.6.0-r1

Alright. This is the new and improved ebuild, it features
- Much improved USE flags.
- More & better dependencies
- Disabled gtk2 support because I couldn't get that to compile anywhere,
despite trying for 3 hours together with spiralvoice (it works no problem with
his self-compiled libraries)

And: Who the smeg do you need to shag here to get some attention from
net-p2p@gentoo?
Comment 35 Sam Walliser 2005-07-21 03:07:22 UTC
Created attachment 63958 [details]
updated mldonkey-2.6.0 with gtk2 support

Alright, if anyone wants to test the gtk2 support in the same context, try this
updated ebuild. It is identical to the -r1 except for allowing you to use gtk2
support. Please give it a shot (USE="X gtk2" and report back)
Comment 36 Laurento Frittella (mrfree) 2005-07-22 05:00:44 UTC
Created attachment 64049 [details]
net-p2p/mldonkey-2.6.0.ebuild (ONLY CVS, read comment)

WARNING: this ebuild works well only with new CVS version of mldonkey!!!

* I think ocaml isn't enough intuitive I've changed in batch (it can be
probably use with lablgtk too)
* New use flag:
-- guionly (http://bugs.gentoo.org/show_bug.cgi?id=89220), it builds only the
GUI
-- doc
* added gtk2, gtk, oldgtk mutual exclusion
* changed gui configure option (mldonkey patch #4195) -- committed by
spiralvoice on 2005/07/21
* respecting official mldonkey docs, ebuild only install mlnet and mlgui bins
Comment 37 Giacomo Graziosi 2005-07-23 10:46:28 UTC
mldonkey-2.6.0-r1 does not install /etc/conf.d/mldonkey and /etc/init.d/mldonkey.
Comment 38 Karol Wojtaszek (RETIRED) gentoo-dev 2005-07-23 13:10:57 UTC
Added mldonkey-2.6.0 to portage, thanks for help.
Comment 39 Mehmet Giritli 2005-07-27 03:51:16 UTC
shouldn't the pid file be under /var/run/ ?
Comment 40 spiralvoice 2005-08-15 14:00:49 UTC
(In reply to comment #38)
> shouldn't the pid file be under /var/run/ ?

Normally yes, but MLDonkey is used in different environments, like Windows,
chroot and so on and it is not guaranteed that /var/run exists everywhere
or is writable for the MLDonkey core. So I hardcoded the file position to the
working directory.

The only thing I can think of is an environment variable like MLDONKEY_PIDDIR,
what do you think about it?
Comment 41 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-08-15 14:12:17 UTC
(In reply to comment #39)
> The only thing I can think of is an environment variable like MLDONKEY_PIDDIR,
> what do you think about it?

How about option for starting mldonkey... s/t like
mldonkey --with-piddir=/path/to/dir

this would be even simplier to use with different environments?

only my 2 cents :)

Regards,
Przemek
Comment 42 Mehmet Giritli 2005-08-22 02:47:10 UTC
It is quite common to take the approach proposed in comment 40. Thats how many
other daemons handle it, i.e. take it from the command line.

I also noticed that when mldonkey fails to startup, the rc-status is still
'started' whereas it should be `off'. However this shall go as a seperate bug
report I think....