Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839180 - sys-auth/pam_ssh: automated shellcheck found errors
Summary: sys-auth/pam_ssh: automated shellcheck found errors
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2024-04-17 17:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:01 UTC
Shellckeck found errors in one or more shellscripts provided by sys-auth/pam_ssh.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-auth/pam_ssh/pam_ssh-2.3.ebuild:64

	for i in "${REPLACING_VERSIONS}"; do
                 ^^^^^^^^^^^^^^^^^^^^^^^
error: Since you double quoted this, it will not word split, and the loop will only run once. (https://github.com/koalaman/shellcheck/wiki/SC2066)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Zentoo 2024-04-17 17:42:01 UTC
The pkg_preinst function can be replaced by this more simple code:

pkg_preinst() {
    if [[ "$REPLACED_BY_VERSION" == 1.* ]]; then
        ewarn "Upstream pam_ssh has changed where ssh keys live. Only keys in your"
        ewarn "~/.ssh/login-keys.d/ will be accepted for authentication."
    fi
}