Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836076 - media-sound/flake: uses variables banned in scope (VariableScope)
Summary: media-sound/flake: uses variables banned in scope (VariableScope)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: forbidden-variable-use
  Show dependency tree
 
Reported: 2022-03-26 03:39 UTC by Sam James
Modified: 2025-01-09 09:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-26 03:39:52 UTC
This package uses variables banned in some scopes. This may stop working in future versions of Portage.

$ pkgcheck scan -k VariableScope media-sound/flake
media-sound/flake
  VariableScope: version 0.11: variable 'ED' used in 'src_configure', line 22
Comment 1 Larry the Git Cow gentoo-dev 2025-01-09 09:53:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=87d9e0b69de11e844087a7f74727a40261fa7bd5

commit 87d9e0b69de11e844087a7f74727a40261fa7bd5
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-01-09 08:10:33 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2025-01-09 09:50:33 +0000

    media-sound/flake: update EAPI 7 -> 8, fix build instability
    
    Fixed wrong variable usage in ebuild
    Two main problems in makefile - lack of dependency of the program
    to library, so it fails if program is build before library.
    And false dependency for flake with weird renaming going on, so
    depgraph gets confused and make builds flake using default rules,
    not including library, or second compilation unit.
    One is fixed by rules addition, another is fixed by rule removal
    
    Closes: https://bugs.gentoo.org/880819
    Closes: https://bugs.gentoo.org/912148
    Closes: https://bugs.gentoo.org/917760
    Closes: https://bugs.gentoo.org/836076
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40064
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../flake/files/flake-0.11-make-instability.patch  | 33 ++++++++++++++++++++++
 media-sound/flake/flake-0.11.ebuild                | 14 ++++-----
 2 files changed, 39 insertions(+), 8 deletions(-)