Hello everyone, I just discovered a bug. If "ocaml" is compiled with the flag "-fno-semantic-interposition", it will compile most programs just fine, but it will error out when compiling "dev-ml/findlib". When compiling findlib, after a certain point ld will start spitting out errors saying "undefined reference to xxxxx.o", and will fail to compile findlib. I think the best option is to filter out "-fno-semantic-interposition" from CFLAGS in ocaml's ebuild (via flag-o-matic?) Greetings, Matteo
It'd be most helpful to see an example, but that doesn't sound crazy.
It appears "-fno-semantic-interposition" is not a problem -- LTO seems to be the problem here. ("-flto")
(In reply to Matteo Salonia from comment #2) > It appears "-fno-semantic-interposition" is not a problem -- LTO seems to be > the problem here. ("-flto") That's why the full logs are useful :) Please attach some showing failure, and include emerge --info. I thought we'd already handled this before and that 4.13.x should be unaffected (fixed already upstream): bug 818445.
Created attachment 767073 [details] findlib build log (ocaml built with "-flto") Added findlib build log
emerge --info: Portage 3.0.30 (python 3.9.10-final-0, default/linux/amd64/17.1/desktop, gcc-11.2.1, glibc-2.34-r9, 5.16.0-pf4 x86_64) ================================================================= System uname: Linux-5.16.0-pf4-x86_64-Intel-R-_Core-TM-_i7-4700MQ_CPU_@_2.40GHz-with-glibc2.34 KiB Mem: 8028448 total, 2825916 free KiB Swap: 24894780 total, 24343100 free Timestamp of repository gentoo: Sun, 13 Mar 2022 09:45:01 +0000 Head commit of repository gentoo: b94e51fbcf381f2ff91059d04429023cf7473e26 Timestamp of repository mv: Sat, 12 Mar 2022 19:49:37 +0000 Head commit of repository mv: 7dcac07cce31aceaf566d3ff2f8dd71edbac9f5e sh bash 5.1_p16 ld GNU ld (Gentoo 2.37_p1 p2) 2.37 distcc 3.4 x86_64-pc-linux-gnu [disabled] ccache version 4.5.1 [enabled] app-misc/pax-utils: 1.3.3::gentoo app-shells/bash: 5.1_p16::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.0-r8::gentoo dev-lang/python: 3.9.10_p1::gentoo, 3.10.2_p1::gentoo, 3.11.0_alpha5_p1::gentoo dev-lang/rust-bin: 1.59.0::gentoo dev-util/ccache: 4.5.1::gentoo dev-util/cmake: 3.22.2::gentoo dev-util/meson: 0.61.1::gentoo sys-apps/baselayout: 2.8::gentoo sys-apps/openrc: 0.44.10::gentoo sys-apps/sandbox: 2.29::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.37_p1-r2::gentoo sys-devel/binutils-config: 5.4.1::gentoo sys-devel/clang: 13.0.0::gentoo sys-devel/gcc: 11.2.1_p20220115::gentoo sys-devel/gcc-config: 2.5-r1::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/llvm: 13.0.0::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.16::gentoo (virtual/os-headers) sys-libs/glibc: 2.34-r9::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync8.de.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 sync-rsync-verify-jobs: 1 sync-rsync-extra-opts: [...] ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@GPL-COMPATIBLE @FREE" CBUILD="x86_64-pc-linux-gnu" CC="gcc" CFLAGS="-O3 -pipe -march=haswell -mtune=haswell -fno-plt -falign-functions=32 -flto=4 -fgraphite-identity -floop-nest-optimize -fipa-pta -fno-semantic-interposition -fno-common -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fno-math-errno -ffinite-math-only -fno-rounding-math -fno-signaling-nans -fcx-limited-range -fexcess-precision=fast -fdevirtualize-at-ltrans -fno-plt" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O3 -pipe -march=haswell -mtune=haswell -fno-plt -falign-functions=32" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg buildpkg-live ccache cgroup collision-protect config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--fuse-ld=ld.gold" MAKEOPTS="-j4 -l4" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="X aac aalib acpi alsa amd64 bash-completion bindist bzip2 cairo cdda cdr cli crypt dbus dri dts dvd dvdr elogind emoji encode flac gdbm gif git gpm graphite gtk gui harfbuzz hwloc iconv icu initramfs jit jpeg lcms libglvnd libnotify libtirpc logrotate lto lz4 lzma mad man mp3 mp4 mpeg mtp multilib ncurses nptl ogg opengl openmp pam pango pcre pdf persist pgo png ppds readline sdl seccomp sna spell split-usr ssl startup-notification svg tiff tools truetype tui udisks unicode upower usb uxa v4l vaapi vorbis webp wifi wxwidgets x264 xattr xcb xft xinerama xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Note: I have special overrides for ocaml: /etc/portage/env/perf-no-lto.conf COMMON_FLAGS="-Ofast -pipe -march=haswell -mtune=haswell -fno-plt -falign-functions=32 -floop-nest-optimize -fipa-pta -fno-semantic-interposition -fno-common -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fno-math-errno -ffinite-math-only -fno-rounding-math -fno-signaling-nans -fcx-limited-range -fexcess-precision=fast -fdevirtualize-at-ltrans" CFLAGS="${COMMON_FLAGS}" CXXFLAGS="${COMMON_FLAGS}" /etc/portage/package.env/dev-lang dev-lang/ocaml perf-no-lto.conf
(In reply to Matteo Salonia from comment #6) > Note: I have special overrides for ocaml: > > /etc/portage/env/perf-no-lto.conf > COMMON_FLAGS="-Ofast -pipe -march=haswell -mtune=haswell -fno-plt > -falign-functions=32 -floop-nest-optimize -fipa-pta > -fno-semantic-interposition -fno-common -fno-signed-zeros -fno-trapping-math > -fassociative-math -freciprocal-math -fno-math-errno -ffinite-math-only > -fno-rounding-math -fno-signaling-nans -fcx-limited-range > -fexcess-precision=fast -fdevirtualize-at-ltrans" > CFLAGS="${COMMON_FLAGS}" > CXXFLAGS="${COMMON_FLAGS}" > > /etc/portage/package.env/dev-lang > dev-lang/ocaml perf-no-lto.conf I'm confused then. Is it broken with these options or something else? I thought it was LTO? Also, is this definitely with OCaml 4.13.1?
> I'm confused then. Is it broken with these options or something else? I > thought it was LTO? No, it works with these options, it's broken if you add "-flto". > Also, is this definitely with OCaml 4.13.1? Yes.
(In reply to Matteo Salonia from comment #8) > > I'm confused then. Is it broken with these options or something else? I > > thought it was LTO? > > No, it works with these options, it's broken if you add "-flto". > > > Also, is this definitely with OCaml 4.13.1? > > Yes. Does it fail with just -O2 -flto? You need to narrow down which flags and report it upstream so it can be fixed properly. Otherwise, all we can do for now is filter LTO again. It's a shame that the fix in https://github.com/ocaml/ocaml/issues/9825 was insufficient.
Yes, it does fail with just "-O2 -flto". Removing "-flto" seems to fix all issues for me.
(In reply to Matteo Salonia from comment #10) > Yes, it does fail with just "-O2 -flto". Removing "-flto" seems to fix all > issues for me. What a shame, thanks for all the info! OK, we'll filter -flto then, but can you report this upstream please?
(In reply to Sam James from comment #11) > Can you report this upstream please? Sure, I will report this tomorrow when I have the time.
Issue reported upstream. URL: https://github.com/ocaml/ocaml/issues/11119
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4c0389745bf470502ddefc8065d50e6a9033260 commit f4c0389745bf470502ddefc8065d50e6a9033260 Author: Alfredo Tupone <tupone@gentoo.org> AuthorDate: 2022-09-29 07:00:02 +0000 Commit: Alfredo Tupone <tupone@gentoo.org> CommitDate: 2022-09-29 07:00:02 +0000 dev-lang/ocaml: filtering lto Closes: https://bugs.gentoo.org/872995 Closes: https://bugs.gentoo.org/870349 Closes: https://bugs.gentoo.org/835157 Closes: https://bugs.gentoo.org/858446 Signed-off-by: Alfredo Tupone <tupone@gentoo.org> dev-lang/ocaml/{ocaml-4.14.0.ebuild => ocaml-4.14.0-r1.ebuild} | 1 + 1 file changed, 1 insertion(+)
