Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834135 - dev-util/pkgcheck: contains bundled dev-libs/tree-sitter-bash
Summary: dev-util/pkgcheck: contains bundled dev-libs/tree-sitter-bash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: bundled-libs
  Show dependency tree
 
Reported: 2022-02-27 01:17 UTC by Sam James
Modified: 2022-05-03 10:20 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-27 01:17:44 UTC
We didn't have it packaged for a while but we do now.

See https://github.com/pkgcore/pkgcheck/tree/master/tree-sitter-bash and:
```
creating /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash
creating /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash/src
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -ggdb3 -fPIC -std=c99 -Itree-sitter-bash/src -c tree-sitter-bash/src/parser.c -o /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash/src/parser.o
x86_64-pc-linux-gnu-g++ -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -ggdb3 -fPIC -Itree-sitter-bash/src -c tree-sitter-bash/src/scanner.cc -o /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash/src/scanner.o
creating /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/work/pkgcheck-0.10.9-python3_9/build/temp.linux-x86_64-3.9
creating /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/work/pkgcheck-0.10.9-python3_9/build/temp.linux-x86_64-3.9/pkgcheck
creating /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/work/pkgcheck-0.10.9-python3_9/build/temp.linux-x86_64-3.9/pkgcheck/bash
x86_64-pc-linux-gnu-g++ -shared -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -ggdb3 /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash/src/parser.o /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/temp/tmp1k8xohbetree_sitter_language/tree-sitter-bash/src/scanner.o -o /var/tmp/portage/dev-util/pkgcheck-0.10.9-r1/work/pkgcheck-0.10.9-python3_9/build/temp.linux-x86_64-3.9/pkgcheck/bash/lang.so
```

I think it's the same thing, anyway? Could be wrong.

(I've CC'd dev-libs/tree-sitter-bash's maintainers in case they can offer input.)
Comment 1 Thomas Bracht Laumann Jespersen 2022-04-25 12:31:22 UTC
Here's a first step in unvendoring it: https://github.com/pkgcore/pkgcheck/pull/367

If merged, dev-util/pkgcheck could add an RDEPEND on dev-libs/tree-sitter-bash and that should resolve this.
Comment 2 Thomas Bracht Laumann Jespersen 2022-04-25 12:31:34 UTC
> unvendoring

unbundle?
Comment 3 Larry the Git Cow gentoo-dev 2022-05-03 10:20:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=72c3ca1f0bf4aff0f9b4186e4e5f730ca86d1783

commit 72c3ca1f0bf4aff0f9b4186e4e5f730ca86d1783
Author:     Thomas Bracht Laumann Jespersen <t@laumann.xyz>
AuthorDate: 2022-05-02 19:57:00 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-05-03 10:19:59 +0000

    dev-util/pkgcheck: add dep on tree-sitter-bash
    
    Current pkgcheck now supports disabling the bundled tree-sitter-bash, so
    we can make the live ebuild depend on dev-libs/tree-sitter-bash now.
    
    Closes: https://bugs.gentoo.org/834135
    Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
    Closes: https://github.com/gentoo/gentoo/pull/25298
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-util/pkgcheck/pkgcheck-9999.ebuild | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)