Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830777 - x11-misc/xscreensaver-6.02: use '-xft' broken
Summary: x11-misc/xscreensaver-6.02: use '-xft' broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-01-08 12:46 UTC by Joonas Niilola
Modified: 2022-10-30 09:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (xscreensaver-6.02:20220108-123708.log,543.79 KB, text/plain)
2022-01-08 12:46 UTC, Joonas Niilola
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2022-01-08 12:46:00 UTC
Created attachment 761609 [details]
build.log

dialog.c: In function 'choose_asterisk':
dialog.c:695:11: warning: implicit declaration of function 'XftCharExists' [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]
  695 |       if (XftCharExists (ws->dpy, ws->label_font, (FcChar32) *uc))
      |           ^~~~~~~~~~~~~
dialog.c:695:11: warning: nested extern declaration of 'XftCharExists' [-Wnested-externs[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wnested-externs]]
dialog.c:695:52: error: 'FcChar32' undeclared (first use in this function); did you mean 'FcChar8'?
  695 |       if (XftCharExists (ws->dpy, ws->label_font, (FcChar32) *uc))
      |                                                    ^~~~~~~~
      |                                                    FcChar8
dialog.c:695:52: note: each undeclared identifier is reported only once for each function it appears in
x86_64-pc-linux-gnu-gcc -std=gnu89 -pedantic -Wall -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wdeclaration-after-statement -Wno-overlength-strings -Wno-variadic-macros -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -L/usr/lib64 -o xscreensaver-command remote.o xscreensaver-command.o blurb.o atoms.o clientmsg.o  -L/usr/lib64 -R/usr/lib64 -lSM -lICE -lXi -lX11 -lXext
make[1]: *** [Makefile:842: dialog.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37,
                 from /usr/include/gtk-2.0/gtk/gtkwidget.h:36,
                 from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkbin.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkwindow.h:36,
                 from /usr/include/gtk-2.0/gtk/gtkdialog.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:33,
                 from demo-Gtk-conf.c:71:
/usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: warning: 'GTypeDebugFlags' is deprecated [-Wdeprecated-declarations[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations]]
  236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
      | ^~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from demo-Gtk-conf.c:71:
/usr/include/glib-2.0/gobject/gtype.h:698:1: note: declared here
  698 | {
      | ^
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
                 from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:126,
                 from demo-Gtk-conf.c:71:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: warning: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations]]
   73 |   GTimeVal last_popdown;
      |   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from demo-Gtk-conf.c:71:
/usr/include/glib-2.0/glib/gtypes.h:547:8: note: declared here
  547 | struct _GTimeVal
      |        ^~~~~~~~~
In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37,
                 from /usr/include/gtk-2.0/gtk/gtkwidget.h:36,
                 from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkbin.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkwindow.h:36,
                 from /usr/include/gtk-2.0/gtk/gtkdialog.h:35,
                 from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:33,
                 from demo-Gtk.c:81:
/usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: warning: 'GTypeDebugFlags' is deprecated [-Wdeprecated-declarations[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations]]
  236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
      | ^~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from demo-Gtk.c:81:
/usr/include/glib-2.0/gobject/gtype.h:698:1: note: declared here
  698 | {
      | ^
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
                 from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:126,
                 from demo-Gtk.c:81:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: warning: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdeprecated-declarations]]
   73 |   GTimeVal last_popdown;
      |   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from demo-Gtk.c:81:
/usr/include/glib-2.0/glib/gtypes.h:547:8: note: declared here
  547 | struct _GTimeVal
      |        ^~~~~~~~~
make[1]: Leaving directory '/var/tmp/portage/x11-misc/xscreensaver-6.02/work/xscreensaver-6.02/driver'
make: *** [Makefile:32: all] Error 5
 * ERROR: x11-misc/xscreensaver-6.02::gentoo failed (compile phase):
 *   emake failed
Comment 1 Larry the Git Cow gentoo-dev 2022-01-08 12:49:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57b3b5779aa0469b3fdf5c58ad1119e5ab43f3d5

commit 57b3b5779aa0469b3fdf5c58ad1119e5ab43f3d5
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-01-08 12:47:38 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-01-08 12:49:07 +0000

    profiles/base: package.use.force xscreensaver xft
    
     - -xft is broken.
    
    Bug: https://bugs.gentoo.org/830777
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/base/package.use.force | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 2 Larry the Git Cow gentoo-dev 2022-10-30 09:40:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79d3bbef1b508c36bf1f88481a9d791098b438cd

commit 79d3bbef1b508c36bf1f88481a9d791098b438cd
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-10-16 17:14:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-30 09:37:56 +0000

    x11-misc/xscreensaver: version bump to 6.05
    
    * New patch for handsys manners
    * Building with USE="-opengl" is not supported anymore
    * Also added a patch for -gtk builds, set GTK_SHAREDIR because when build
      with USE="-gtk" it is not set and then installs .service file into /
    * Building with USE="-xft" is not supported anymore
    * Delete .service file when USE="-systemd"
    
    Closes: https://bugs.gentoo.org/869218
    Closes: https://bugs.gentoo.org/851057
    Closes: https://bugs.gentoo.org/834593
    Closes: https://bugs.gentoo.org/851834
    Closes: https://bugs.gentoo.org/830777
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-misc/xscreensaver/Manifest                     |   1 +
 .../xscreensaver-6.05-configure-exit-codes.patch   |  29 +++
 ...screensaver-6.05-remove-update-icon-cache.patch |  13 ++
 ...creensaver-6.05-teach-handsy-some-manners.patch |  42 ++++
 x11-misc/xscreensaver/metadata.xml                 |   9 +-
 x11-misc/xscreensaver/xscreensaver-6.05.ebuild     | 243 +++++++++++++++++++++
 6 files changed, 336 insertions(+), 1 deletion(-)