Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829001 - sys-apps/lshw[gtk] does not respect LDFLAGS (PATCH)
Summary: sys-apps/lshw[gtk] does not respect LDFLAGS (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2021-12-12 15:03 UTC by Jannik Glückert
Modified: 2021-12-13 15:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to fix ldflags overriding (ldflags.patch,815 bytes, patch)
2021-12-12 15:03 UTC, Jannik Glückert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jannik Glückert 2021-12-12 15:03:49 UTC 
Created attachment 758703 [details, diff]
patch to fix ldflags overriding

lshw has some *interesting* handwritten Makefiles - src/gui/Makefile:21 resets LDFLAGS, because previously in src/Makefile:33 there's LDFLAGS+=-L./core/

The attached patch moves the -L into LIBS instead & fixes some related handling
Comment 1 Larry the Git Cow gentoo-dev 2021-12-13 15:17:48 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21a5b70c1df92f2cee5a4d655e1cc01a3c128e97

commit 21a5b70c1df92f2cee5a4d655e1cc01a3c128e97
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2021-12-13 15:17:06 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2021-12-13 15:17:39 +0000

    sys-apps/lshw: respect LDFLAGS
    
    Closes: https://bugs.gentoo.org/829001
    Package-Manager: Portage-3.0.29, Repoman-3.0.3
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 .../lshw/files/lshw-02.19.2b-respect-LDFLAGS.patch | 33 +++++++++
 sys-apps/lshw/lshw-02.19.2b_p20210121-r2.ebuild    | 83 ++++++++++++++++++++++
 2 files changed, 116 insertions(+)