Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 827538 - dev-libs/gjs fails to build with meson 0.60.x (ERROR: "install_dir" must be specified when installing a target)
Summary: dev-libs/gjs fails to build with meson 0.60.x (ERROR: "install_dir" must be s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: meson-0.60.x
  Show dependency tree
 
Reported: 2021-11-26 18:15 UTC by Paul Mulders
Modified: 2021-11-29 00:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log + emerge --info.txt (build.log-emerge-info.txt,10.88 KB, text/plain)
2021-11-26 20:07 UTC, Ionen Wolkens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Mulders 2021-11-26 18:15:07 UTC
Apparently, there has been a problem with the meson build since it was first added to gjs source code. It never installed the GjsPrivate-1.0.gir file, since the meson.build contained an incorrect invocation of gnome.generate_gir. meson didn't start choking on the incorrect passing of a boolean as install_dir_gir until some internal changes in recent meson versions. I have made a pull request upstream, taking the patch from here https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/693 should fix the issue

Reproducible: Always

Steps to Reproduce:
1. update to latest meson (at time of writing 0.60.2-r1)
2. try to emerge gjs
Actual Results:  
fails with error 'meson.build:563:0: ERROR: "install_dir" must be specified when installing a target'

Expected Results:  
gjs builds properly

https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/693
Comment 1 Ionen Wolkens gentoo-dev 2021-11-26 20:07:41 UTC
Created attachment 756682 [details]
build.log + emerge --info.txt

Be good to give build.log even when it seems obvious, but I can reproduce so I'll just attach mine.
Comment 2 Paul Mulders 2021-11-26 20:28:14 UTC
for future reference, is there some kind of easy bug report cli tool that adds all the things the reporter here attached to his cjs bug report https://bugs.gentoo.org/827482 ?

I've only reinstalled gentoo recently after 10 years being away :)
Comment 3 Ionen Wolkens gentoo-dev 2021-11-26 21:09:36 UTC
(In reply to Paul Mulders from comment #2)
> for future reference, is there some kind of easy bug report cli tool that
> adds all the things the reporter here attached to his cjs bug report
> https://bugs.gentoo.org/827482 ?
Unfortunately not that I know of, that other bug is from tinderbox semi-automated testing/reports -- these scripts aren't intended for normal reports.

That aside, usually just the build.log and emerge --info is enough (preferably not in a tarball nor compressed so can be easily checked, but can compress if too large), or anything you feel is relevant to debug the particular issue (e.g. config.log with a ./configure error), but we'll ask if actually need something else.
Comment 4 Larry the Git Cow gentoo-dev 2021-11-29 00:56:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b707dc5311d1c6a1eefb9f6bf28cf4d217136192

commit b707dc5311d1c6a1eefb9f6bf28cf4d217136192
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-11-29 00:51:59 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-11-29 00:55:53 +0000

    dev-libs/gjs: backport fix for meson-0.60.2
    
    Closes: https://bugs.gentoo.org/827538
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 dev-libs/gjs/files/gjs-1.70.0-meson-0.60.2.patch | 76 ++++++++++++++++++++++++
 dev-libs/gjs/gjs-1.70.0.ebuild                   |  4 ++
 2 files changed, 80 insertions(+)