Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 825718 - sys-apps/busybox-1.34.1: fails in src_install if CONFIG_ENV is set to yes
Summary: sys-apps/busybox-1.34.1: fails in src_install if CONFIG_ENV is set to yes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-21 18:20 UTC by Philippe Valembois
Modified: 2023-06-01 18:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,483.20 KB, text/x-log)
2021-11-22 18:38 UTC, Philippe Valembois
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Valembois 2021-11-21 18:20:30 UTC
When building Busybox 1.34.1, src_install fails with the following error message:
 * Call stack:
 *     ebuild.sh, line 127:  Called src_install
 *   environment, line 1992:  Called die
 * The specific snippet of code:
 *       ln -s /bin/env _install/usr/bin/env || die;

This is because CONFIG_ENV=y in my busybox config file.

Previous ebuild didn't have the "|| die" part and it failed gracefully.
Removing this part makes the ebuild work as expected.

Reproducible: Always

Steps to Reproduce:
1. enable env applet in busybox config
2. build with this configuration
3. watch the fail
Actual Results:  
Failure to build

Expected Results:  
Should have been installed OK.
Comment 1 Jonas Stein gentoo-dev 2021-11-21 21:55:04 UTC
Thank you for the report. We need to have all information at hand before ticket assignment. Please provide
* the complete build.log as attachment and
* paste the emerge info 
as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket

Please reopen this ticket (Status:UNCONFIRMED) afterwards.
Comment 2 Philippe Valembois 2021-11-22 18:38:35 UTC
Created attachment 755226 [details]
build log
Comment 3 Philippe Valembois 2021-11-22 18:39:00 UTC
Portage 3.0.28 (python 3.9.8-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-11.2.0, glibc-2.33-r7, 5.15.2-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.15.2-gentoo-x86_64-AMD_Ryzen_7_5700G_with_Radeon_Graphics-with-glibc2.33
KiB Mem:    65284300 total,  58074796 free
KiB Swap:   67108860 total,  67108860 free
Timestamp of repository gentoo: Sun, 21 Nov 2021 17:21:35 +0000
Head commit of repository gentoo: e302e08b9d4aaa44fe72f9381226f7d93bd88fff

sh bash 5.1_p8
ld GNU ld (Gentoo 2.37_p1 p0) 2.37
app-shells/bash:          5.1_p8::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.34.0-r3::gentoo
dev-lang/python:          3.9.8::gentoo
dev-lang/rust:            1.56.1::gentoo
dev-util/cmake:           3.20.5::gentoo
sys-apps/baselayout:      2.7-r3::gentoo
sys-apps/openrc:          0.44.8::gentoo
sys-apps/sandbox:         2.25::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.4::gentoo
sys-devel/binutils:       2.37_p1::gentoo
sys-devel/gcc:            11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: git://anongit.gentoo.org/repo/sync/gentoo.git
    priority: -1000
    sync-git-verify-commit-signature: true

perso
    location: /var/db/repos/perso
    masters: gentoo

plex-overlay
    location: /var/lib/layman/plex-overlay
    sync-type: laymansync
    sync-uri: https://github.com/comio/plex-overlay.git
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/lib/layman/steam-overlay
    sync-type: laymansync
    sync-uri: https://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/portage/.distfiles"
EMERGE_DEFAULT_OPTS="--jobs=4 --quiet-build --load-average=6 --with-bdeps=y --keep-going --autounmask-keep-masks"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="ftp://ftp.free.fr/mirrors/ftp.gentoo.org/ http://gentoo.mirrors.ovh.net/gentoo-distfiles/"
LANG="fr_FR.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="fr en"
MAKEOPTS="-j17"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acoustid acpi activities alsa amd64 amr avif branding bzip2 cairo cdda cddb cdr chm cli crypt cups curl dbus declarative device-mapper djvu dri dts dv dvb dvd dvdr elogind emboss encode epub exif fbcon ffmpeg flac fontconfig fortran gdbm gegl gif gpm gstreamer gtk gui heif http2 iconv icu imlib iproute2 ipv6 jpeg jpeg2k kde kipi lcms libass libglvnd libnotify libtirpc lz4 lzma lzo mad mikmod mms mng mp3 mp4 mpeg mtp multilib musicbrainz ncurses nls nptl ogg opencl opengl openmp openssl opus osmesa pam pango pcre pdf plasma png policykit ppds pulseaudio qml qt5 rar raw readline realtime sdl seccomp speex spell split-usr ssl startup-notification svg taglib theora tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vim-syntax vnc vorbis vpx vulkan webp widgets wmf wxwidgets x264 x265 xattr xcb xinerama xml xv xvid zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2019" ALSA_CARDS="hda-intel virmidi usb-audio" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="fuji ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev libinput" KERNEL="linux" L10N="fr en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS

=================================================================
                        Package Settings
=================================================================

sys-apps/busybox-1.34.1::gentoo was built with the following:
USE="ipv6 savedconfig static -debug -livecd -make-symlinks -math -mdev -pam (-selinux) -sep-usr -syslog -systemd" ABI_X86="(64)"
CFLAGS="-march=native -O2 -pipe -fno-strict-aliasing"
CXXFLAGS="-march=native -O2 -pipe -fno-strict-aliasing"
Comment 4 Viorel Munteanu gentoo-dev 2022-04-17 07:49:49 UTC
I cannot reproduce this issue.  On my system busybox installs the links in /bin and /sbin, but on your system it installs many of them in /usr/bin and /usr/sbin (including /usr/bin/env).  I suppose it has something to do with the split-usr USE flag you have enabled.

I will add a fix for this in my upcoming PR.
Comment 5 Larry the Git Cow gentoo-dev 2022-06-30 21:41:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2009022df92957c33f4a81c28e0039cfb4118a1f

commit 2009022df92957c33f4a81c28e0039cfb4118a1f
Author:     Viorel Munteanu <ceamac.paragon@gmail.com>
AuthorDate: 2022-04-17 07:46:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-30 21:40:15 +0000

    sys-apps/busybox: Fix installation on split-usr systems
    
    Closes: https://bugs.gentoo.org/825718
    Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/busybox/busybox-1.34.1-r1.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 6 Philippe Valembois 2022-12-31 09:52:24 UTC
Sorry for not having come back earlier, the proposed fix just got stabilized.

The fix does not work because using [[ -e _install/usr/bin/env ]] always fails as -e tries to follow the symlink which points to _install/bin/busybox.
Problem: _install/bin/busybox just got removed 3 lines above and symlink is dangling.
So -e returns false.

Postponing the busybox binary removal just before calling tar makes it work.
Comment 7 Larry the Git Cow gentoo-dev 2023-05-24 15:35:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c67536d9c871db241aa82917528b127d4044b319

commit c67536d9c871db241aa82917528b127d4044b319
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2023-05-24 15:15:12 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-05-24 15:35:32 +0000

    sys-apps/busybox: add 1.36.1
    
    Update EAPI 7 -> 8.
    
    Bug: https://bugs.gentoo.org/825718
    Closes: https://bugs.gentoo.org/893418
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 sys-apps/busybox/Manifest              |   1 +
 sys-apps/busybox/busybox-1.36.1.ebuild | 361 +++++++++++++++++++++++++++++++++
 2 files changed, 362 insertions(+)
Comment 8 Viorel Munteanu gentoo-dev 2023-05-24 15:37:55 UTC
(In reply to Philippe Valembois from comment #6)
> 
> Postponing the busybox binary removal just before calling tar makes it work.

I implemented your suggestion, please let me know if it finally works (when 1.36.1 becomes stable).  Thanks!
Comment 9 Philippe Valembois 2023-06-01 18:59:54 UTC
I accepted the keyword.

Confirmed fixed.
Thanks!