Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 824838 - www-client/seamonkey requires media-libs/libpng[apng]
Summary: www-client/seamonkey requires media-libs/libpng[apng]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 824018
  Show dependency tree
 
Reported: 2021-11-19 12:15 UTC by Michał Górny
Modified: 2022-03-11 12:49 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-19 12:15:23 UTC
This package seems to depend on APNG-patched version of media-libs/libpng.  These patches have been rejected upstream and are known to break WebKit.  Please fix the package to work without custom patching.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-11-19 12:36:22 UTC
No soultion has been propsed and like I already said in bug #824018 I am against removal of the apng patch.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-19 12:38:57 UTC
Your refusal to acknowledge the problem doesn't make the bug disappear.  Plus, at least one option has been proposed on the bug, and I'm going to propose a few more in a minute.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-11-19 12:46:12 UTC
Indeed, I refuse to see a problem where no problem exists. The apng patch has been in Gentoo for over a decade now and only because of one single package _now_ having issues with it, is not really as much of a problem as you want to have it.

But sure, come with the almighty QA crowbar again. That seems to be the usual approach nowadays. Ignore maintainer decisions and just put on your qa hat with which you can do anything you want.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-19 12:48:45 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #3)
> Indeed, I refuse to see a problem where no problem exists. The apng patch
> has been in Gentoo for over a decade now and only because of one single
> package _now_ having issues with it, is not really as much of a problem as
> you want to have it.

Wrong.  WebKit is used by more than one package, and unlike the packages affected by lack of patch, they're not all from one vendor.

> But sure, come with the almighty QA crowbar again. That seems to be the
> usual approach nowadays. Ignore maintainer decisions and just put on your qa
> hat with which you can do anything you want.

I'm sorry but why do you assume that you're the sole maintainer of libpng?
Comment 5 Larry the Git Cow gentoo-dev 2021-12-13 01:03:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=211da92099ddcbc7dae4ed5ddf1df1a40107ad06

commit 211da92099ddcbc7dae4ed5ddf1df1a40107ad06
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-13 01:01:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-13 01:02:53 +0000

    www-client/seamonkey: Add USE=system-png
    
    Since Seamonkey requires patched version of media-libs/libpng
    and the patches are known to break WebKit, provide the ability to build
    against vendored libpng in order to make it possible for the users
    to return to vanilla libpng.
    
    See-also: https://gitweb.gentoo.org/sites/projects/council.git/tree/meeting-logs/20211212.txt#n98
    Bug: https://bugs.gentoo.org/824838
    Signed-off-by: Sam James <sam@gentoo.org>

 www-client/seamonkey/metadata.xml              | 1 +
 www-client/seamonkey/seamonkey-2.53.8.1.ebuild | 6 +++---
 www-client/seamonkey/seamonkey-2.53.9.1.ebuild | 6 +++---
 www-client/seamonkey/seamonkey-2.53.9.ebuild   | 6 +++---
 4 files changed, 10 insertions(+), 9 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2021-12-13 01:16:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c53cf94bed8928d02fe4d83a62a627fe2d037d87

commit c53cf94bed8928d02fe4d83a62a627fe2d037d87
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-13 01:13:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-13 01:13:51 +0000

    www-client/seamonkey: revbump to propagate libpng changes
    
    Needed for --changed-use users to pick up the change.
    
    See: 211da92099ddcbc7dae4ed5ddf1df1a40107ad06
    Bug: https://bugs.gentoo.org/824838
    Signed-off-by: Sam James <sam@gentoo.org>

 .../seamonkey/{seamonkey-2.53.8.1.ebuild => seamonkey-2.53.8.1-r1.ebuild} | 0
 .../seamonkey/{seamonkey-2.53.9.ebuild => seamonkey-2.53.9-r1.ebuild}     | 0
 .../seamonkey/{seamonkey-2.53.9.1.ebuild => seamonkey-2.53.9.1-r1.ebuild} | 0
 3 files changed, 0 insertions(+), 0 deletions(-)