Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 824834 - www-client/firefox requires media-libs/libpng[apng]
Summary: www-client/firefox requires media-libs/libpng[apng]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 824018
  Show dependency tree
 
Reported: 2021-11-19 12:15 UTC by Michał Górny
Modified: 2022-03-11 12:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-19 12:15:05 UTC
This package seems to depend on APNG-patched version of media-libs/libpng.  These patches have been rejected upstream and are known to break WebKit.  Please fix the package to work without custom patching.
Comment 1 Larry the Git Cow gentoo-dev 2021-12-12 21:31:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32be8e2a61734b15aee9abb1424c41dce5b511d7

commit 32be8e2a61734b15aee9abb1424c41dce5b511d7
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-11-19 13:54:15 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-12-12 21:31:38 +0000

    www-client/firefox: Add USE=system-png
    
    Since Firefox requires patched version of media-libs/libpng
    and the patches are known to break WebKit, provide the ability to build
    against vendored libpng in order to make it possible for the users
    to return to vanilla libpng.
    
    See-also: https://gitweb.gentoo.org/sites/projects/council.git/tree/meeting-logs/20211212.txt#n98
    Bug: https://bugs.gentoo.org/824834
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 www-client/firefox/firefox-78.15.0.ebuild   | 6 +++---
 www-client/firefox/firefox-91.3.0.ebuild    | 6 +++---
 www-client/firefox/firefox-93.0.ebuild      | 6 +++---
 www-client/firefox/firefox-94.0.1-r1.ebuild | 6 +++---
 www-client/firefox/firefox-94.0.2.ebuild    | 6 +++---
 www-client/firefox/firefox-95.0.ebuild      | 6 +++---
 www-client/firefox/metadata.xml             | 2 ++
 7 files changed, 20 insertions(+), 18 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2021-12-13 01:16:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=278a3add2c9d326670d19a96e1f456259075bfee

commit 278a3add2c9d326670d19a96e1f456259075bfee
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-13 01:12:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-13 01:13:44 +0000

    www-client/firefox: revbump to propagate libpng changes
    
    Needed for --changed-use users to pick up the change.
    
    Bug: https://bugs.gentoo.org/824834
    See: 32be8e2a61734b15aee9abb1424c41dce5b511d7
    Signed-off-by: Sam James <sam@gentoo.org>

 .../firefox/{firefox-78.15.0.ebuild => firefox-78.15.0-r1.ebuild}   | 0
 .../firefox/{firefox-91.3.0.ebuild => firefox-91.3.0-r1.ebuild}     | 0
 .../firefox/{firefox-91.4.0.ebuild => firefox-91.4.0-r1.ebuild}     | 6 +++---
 www-client/firefox/{firefox-93.0.ebuild => firefox-93.0-r1.ebuild}  | 0
 .../firefox/{firefox-94.0.1-r1.ebuild => firefox-94.0.1-r2.ebuild}  | 0
 .../firefox/{firefox-94.0.2.ebuild => firefox-94.0.2-r1.ebuild}     | 0
 www-client/firefox/{firefox-95.0.ebuild => firefox-95.0-r1.ebuild}  | 0
 7 files changed, 3 insertions(+), 3 deletions(-)