Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 822417 - dev-python/pymongo: update dependencies/add more USE-flags
Summary: dev-python/pymongo: update dependencies/add more USE-flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 822414
  Show dependency tree
 
Reported: 2021-11-08 11:10 UTC by pva
Modified: 2021-11-15 03:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pymongo-3.12.1.ebuild.patch (pymongo-3.12.1.ebuild.patch,708 bytes, patch)
2021-11-08 11:10 UTC, pva
Details | Diff
build.log (build.log.xz,26.93 KB, application/x-xz)
2021-11-08 11:12 UTC, pva
Details
emerge --info from the system (emerge--info.txt,14.66 KB, text/plain)
2021-11-08 11:13 UTC, pva
Details
pymongo-3.12.1.ebuild.patch (pymongo-3.12.1.ebuild.patch,708 bytes, patch)
2021-11-08 11:15 UTC, pva
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pva 2021-11-08 11:10:03 UTC
Created attachment 749505 [details, diff]
pymongo-3.12.1.ebuild.patch

dev-python/pymongo does not need dev-python/nose to run tests anymore. Also, I've taken the liberty to add more USE flags to enable optional features. This is a relevant part of setyp.py from the package:

extras_require = {
    'encryption': ['pymongocrypt>=1.1.0,<2.0.0'],
    'ocsp': pyopenssl_reqs,
    'snappy': ['python-snappy'],
    'zstd': ['zstandard'],
    'aws': ['pymongo-auth-aws<2.0.0'],
}
Comment 1 pva 2021-11-08 11:12:01 UTC
Created attachment 749508 [details]
build.log

I've removed dev-python/nose from the system and run tests. It more or less passed (at least everything is expected).
Comment 2 pva 2021-11-08 11:13:01 UTC
Created attachment 749511 [details]
emerge --info from the system
Comment 3 pva 2021-11-08 11:15:25 UTC
Created attachment 749514 [details, diff]
pymongo-3.12.1.ebuild.patch

Specified dependency version mentioned in setup.py.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-15 03:12:39 UTC
FWIW, we usually avoid runtime-only dependencies being conditional/given USE flags because it's a waste of a rebuild.

That said, sometimes it's OK if the build time is small for a package. The alternative is using optfeature.eclass for now until bug 424283 is solved.

See https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-15 03:22:52 UTC
(In reply to pva from comment #3)
> Created attachment 749514 [details, diff] [details, diff]
> pymongo-3.12.1.ebuild.patch
> 
> Specified dependency version mentioned in setup.py.

I don't think this will work because the 'test' USE flag is no longer defined (the d_e_t call did it before).

Did you mean to replace it with distutils_enable_tests unittest instead?
Comment 6 Larry the Git Cow gentoo-dev 2021-11-15 03:57:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4468b31c74ef96fd115dc3657f012b3695467e3

commit e4468b31c74ef96fd115dc3657f012b3695467e3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-15 03:57:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-15 03:57:06 +0000

    dev-python/pymongo: drop nose
    
    Closes: https://bugs.gentoo.org/822417
    Thanks-to: Peter Volkov <peter.volkov@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/pymongo/pymongo-3.12.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)