Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 807772 - net-libs/libproxy: bump Spidermonkey dependency from :68 -> :78
Summary: net-libs/libproxy: bump Spidermonkey dependency from :68 -> :78
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL: https://github.com/libproxy/libproxy/...
Whiteboard:
Keywords:
Depends on: 811858
Blocks:
  Show dependency tree
 
Reported: 2021-08-11 22:38 UTC by Marek Szuba
Modified: 2022-06-21 04:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2021-08-11 22:38:30 UTC
On the one hand, this is literally the only package in the tree depending on dev-lang/spidermonkey:68. On the other, at least on my system it has been trivial to bump this dependency to slot 78 - all I had to do to make libproxy build, test and install against it without any problems was change "mozjs-68" to "mozjs-78" in libproxy/cmake/modules/pacrunner_mozjs.cmk.
Comment 1 Marek Szuba archtester gentoo-dev 2021-08-11 23:33:45 UTC
(In reply to Marek Szuba from comment #0)

> this is literally the only package in the tree depending on
> dev-lang/spidermonkey:68.

To clarify: I meant that this is the only package depending EXCLUSIVELY on this slot. We have got some dev-libs/gjs and sys-auth/polkit ebuilds in the tree which depend on it as well but in either case, ebuilds for newer versions exist which use slot 78.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-08-11 23:34:42 UTC
Could you send a patch upstream?

By the way, this might be relevant to you (duktape support!)

https://github.com/libproxy/libproxy/commit/bcde153760ee885d2c633994e78ac447f8ec0713
Comment 3 Jakov Smolić archtester gentoo-dev 2022-03-24 23:25:50 UTC
I tried to build against spidermonkey-78, however it doesn't work:

FAILED: libproxy/CMakeFiles/libproxy.dir/modules/pacrunner_mozjs.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -D_POSIX_C_SOURCE=200112L -Dlibproxy_EXPORTS -DLIBEXECDIR=\"/usr/libexec\" -DMM_MODULE_BUILTIN=pacrunner_mozjs -I/var/tmp/porta
ge/net-libs/libproxy-0.4.17/work/libproxy-0.4.17 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/nspr -I/usr/include/mozjs-78  -fvisibility
=hidden -O2 -pipe -include /usr/include/mozjs-78/js/RequiredDefines.h -isystem /usr/include/mozjs-78 -I/usr/include/nspr -fPIC -MD -MT libproxy/CMakeFiles/libpr
oxy.dir/modules/pacrunner_mozjs.cpp.o -MF libproxy/CMakeFiles/libproxy.dir/modules/pacrunner_mozjs.cpp.o.d -o libproxy/CMakeFiles/libproxy.dir/modules/pacrunner
_mozjs.cpp.o -c /var/tmp/portage/net-libs/libproxy-0.4.17/work/libproxy-0.4.17/libproxy/modules/pacrunner_mozjs.cpp
/var/tmp/portage/net-libs/libproxy-0.4.17/work/libproxy-0.4.17/libproxy/modules/pacrunner_mozjs.cpp: In member function 'virtual std::string mozjs_pacrunner::ru
n(const libproxy::url&)':
/var/tmp/portage/net-libs/libproxy-0.4.17/work/libproxy-0.4.17/libproxy/modules/pacrunner_mozjs.cpp:180:21: error: 'AutoValueArray' is not a member of 'JS'; did
 you mean 'ValueArray'?
  180 |                 JS::AutoValueArray<2> args(this->jsctx);
      |                     ^~~~~~~~~~~~~~
      |                     ValueArray
/var/tmp/portage/net-libs/libproxy-0.4.17/work/libproxy-0.4.17/libproxy/modules/pacrunner_mozjs.cpp:180:39: error: 'args' was not declared in this scope
  180 |                 JS::AutoValueArray<2> args(this->jsctx);
      |                                       ^~~~
Comment 4 Larry the Git Cow gentoo-dev 2022-06-21 04:41:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10a0530ce687b5f01ae4b3dc2c831841dff77907

commit 10a0530ce687b5f01ae4b3dc2c831841dff77907
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-06-21 04:26:35 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-06-21 04:40:44 +0000

    profiles: Mask USE=spidermonkey on >=net-libs/libproxy-0.4.18
    
    Bug: https://bugs.gentoo.org/754954
    Bug: https://bugs.gentoo.org/807772
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/base/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)