Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80685 - x11-base/xorg-x11-6.8.2 fails to compile with GCC4
Summary: x11-base/xorg-x11-6.8.2 fails to compile with GCC4
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Gentoo X packagers
Keywords: Inclusion
: 81713 (view as bug list)
Depends on:
Reported: 2005-02-04 02:20 UTC by Priit Laes (IRC: plaes)
Modified: 2005-04-14 16:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

fbmmx-gcc4-compile-fix.patch (fbmmx-gcc4-compile-fix.patch,38.56 KB, patch)
2005-02-04 02:23 UTC, Priit Laes (IRC: plaes)
Details | Diff
cfbgc-gcc4.patch (cfbgc-gcc4.patch,448 bytes, patch)
2005-02-04 20:29 UTC, Bret Towe
Details | Diff
radeon-gcc4.patch (radeon-gcc4.patch,558 bytes, patch)
2005-02-04 20:29 UTC, Bret Towe
Details | Diff
MMX GCC4 compile fix (gcc4-mmx.patch,51.66 KB, patch)
2005-02-11 16:22 UTC, Mark Loeser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2005-02-04 02:20:06 UTC
Compile error in xc/programs/Xserver/fb/fbmmx.c if mmx is in USE flags.

The fix is present in Xorg CVS.

Reproducible: Always
Steps to Reproduce:
Comment 1 Priit Laes (IRC: plaes) 2005-02-04 02:23:22 UTC
Created attachment 50313 [details, diff]

This fixes at least compilation, don't know whether it works run-time.
Comment 2 Bret Towe 2005-02-04 20:28:58 UTC
i had to also apply 2 patchs from this bug:

to get it to compile
it still isnt working tho as the fbmmx seems to add some symbols and then has a linking problem

ill attach the 2 patchs i had to extract from the bug to save someone else some
time so they can get the link error if they want to play with that

Comment 3 Bret Towe 2005-02-04 20:29:29 UTC
Created attachment 50407 [details, diff]
Comment 4 Bret Towe 2005-02-04 20:29:46 UTC
Created attachment 50408 [details, diff]
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-05 01:11:03 UTC
Patch for xorg-x11 is already available, no need for gcc-porting to be on here.
Comment 6 Priit Laes (IRC: plaes) 2005-02-05 06:09:50 UTC
First problem still exists with current ebuild in portage.
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-05 16:12:14 UTC
ajax, I know you've tested with gcc4. Which of these are needed, correct, etc?
Comment 8 Priit Laes (IRC: plaes) 2005-02-06 23:46:34 UTC
I needed at least the fbmmx-gcc4-compile-fix.patch and cfbgc-gcc4.patch in order to compile, but I didn't have time to finish the whole build so third one may be possibly needed.
Comment 9 Mark Loeser (RETIRED) gentoo-dev 2005-02-11 16:22:39 UTC
Created attachment 51031 [details, diff]
MMX GCC4 compile fix

I got the same linking errors with MMX that Bret got.  I checked out a copy of
Xorg from cvs and I backported the changes for the MMX fb code that occurred
after the MMX patch got applied that we were using.  It allowed me to
successfully compile Xorg in my chroot.  I can't attest to it working yet, so
please test it.  For GCC 4, all 3 patches are needed to get it to compile.
Comment 10 Bret Towe 2005-02-15 15:06:37 UTC
i just tried these patchs and now it compiles and works fine for me
using ati-drivers btw

Portage (default-linux/x86/2004.2/gcc34, gcc-4.0.0, glibc-, 2.6.10-bk3 i686)
System uname: 2.6.10-bk3 i686 AMD K7 processo
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb 11 2005, 19:38:23)]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.4
sys-devel/libtool:   1.5.10-r4
CFLAGS="-march=athlon-xp -O2 -fomit-frame-pointer -pipe"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O2 -fomit-frame-pointer -pipe"
FEATURES="autoaddcvs autoconfig ccache distlocks fixpackages sandbox sfperms"
LDFLAGS="-Wl,-O1 -Wl,--enable-new-dtags -Wl,--sort-common -Wl,-z,combreloc -Wl,-z,nocopyreloc"
USE="x86 3dnow 3dnowex X alsa apm avi berkdb bitmap-fonts cjk crypt curl dga dvdvd dvdread encode f77 fam fbcon fbdev flac foomaticdb fortran gdbm gif gtk gtk2 imagemagick imlib ipv6 jpeg libg++ libwww live mad matroska mikmod mmx mmx2 motif mp3 mpeg ncurses nls nptl oggvorbis opengl pam pdflib perl png pvm python quicktime readline real samba sdl slang spell sse ssl svga tcltk tcpd theora tiff truetype truetype-fonts type1-fonts userlocales v4l v4l2 xml xml2 xmms xprint xvzlib"
Comment 11 SpanKY gentoo-dev 2005-02-19 14:31:00 UTC
*** Bug 81713 has been marked as a duplicate of this bug. ***
Comment 12 Adam Jackson 2005-02-19 14:45:00 UTC
all of these are "needed" in some sense.  the fbmmx one is sort of an accidental fix, but i'm glad to see it works.

they should all be safe to apply.
Comment 13 Jory A. Pratt 2005-03-06 13:07:40 UTC
How did this managed to get marked as criticial gentoo doesnt even support gcc 4 as of yet read /usr/portage/profile/package.mask. All bugs need to be upstreamed to there respective parties not gentoo.
Comment 14 Mark Loeser (RETIRED) gentoo-dev 2005-03-06 13:14:31 UTC
Jory, spyderous raised the severity on this bug, and xorg is his package, so I am assuming he would like to see this issue resolved.  The bugs are fixed upstream, and patches are supplied, which is what was asked for.  What was said was not to file bugs without patches.  

If we start working on patching programs now, hopefully we will have an easier time supporting GCC4 when it does come out.  All of these patches probably aren't going to be applied immediately by upstream.
Comment 15 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-14 16:41:22 UTC
Should be fixed in 6.8.2-r2.