Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 803071 - app-emulation/virt-viewer-10.0 has an automagic dependencies on x11-libs/vte and app-shells/bash-completion
Summary: app-emulation/virt-viewer-10.0 has an automagic dependencies on x11-libs/vte ...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-20 18:28 UTC by Chris Mayo
Modified: 2021-07-20 20:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2021-07-20 18:28:49 UTC
From meson_options.txt:
option('vte', type: 'feature', value: 'auto', description: 'VTE support')
...
option('bash_completion', type: 'feature', value: 'auto', description: 'bash-completion support')

From meson.build:
vte_min_version='>=0.46.0'
bash_completion_version='2.0'
...
vte_dep = dependency('vte-2.91', version: vte_min_version, required: get_option('vte'))
if vte_dep.found()
  conf_data.set('HAVE_VTE', '1')
endif

bash_completion_dep = dependency('bash-completion', version: '>=' + bash_completion_version, required: get_option('bash_completion'))

if bash_completion_dep.found()
  bash_completion_dir = get_option('bash_completion_dir')


Some other potential tidy-ups:

Could add to emesonargs (equivalent used to be in older ebuilds):
-Dovirt=disabled
although I don't think govirt is available in Gentoo.

Don't think there is a need to repeat the USE flag when the option has the same name e.g.:
$(meson_feature libvirt libvirt)
Comment 1 Chris Mayo 2021-07-20 18:31:53 UTC
Possible dev-lang/perl is no longer a DEPEND.

Might only have been needed for build-aux/syntax-check.mk.