Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 802789 - dev-python/flask-migrate-3.0.1 works fine with dev-python-flask-2.0.1 (tests do not fail)
Summary: dev-python/flask-migrate-3.0.1 works fine with dev-python-flask-2.0.1 (tests ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 722500
  Show dependency tree
 
Reported: 2021-07-18 18:05 UTC by Jack
Modified: 2021-07-19 06:14 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build --info (emerge_info.txt,18.51 KB, text/plain)
2021-07-18 18:30 UTC, Jack
Details
build log (build.log,25.65 KB, text/x-log)
2021-07-18 18:33 UTC, Jack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2021-07-18 18:05:56 UTC
flask-migrate entered the tree with https://bugs.gentoo.org/797955, but it includes RDEPEND="<dev-python/flask-2[${PYTHON_USEDEP}]" because of https://bugs.gentoo.org/801670.  Testing with flask-2.0.1 works fine. so I don't know why this restriction is still necessary.


Reproducible: Always

Steps to Reproduce:
Try to install flask-migrate-3.0.1 with flask-2.0.1

Actual Results:  
Portage insists on downgrading to flask-1.1.4.

Expected Results:  
Emerge should work without the downgrade

My first attempt at testing failed, because I didn't have dev-python/unittest-or-fail installed.  I'm not sure where this should have been pulled in.  In addition, just doing ebuild ... install does NOT run the tests, even with USE=test.  However, explicitly running ebuild ... test does work fine.

One more observation/question - if the initial test failure was just a test failure, with no indictaion (or did I miss it) that flask-migrate would actually fail in use, then why block flask-2 when tests seem to be disabled anyway?  The log from those failures seem to indicate that "flask db init" failed because "Error: No such command 'db'".  I did not check the full history of flask itself, but perhaps it was only a transient issue.

Bottom line - testing seems to succeed, so perhaps something in the test framework has changed since the original test failure.
Comment 1 Marco Scardovi (scardracs) 2021-07-18 18:18:31 UTC
Please post emerge --info and build log
Comment 2 Jack 2021-07-18 18:30:58 UTC
Created attachment 724894 [details]
build --info
Comment 3 Jack 2021-07-18 18:33:04 UTC
Created attachment 724897 [details]
build log

This was done by 
"ebuild ..../flask-migrate-3.0.1-r2.ebuild install"
"ebuild ..../flask-migrate-3.0.1-r2.ebuild qmerge"
"ebuild ..../flask-migrate-3.0.1-r2.ebuild test"

as I don't have my system set up to save build logs on normal emerge.
Comment 4 Ralph Seichter 2021-07-18 18:39:20 UTC
Please also see gentoo-users mailing list thread [1] where Jack and I discuss the matter. I can confirm that flask-migrate tests pass successfully when I run them against dev-python/flask-2.0.1-r1.

[1] https://archives.gentoo.org/gentoo-user/message/82d2233bfddf214b31679baf1b9fbee1
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-07-19 06:07:36 UTC
Well, I've added the restriction after a reported test failure, so I'm not really sure what happened there.  Lemme retry.
Comment 6 Larry the Git Cow gentoo-dev 2021-07-19 06:14:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9623cab96ac82238ab0561a0d6b76303a118b548

commit 9623cab96ac82238ab0561a0d6b76303a118b548
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-07-19 06:12:41 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-07-19 06:13:09 +0000

    dev-python/flask-migrate: Revert "Depend on old flask"
    
    Reverts: fa07ab7c493bdfa4a1f217f5a67779972cfb52bf
    Closes: https://bugs.gentoo.org/802789
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../{flask-migrate-3.0.1-r1.ebuild => flask-migrate-3.0.1-r2.ebuild}    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)