Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 796278 - dev-libs/tvision-2.2.3 calls ar directly
Summary: dev-libs/tvision-2.2.3 calls ar directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernd
URL: https://github.com/set-soft/tvision/i...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2021-06-16 06:40 UTC by Agostino Sarubbo
Modified: 2021-06-21 22:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,38.73 KB, text/plain)
2021-06-16 06:40 UTC, Agostino Sarubbo
Details
tvision-2.2.3-0001-use-proper-AR.patch (tvision-2.2.3-0001-use-proper-AR.patch,3.26 KB, text/plain)
2021-06-16 08:28 UTC, Bernd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-06-16 06:40:28 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/tvision-2.2.3 calls ar directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different AR implementation (like llvm-ar). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].
Comment 1 Agostino Sarubbo gentoo-dev 2021-06-16 06:40:30 UTC
Created attachment 716376 [details]
build.log

build log and emerge --info
Comment 2 Bernd 2021-06-16 07:23:52 UTC
I didn't check configuration without native-symlinks... The patch I've applied was actually using $(AR) during src_compile.
Comment 3 Bernd 2021-06-16 08:25:21 UTC
I tried to fix the function in conflib.pl, but unfortunately my perl skills are too low, the configure doesn't output any ar now, but still builds the archive properly, although on a machine with native-symlinks enabled.
We need to wait if upstream will provide a patch. I attach my modified patch here for review, if someone with perl skills might want to help out with this.
Comment 4 Bernd 2021-06-16 08:28:37 UTC
Created attachment 716430 [details]
tvision-2.2.3-0001-use-proper-AR.patch

updated patch to detect ar. It's properly detected, as a grep in configure.cache tells, but it's doesn't have proper output.
Comment 5 Larry the Git Cow gentoo-dev 2021-06-21 22:26:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d31cdd2b84207dafe2af4e969a12742a7630836

commit 9d31cdd2b84207dafe2af4e969a12742a7630836
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2021-06-16 08:43:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-21 22:26:04 +0000

    dev-libs/tvision: properly detect ar
    
    Closes: https://bugs.gentoo.org/796278
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/21333
    Signed-off-by: Sam James <sam@gentoo.org>

 ...mmand-now-can-be-configured-from-the-envi.patch | 56 ++++++++++++++++++++
 .../files/tvision-2.2.3-0001-use-proper-AR.patch   | 23 ---------
 ...ed-configuration-option-to-exclude-libgpm.patch | 60 ++++++++++++++++++++++
 .../tvision-2.2.3-0003-Adjusted-c-years.patch      | 34 ++++++++++++
 ...n-2.2.3-0004-Made-ar-command-configurable.patch | 23 +++++++++
 dev-libs/tvision/tvision-2.2.3.ebuild              | 10 ++--
 6 files changed, 180 insertions(+), 26 deletions(-)