Bug 791091 – games-rpg/freedroid-1.0.2-r1 fails with -fno-common: main.o:(.bss+0xa36c): multiple definition of `FPSover100'; misc.o:(.data+0x0): first defined here

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Savchenko 2021-05-19 14:19:19 UTC]

Created attachment 709797 [details]
freedroid.log.gz

Hi,

freedroid fails to build with gcc-11/-fno-common:

/usr/lib/gcc/i686-pc-linux-gnu/11.1.0/../../../../i686-pc-linux-gnu/bin/ld: main.o:(.bss+0xa36c): multiple definition of `FPSover100'; misc.o:(.data+0x0): first defined here
/usr/lib/gcc/i686-pc-linux-gnu/11.1.0/../../../../i686-pc-linux-gnu/bin/ld: disabling relaxation; it will not work with multiple definitions
/usr/lib/gcc/i686-pc-linux-gnu/11.1.0/../../../../i686-pc-linux-gnu/bin/ld: main.o:(.bss+0xa370): multiple definition of `FPSover10'; misc.o:(.data+0x4): first defined here
/usr/lib/gcc/i686-pc-linux-gnu/11.1.0/../../../../i686-pc-linux-gnu/bin/ld: main.o:(.bss+0xa374): multiple definition of `FPSover1'; misc.o:(.data+0x8): first defined here
/usr/lib/gcc/i686-pc-linux-gnu/11.1.0/../../../../i686-pc-linux-gnu/bin/ld: main.o:(.bss+0xa3a0): multiple definition of `ConfigDir'; misc.o:(.bss+0x20): first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:186: freedroid] Error 1

See full build log for details.

The fix is simple enough and is attached below.

[Comment 1 Andrew Savchenko 2021-05-19 14:19:48 UTC]

Created attachment 709800 [details]
emerge --info

[Comment 2 Andrew Savchenko 2021-05-19 14:21:58 UTC]

Created attachment 709803 [details, diff]
freedroid-1.0.2-common.patch

Signed-off-by: Andrew Savchenko <[e-mail]>

[Comment 3 Andrew Savchenko 2021-06-05 20:09:03 UTC]

Ping.

Ok to apply proposed patch?

[Comment 4 Ionen Wolkens 2021-06-05 22:37:03 UTC]

Looks fine but I'll add the patch myself tomorrow, had a look at freedroidrpg not long ago so I might as well cleanup this ebuild too at same time (thanks for the ping).

[Comment 5 Larry the Git Cow 2021-06-06 02:34:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4aa71a030a8a8e4bfe8905bcbfc43a4e9a88ea44

commit 4aa71a030a8a8e4bfe8905bcbfc43a4e9a88ea44
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2021-06-06 01:55:32 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2021-06-06 02:33:07 +0000

    games-rpg/freedroid: add 1.2.1, EAPI-7 bump
    
    - switch homepage to github as old pages are dedicated to freedroidrpg
    - new dep on media-libs/sdl-gfx
    - re-arrange depends for build-only checks
    
    Upstream fixed -fno-common issues wrt bug #791091
    
    Closes: https://bugs.gentoo.org/791091
    Signed-off-by: Ionen Wolkens <[e-mail]>

 games-rpg/freedroid/Manifest               |  1 +
 games-rpg/freedroid/freedroid-1.2.1.ebuild | 41 ++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+)

[Comment 6 Andrew Savchenko 2021-06-06 06:58:30 UTC]

Thanks!