Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 7868 - irssi-0.8.5-r2.ebuild (Bugfix for emerge failure with perl)
Summary: irssi-0.8.5-r2.ebuild (Bugfix for emerge failure with perl)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Michael Cummings (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-13 03:34 UTC by Kalle Kivistö
Modified: 2002-09-13 19:24 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to irssi-0.8.5-r2.ebuild (patch.txt,1.35 KB, patch)
2002-09-13 03:35 UTC, Kalle Kivistö
Details | Diff
replacement ebuild with eclass actually used (irssi-0.8.5-r2.ebuild,1.79 KB, application/octet-stream)
2002-09-13 16:14 UTC, Michael Cummings (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kalle Kivistö 2002-09-13 03:34:22 UTC
emerging irssi dies with PERMISSION DENIED error from sandbox.
The included patch fixes that.
Comment 1 Kalle Kivistö 2002-09-13 03:35:12 UTC
Created attachment 3885 [details, diff]
Patch to irssi-0.8.5-r2.ebuild
Comment 2 SpanKY gentoo-dev 2002-09-13 08:12:02 UTC
an e-mail from gentoo-dev list (from mcummings actually)

<snip>
If your ebuild uses perl, there are some things you need to be aware of. Perl 
5.6.1's default MakeMaker module, that portion that creates the make file from 
the perl Makefile.PL file, was flawed. Although it didn't violate the sandbox, 
it doesn't always honor your target build directories. It also failed to 
recognize build syntax that it was supposed to understand, such as not always 
honoring the PREFIX you passed it. Because the potential harm outweighed the 
mess I have now, this has been fixed for future/current users. THIS ONLY 
AFFECTS EBUILDS THAT USE PERL MAKEFILE, NOT EBUILDS THAT MERELY COMPILE AGAINST 
PERL'S LIBRARIES/BINARIES.

The result? If your ebuild at any point generates a perl module as an add on, 
and you are manually passing it a "perl Makfile.PL" instead of incorporating 
the perl-modules eclass, it *will* break. These bugs are getting assigned to me 
right now, and I am fixing them, but I wanted to make you aware should you have 
a new release come up and you don't check to see if any changes were made to 
the ebuild since last time.
</snip>
Comment 3 Michael Cummings (RETIRED) gentoo-dev 2002-09-13 08:28:03 UTC
Egads, quoting to me to me is its own level of notoriety.

Kalle: Rather than sed the file, I'm going to first see if the perl-module 
eclass can simply be imported to handle the dirty work. I've done a lot of work 
on that eclass, and though not perfect, it sure saves a lot of steps :) Will 
try and have an update shortly. Should it look good to you, I will post this as 
an in place fix for irssi rather than as a version bump since it won't affect 
people who already have irssi installed.

michael
Comment 4 Michael Cummings (RETIRED) gentoo-dev 2002-09-13 15:27:25 UTC
Lamer, adding you as a cc so you know that I'm modd'ing this.
Comment 5 Michael Cummings (RETIRED) gentoo-dev 2002-09-13 16:14:48 UTC
Created attachment 3898 [details]
replacement ebuild with eclass actually used

Similar veign to your proposed ebuild, but instead this version actually calls
the  eclass' perl Makefile.PL line rather than manually doing it. Centralizing
that call to the eclass will help should there be future changes in perl. I
also removed the first ${S}/src/perl you had - there is no Makefile.PL in that
directory to work with :)

Let me know if this works for you and I will commit it over top of the current
-r2 for irssi.

Michael
Comment 6 SpanKY gentoo-dev 2002-09-13 16:26:49 UTC
i tested out the ebuild on 2 different setups (1 server based the other 
desktop) and it worked on both
Comment 7 Kalle Kivistö 2002-09-13 17:10:36 UTC
Thank you, your ebuild works perfectly! I had a nagging feeling I didn't do it
quite right, and seems I was right =) As a bonus, now I'll know how to fix it 
correctly in the future if I ever should come across the same problem in some
other ebuild.
Comment 8 Mark 2002-09-13 17:37:58 UTC
Works perfectly! :)

Mark
Comment 9 Michael Cummings (RETIRED) gentoo-dev 2002-09-13 19:24:55 UTC
Kalle, you were definitely on the right track! I just used the eclass to handle
the configure portion so that we could be certain that it would conform to the
sandbox, both now and should anything ever change in the future (one breaking
point instead of the many we have now). I've commited this "in place" (no
revision bump).