Created attachment 702372 [details] build.log -- Configuring done CMake Error at Source/Lib/Encoder/CMakeLists.txt:120 (add_library): Target "SvtAv1Enc" links to target "Threads::Threads" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at Source/Lib/Decoder/CMakeLists.txt:91 (add_library): Target "SvtAv1Dec" links to target "Threads::Threads" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at Source/App/EncApp/CMakeLists.txt:25 (add_executable): Target "SvtAv1EncApp" links to target "Threads::Threads" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? CMake Error at Source/App/DecApp/CMakeLists.txt:24 (add_executable): Target "SvtAv1DecApp" links to target "Threads::Threads" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? -- Generating done CMake Generate step failed. Build files cannot be regenerated correctly. * ERROR: media-libs/svt-av1-0.8.6::gentoo failed (configure phase): ---- Portage 3.0.17 (python 3.9.2-final-0, default/linux/arm64/17.0/desktop, gcc-10.2.0, glibc-2.32-r7, 5.4.113-gentoo-dist aarch64) ================================================================= System uname: Linux-5.4.113-gentoo-dist-aarch64-with-glibc2.32 KiB Mem: 131636508 total, 79224748 free KiB Swap: 16777212 total, 16777212 free Timestamp of repository gentoo: Sun, 25 Apr 2021 08:05:14 +0000 sh dash 0.5.11.3-r1 ld GNU ld (Gentoo 2.35.2 p1) 2.35.2 app-shells/bash: 5.0_p18::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.30.3::gentoo dev-lang/python: 3.7.10_p1::gentoo, 3.8.8_p1::gentoo, 3.9.2_p1::gentoo dev-lang/rust: 1.51.0-r2::gentoo dev-lang/rust-bin: 1.51.0::gentoo dev-util/cmake: 3.18.5::gentoo sys-apps/baselayout: 2.7::gentoo sys-apps/openrc: 0.42.1-r1::gentoo sys-apps/sandbox: 2.21::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.69-r5::gentoo sys-devel/automake: 1.16.2-r1::gentoo sys-devel/binutils: 2.35.2::gentoo sys-devel/gcc: 10.2.0-r5::gentoo sys-devel/gcc-config: 2.3.2-r1::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers) sys-libs/glibc: 2.32-r7::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-jobs: 1 sync-rsync-extra-opts: sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 ACCEPT_KEYWORDS="arm64" ACCEPT_LICENSE="*" CBUILD="aarch64-unknown-linux-gnu" CFLAGS="-O2 -pipe -march=native -frecord-gcc-switches" CHOST="aarch64-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -march=native -frecord-gcc-switches" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--keep-going --complete-graph --usepkg=y --with-bdeps=y --deep" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe -march=native -frecord-gcc-switches" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -march=native -frecord-gcc-switches" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="C.UTF8" LDFLAGS="-O2 -pipe -march=native -frecord-gcc-switches -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0" MAKEOPTS="-j2" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl acpi alsa arm64 berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups dbus dri dts dvdr elogind emboss encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp spell split-usr ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zlib" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_ARM="edsp thumb thumb2 v4 v5 v6 v7 v8 vfp vfp-d32 vfpv3 vfpv4" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-US en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8 python3_7 python3_9" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="fbdev dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
This looks like it uses the standard find_package(Threads). -- Looking for pthread.h - not found -- Could NOT find Threads (missing: Threads_FOUND) Is there anything I can do here? I was under the impression this was supplied by glibc https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/v0.8.6/CMakeLists.txt#L255
(In reply to Theo Anderson from comment #1) > This looks like it uses the standard find_package(Threads). > > -- Looking for pthread.h - not found > -- Could NOT find Threads (missing: Threads_FOUND) > > Is there anything I can do here? I was under the impression this was > supplied by glibc > > https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/v0.8.6/CMakeLists.txt#L255 I promise there's nothing crazy about this machine. Those errors are usually misleading -- it's a 'NOT find' but actually it's not the fatal error.
SVT-AV1 adds Threads::Threads to the linking libs regardless of whether Threads is found or not. https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/v0.8.6/Source/Lib/Encoder/CMakeLists.txt#L20 So I suppose the correct way would be find_package(Threads REQUIRED), but then it would just error out at not finding pthread.h? I don't know how I can try to fix this. Is there a way to try to reproduce without firing up qemu?
(In reply to Theo Anderson from comment #3) > SVT-AV1 adds Threads::Threads to the linking libs regardless of whether > Threads is found or not. > > https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/v0.8.6/Source/Lib/Encoder/ > CMakeLists.txt#L20 > > So I suppose the correct way would be find_package(Threads REQUIRED), but > then it would just error out at not finding pthread.h? > > I don't know how I can try to fix this. Is there a way to try to reproduce > without firing up qemu? Red herring, the problem comes from upstream's stupid mucking with flags. Attached a patch that fixed it on our ARM64 box.
Created attachment 702405 [details, diff] svt-av1-0.8.6-fix-mno-avx.patch
> Red herring, the problem comes from upstream's stupid mucking with flags. > Attached a patch that fixed it on our ARM64 box. When compiling with -O3, -mno-avx is needed at least on my system or I encounter segfaults when attempting to encode any file. See https://github.com/AOMediaCodec/SVT-AV1/issues/1668#issuecomment-758388316 I'll assume this is just an amd64 issue and after your patch append -mno-avx behind the amd64 use flag. Thanks for testing and narrowing it down, though I wonder why Sam didn't run into this beforehand?
(In reply to Theo Anderson from comment #6) > > Red herring, the problem comes from upstream's stupid mucking with flags. > > Attached a patch that fixed it on our ARM64 box. > > When compiling with -O3, -mno-avx is needed at least on my system or I > encounter segfaults when attempting to encode any file. See > https://github.com/AOMediaCodec/SVT-AV1/issues/1668#issuecomment-758388316 > > I'll assume this is just an amd64 issue and after your patch append -mno-avx > behind the amd64 use flag. > > Thanks for testing and narrowing it down, though I wonder why Sam didn't run > into this beforehand? I'm willing to bet this is some undefined behaviour in the codebase somewhere. Valid code shouldn't segfault on -O3, even with AVX. Have you tried running it through UBSAN (which will detect stuff like alignment issues)?
(In reply to David Seifert from comment #7) > I'm willing to bet this is some undefined behaviour in the codebase > somewhere. Valid code shouldn't segfault on -O3, even with AVX. Have you > tried running it through UBSAN (which will detect stuff like alignment > issues)? With -fsanitize=address,undefined (no sigsegv without address): /var/tmp/portage/media-libs/svt-av1-0.8.6/work/SVT-AV1-0.8.6/Source/Lib/Encoder/Codec/EbModeDecisionProcess.c:180:77: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/tmp/portage/media-libs/svt-av1-0.8.6/work/SVT-AV1-0.8.6/Source/Lib/Encoder/Codec/EbModeDecisionProcess.c:180:77 in /var/tmp/portage/media-libs/svt-av1-0.8.6/work/SVT-AV1-0.8.6/Source/Lib/Encoder/Codec/EbModeDecisionProcess.c:182:76: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/tmp/portage/media-libs/svt-av1-0.8.6/work/SVT-AV1-0.8.6/Source/Lib/Encoder/Codec/EbModeDecisionProcess.c:182:76 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==2731959==ERROR: AddressSanitizer: SEGV on unknown address 0xffffffffffffffff (pc 0x55a5a40d493d bp 0x7ffe38485650 sp 0x7ffe38484dd0 T0) ==2731959==The signal is caused by a READ memory access. #0 0x55a5a40d493d (/usr/bin/SvtAv1EncApp+0x13493d) #1 0x55a5a40a579e in pthread_create (/usr/bin/SvtAv1EncApp+0x10579e) #2 0x7f3282510700 in svt_create_thread /usr/src/debug/media-libs/svt-av1-0.8.6/SVT-AV1-0.8.6/Source/Lib/Common/Codec/EbThreads.c:93:11 #3 0x7f32831ba29e in svt_av1_enc_init /usr/src/debug/media-libs/svt-av1-0.8.6/SVT-AV1-0.8.6/Source/Lib/Encoder/Globals/EbEncHandle.c:1803:5 #4 0x55a5a410bf45 in init_encoder /usr/src/debug/media-libs/svt-av1-0.8.6/SVT-AV1-0.8.6/Source/App/EncApp/EbAppContext.c:282:20 #5 0x55a5a410f1f8 in enc_context_ctor /usr/src/debug/media-libs/svt-av1-0.8.6/SVT-AV1-0.8.6/Source/App/EncApp/EbAppMain.c:141:35 #6 0x55a5a410f1f8 in main /usr/src/debug/media-libs/svt-av1-0.8.6/SVT-AV1-0.8.6/Source/App/EncApp/EbAppMain.c:429:24 #7 0x7f32813067fc in __libc_start_main (/lib64/libc.so.6+0x267fc) #8 0x55a5a4040689 (/usr/bin/SvtAv1EncApp+0xa0689) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV (/usr/bin/SvtAv1EncApp+0x13493d) ==2731959==ABORTING Not sure if the undefined error is related, perhaps it's time to file a bug about it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57f7070d2cb6fc5b55a06cde9fac48821128b90f commit 57f7070d2cb6fc5b55a06cde9fac48821128b90f Author: David Seifert <soap@gentoo.org> AuthorDate: 2021-09-07 02:54:30 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-09-07 02:55:02 +0000 media-libs/svt-av1: fix build on non-amd64 Closes: https://bugs.gentoo.org/785556 Signed-off-by: David Seifert <soap@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org> .../svt-av1/files/svt-av1-0.8.6-no-force-avx.patch | 18 ++++++++++++++++++ media-libs/svt-av1/svt-av1-0.8.6.ebuild | 12 ++++++++++++ 2 files changed, 30 insertions(+)
