Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 781557 - app-misc/ddcutil: migrate to GLEP 81
Summary: app-misc/ddcutil: migrate to GLEP 81
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: glep-81
  Show dependency tree
 
Reported: 2021-04-08 21:31 UTC by Conrad Kostecki
Modified: 2021-07-09 22:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2021-04-08 21:31:49 UTC
Current package still uses old 'user' eclass. Please port to GLEP 81.
If you need help, just ask.
Comment 1 Vladimir Timofeenko 2021-04-21 02:09:24 UTC
I would like to try my hand at fixing this bug (as well as move the ebuild to EAPI 7 and version bump ddcutil)

To remove enewgroup calls, RDEPEND for two packages will be required. "acct-group/video" (exists) and "acct-group/i2c" (needs to be created).

There is an existing pull request on #18551 GH, which adds acct-group/i2c, but looks like it has been in review for a while.

What would be the best course of action so as not to introduce unnecessary conflicts? Create a separate acct-group/i2c as part of this pull request?
Comment 2 Conrad Kostecki gentoo-dev 2021-04-21 14:24:12 UTC
I will have a look at the PR and will report back, when the group is merged.
Comment 3 Vladimir Timofeenko 2021-04-21 16:18:52 UTC
OK, I will work in my branch and make a PR for now assuming that the i2c group will be created in PR #18551. 

Should this change - I can add the group later in my PR.

Two questions for that scenario:

* Do I understand that I should pick the ACCT_GROUP_ID at random as long as it does not collide with an existing ID and it's less than 1000?
* What values should be specified in the maintainer section in metadata?
Comment 4 Larry the Git Cow gentoo-dev 2021-04-21 19:59:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ee67694aefba13bdce3a5d20bd5a2acf2a5248c

commit 8ee67694aefba13bdce3a5d20bd5a2acf2a5248c
Author:     Peter Alfredsen <crabbedhaloablution@icloud.com>
AuthorDate: 2020-12-07 16:34:20 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-04-21 19:59:38 +0000

    acct-group/i2c: add group
    
    This will be used for app-misc/ddcutil
    and for upcoming sys-apps/raspberrypi-sys-mods.
    
    Bug: https://bugs.gentoo.org/758917
    Bug: https://bugs.gentoo.org/781557
    Bug: https://github.com/gentoo/gentoo/pull/18551
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Peter Alfredsen <crabbedhaloablution@icloud.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 acct-group/i2c/i2c-0.ebuild |  8 ++++++++
 acct-group/i2c/metadata.xml | 12 ++++++++++++
 2 files changed, 20 insertions(+)
Comment 5 Conrad Kostecki gentoo-dev 2021-04-21 20:02:21 UTC
I added the missing groups, so please rebase :-)
Comment 6 Vladimir Timofeenko 2021-04-21 20:40:31 UTC
Done
Comment 7 Larry the Git Cow gentoo-dev 2021-07-09 22:36:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ba65d9ea7311dbb822aeb08b8890eaa03cb758e

commit 5ba65d9ea7311dbb822aeb08b8890eaa03cb758e
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-09 22:34:50 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-09 22:36:39 +0000

    app-misc/ddcutil: drop old version
    
    Closes: https://bugs.gentoo.org/781557
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 app-misc/ddcutil/Manifest             |   2 -
 app-misc/ddcutil/ddcutil-0.9.1.ebuild | 106 -------------------------------
 app-misc/ddcutil/ddcutil-0.9.5.ebuild | 107 -------------------------------
 app-misc/ddcutil/ddcutil-0.9.9.ebuild | 114 ----------------------------------
 4 files changed, 329 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f902a4b8af6d21527c8942cf06730f832bb547e

commit 3f902a4b8af6d21527c8942cf06730f832bb547e
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-09 22:33:37 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-09 22:36:38 +0000

    app-misc/ddcutil: migrate to GLEP 81
    
    Closes: https://bugs.gentoo.org/781557
    Closes: https://bugs.gentoo.org/792792
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 app-misc/ddcutil/ddcutil-0.9.9-r1.ebuild | 116 +++++++++++++++++++++++++++++++
 1 file changed, 116 insertions(+)