Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77210 - bring back progsreiserfs
Summary: bring back progsreiserfs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 117693 (view as bug list)
Depends on: 51773
Blocks:
  Show dependency tree
 
Reported: 2005-01-09 03:25 UTC by Robin Johnson
Modified: 2006-01-04 06:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-01-09 03:25:19 UTC
progsreiserfs is needed for parted and testdisk.

progsreiserfs has two problems in it's 0.3.0 release:
- a partition generated with mkfs acts very weird
- the resize tool is very broken.
both of these are documented by debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=244169

I can't reproduce these under the 0.3.1rc8 release of progsreiserfs, so I'd like opinions on bringing back progsreiserfs carefully (perhaps with the resize and mkfs functionality well out of the way until it's proven stable).
Comment 1 SpanKY gentoo-dev 2005-01-09 13:25:07 UTC
i dont mind bringing it back ... however, as soon as we hit any bugs with it, i'll just punt it again considering upstream has been dead for a while now

there's also the problem of the naming of the tools ... they're easily confused with the official reiser package ...

what exactly does parted/testdisk need ?  the resize prog ?  we could add a version of progsreiserfs that only installs one or two of the binaries ...
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-01-09 16:03:53 UTC
parted and testdisk both need the libreiserfs library to link against.
For progsreiserfs, I'm not sure if the problems are in the executables, (which are reasonably small, but still have potential for problems), or in the library itself (which contains the majority of the code).

parted and testdisk use libreiserfs to provide a slew of reiserfs functionality - mainly how to correctly interact with partition. Only parted uses the mkfs/resizefs parts however. testdisk uses the libreiserfs to find the correct tree order for recovering data.
Comment 3 SpanKY gentoo-dev 2005-01-09 16:10:55 UTC
the mkfs is the one i'm most concerned with

could you research and see if it's feasible to replace the call to the progsreiserfs mkfs with the official reiserfsprogs mkfs ?  same goes for the resize binary ...

i'll gladly add this package back in if it only provides the library
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-01-09 16:27:29 UTC
parted doesn't call the progsreiserfs executables! it uses the library functions (in a possibly incorrect way too, compare the mkfs/resizefs sources in progreiserfs to the reiserfs_create/reiserfs_resize functions in parted-1.6.20/libparted/fs_reiserfs/reiserfs.c )

In parted, it's possible to turn off the mkfs/resizefs/copyfs/checkfs usage from progreiserfs by undef'ing REISER_FULL_SUPPORT in the config.h.
Comment 5 SpanKY gentoo-dev 2005-01-09 16:33:58 UTC
oh, when you said 'Only parted uses the mkfs/resizefs parts however.' i thought you mean it called the progsreiserfs binaries

i'll add 0.3.1rc8 back into portage but have it rm the bin dirs ... those apps were the reason we punted it from portage in the first place
Comment 6 Carsten Lohrke (RETIRED) gentoo-dev 2005-01-09 16:53:43 UTC
Just disable the resizing, if you don't want to kill users partitions. I for one won't trust this piece of software anymore.
Comment 7 SpanKY gentoo-dev 2005-01-09 18:10:36 UTC
added 0.3.1_rc8 to portage ... all it does is install the libraries / headers
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-01-09 18:41:23 UTC
You put it straight into stable.
I've changed it to unstable (until it's proven more), and added a scattering of warnings into it.
Comment 9 SpanKY gentoo-dev 2005-01-09 18:49:15 UTC
i copied the 3.0.4 ebuild and thought i had changed KEYWORDS

guess not, *shrug*
Comment 10 SpanKY gentoo-dev 2006-01-04 06:31:26 UTC
*** Bug 117693 has been marked as a duplicate of this bug. ***