Bug 769341 – net-misc/unison[gtk] depends on dev-ml/lablgtk:2

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Andreas Sturmlechner 2021-02-07 15:53:30 UTC]

x11-libs/gtk+:2 is dead and needs to go away.

[Comment 1 Volkmar W. Pogatzki 2021-02-07 19:17:39 UTC]

(In reply to Andreas Sturmlechner from comment #0)
> x11-libs/gtk+:2 is dead and needs to go away.

Upstream: https://github.com/bcpierce00/unison/issues/358

[Comment 2 Andreas Sturmlechner 2021-07-29 09:05:42 UTC]

Upstream PR to switch to GTK3.

[Comment 3 Bernd Feige 2021-10-08 11:18:13 UTC]

Created attachment 743826 [details]
Updated ebuild with lablgtk:3

Ebuild with the patches of https://github.com/tleedjarv/unison

[Comment 4 Bernd Feige 2021-10-08 11:19:32 UTC]

Created attachment 743829 [details, diff]
Replace statistics GtkCList with GtkTreeView

[Comment 5 Bernd Feige 2021-10-08 11:20:05 UTC]

Created attachment 743832 [details, diff]
uigtk2: Compile with lablgtk3

[Comment 6 Bernd Feige 2021-10-08 11:20:38 UTC]

Created attachment 743835 [details, diff]
Remove last remnants of uigtk

[Comment 7 Bernd Feige 2021-10-08 11:21:09 UTC]

Created attachment 743838 [details, diff]
uigtk2 -> uigtk3

[Comment 8 Bernd Feige 2021-10-08 11:22:17 UTC]

Created attachment 743841 [details, diff]
Additional patch needed to arrive at  tleedjarv' version of uigtk3.ml

[Comment 9 Bernd Feige 2021-10-08 11:27:45 UTC]

I just pulled the patches from the linked pull request https://github.com/bcpierce00/unison/pull/566 on top of current unison-2.51.4. The four patches are not sufficient to also replace the mainWindow widget in uigtk3.ml, so I pulled that file directly from https://github.com/tleedjarv/unison and added rest.patch to get that version.

With this, unison compiles and runs fine - seems that the diff widget is fixed height and therefore hardly usable, but all basic functionality is in place.

[Comment 10 Bernd Feige 2022-02-22 21:29:19 UTC]

Created attachment 765681 [details]
Updated ebuild with lablgtk:3

[Comment 11 Bernd Feige 2022-02-22 21:31:27 UTC]

Created attachment 765682 [details, diff]
Replace statistics GtkCList with GtkTreeView

[Comment 12 Bernd Feige 2022-02-22 21:32:08 UTC]

Created attachment 765683 [details, diff]
GHA: Fix building lablgtk on Windows

[Comment 13 Bernd Feige 2022-02-22 21:32:46 UTC]

Created attachment 765684 [details, diff]
uigtk2: Compile with lablgtk3

[Comment 14 Bernd Feige 2022-02-22 21:33:30 UTC]

Created attachment 765685 [details, diff]
Remove last remnants of uigtk

[Comment 15 Bernd Feige 2022-02-22 21:34:08 UTC]

Created attachment 765686 [details, diff]
uigtk2 -> uigtk3

[Comment 16 Bernd Feige 2022-02-22 21:37:24 UTC]

Attached is now the ebuild using the rebased patches from pull request https://github.com/bcpierce00/unison/pull/566 on top of 2.51.5 (of Jan 16/17).

[Comment 17 Sam James 2022-02-22 21:42:18 UTC]

(In reply to Bernd Feige from comment #16)
> Attached is now the ebuild using the rebased patches from pull request
> https://github.com/bcpierce00/unison/pull/566 on top of 2.51.5 (of Jan
> 16/17).

Could you please either make a github PR or attach a git am-able patch to this bug (use git format-patch) from the gentoo.git repository which I can apply? It would include the ebuilds and all patches.

[Comment 18 Bernd Feige 2022-02-23 15:28:08 UTC]

Created attachment 765714 [details]
git am-able patch for GTK3 switch

Please find the requested patch attached.

[Comment 19 Andreas Sturmlechner 2022-05-18 12:52:21 UTC]

GTK3

[Comment 20 Andreas Sturmlechner 2022-05-18 12:52:45 UTC]

...GTK3 support is now in git master.