x11-libs/gtk+:2 is dead and needs to go away.
(In reply to Andreas Sturmlechner from comment #0) > x11-libs/gtk+:2 is dead and needs to go away. Upstream: https://github.com/bcpierce00/unison/issues/358
Upstream PR to switch to GTK3.
Created attachment 743826 [details] Updated ebuild with lablgtk:3 Ebuild with the patches of https://github.com/tleedjarv/unison
Created attachment 743829 [details, diff] Replace statistics GtkCList with GtkTreeView
Created attachment 743832 [details, diff] uigtk2: Compile with lablgtk3
Created attachment 743835 [details, diff] Remove last remnants of uigtk
Created attachment 743838 [details, diff] uigtk2 -> uigtk3
Created attachment 743841 [details, diff] Additional patch needed to arrive at tleedjarv' version of uigtk3.ml
I just pulled the patches from the linked pull request https://github.com/bcpierce00/unison/pull/566 on top of current unison-2.51.4. The four patches are not sufficient to also replace the mainWindow widget in uigtk3.ml, so I pulled that file directly from https://github.com/tleedjarv/unison and added rest.patch to get that version. With this, unison compiles and runs fine - seems that the diff widget is fixed height and therefore hardly usable, but all basic functionality is in place.
Created attachment 765681 [details] Updated ebuild with lablgtk:3
Created attachment 765682 [details, diff] Replace statistics GtkCList with GtkTreeView
Created attachment 765683 [details, diff] GHA: Fix building lablgtk on Windows
Created attachment 765684 [details, diff] uigtk2: Compile with lablgtk3
Created attachment 765685 [details, diff] Remove last remnants of uigtk
Created attachment 765686 [details, diff] uigtk2 -> uigtk3
Attached is now the ebuild using the rebased patches from pull request https://github.com/bcpierce00/unison/pull/566 on top of 2.51.5 (of Jan 16/17).
(In reply to Bernd Feige from comment #16) > Attached is now the ebuild using the rebased patches from pull request > https://github.com/bcpierce00/unison/pull/566 on top of 2.51.5 (of Jan > 16/17). Could you please either make a github PR or attach a git am-able patch to this bug (use git format-patch) from the gentoo.git repository which I can apply? It would include the ebuilds and all patches.
Created attachment 765714 [details] git am-able patch for GTK3 switch Please find the requested patch attached.
GTK3
...GTK3 support is now in git master.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=437509263eb4ac577eb618e8744a06d8ad7a3b5b commit 437509263eb4ac577eb618e8744a06d8ad7a3b5b Author: Christopher Fore <csfore@posteo.net> AuthorDate: 2023-11-25 19:19:14 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-01-27 09:16:49 +0000 net-misc/unison: add 2.53.3 Tested on amd64 and builds successfully, tests pass. Removed ~sparc-solaris from the original ebuild provided as `pkgcheck scan` said it was unknown. Bug: https://bugs.gentoo.org/769341 Closes: https://bugs.gentoo.org/887609 Signed-off-by: Christopher Fore <csfore@posteo.net> Closes: https://github.com/gentoo/gentoo/pull/33986 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-misc/unison/Manifest | 1 + net-misc/unison/unison-2.53.3.ebuild | 99 ++++++++++++++++++++++++++++++++++++ 2 files changed, 100 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=432e263820f632c52366c900519e793afe74e2be commit 432e263820f632c52366c900519e793afe74e2be Author: Maciej Barć <xgqt@gentoo.org> AuthorDate: 2024-06-21 12:28:35 +0000 Commit: Maciej Barć <xgqt@gentoo.org> CommitDate: 2024-06-21 12:28:35 +0000 net-misc/unison: drop old 2.51.5-r1 Closes: https://bugs.gentoo.org/850343 Closes: https://bugs.gentoo.org/769341 Signed-off-by: Maciej Barć <xgqt@gentoo.org> net-misc/unison/Manifest | 1 - net-misc/unison/unison-2.51.5-r1.ebuild | 146 -------------------------------- 2 files changed, 147 deletions(-)
