Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 768120 - dev-python/feedparser-5.2.1-r1 (and originally also net-mail/rss2email-3.12.2) have broken python3_9 support
Summary: dev-python/feedparser-5.2.1-r1 (and originally also net-mail/rss2email-3.12.2...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL: https://github.com/rss2email/rss2emai...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-31 22:45 UTC by Sebastian Pipping
Modified: 2021-09-26 00:09 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Pipping gentoo-dev 2021-01-31 22:45:15 UTC
Hi!

Related upstream bug report at https://github.com/rss2email/rss2email/issues/163 .

I'll drop drop Python 3.9 from net-mail/rss2email myself in a minute.
How should be go forward with dev-python/feedparser-5.2.1-r1?

Best, Sebastian
Comment 1 Larry the Git Cow gentoo-dev 2021-01-31 22:50:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c0d5e368069a9afaa71b53da8f448fcac116b1b

commit 0c0d5e368069a9afaa71b53da8f448fcac116b1b
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2021-01-31 22:47:59 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2021-01-31 22:47:59 +0000

    net-mail/rss2email: Drop broken support for py39
    
    Bug: https://bugs.gentoo.org/768120
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    RepoMan-Options: --force

 .../{rss2email-3.12.2.ebuild => rss2email-3.12.2-r1.ebuild}         | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 2 Ionen Wolkens gentoo-dev 2021-01-31 23:02:23 UTC
Kind of forgot about this, I've been using rss2email with py3.9 for a while myself in my local overlay.

Removed the feedparser version restriction, and added a dep on:
dev-python/sgmllib3k[${PYTHON_USEDEP}]

Plus backport of
https://github.com/rss2email/rss2email/commit/726cf8284c8997aa196781944d8a2af9f2487779

Haven't tested much, so unsure how suitable for ::gentoo, I guess just waiting for a new release would also be reasonable.
Comment 3 Sebastian Pipping gentoo-dev 2021-01-31 23:22:43 UTC
(In reply to Ionen Wolkens from comment #2)
> [..] and added a dep on:
> dev-python/sgmllib3k[${PYTHON_USEDEP}]

Could you elaborate on the extra dependency — what's the idea, what's it for?
Comment 4 Ionen Wolkens gentoo-dev 2021-01-31 23:28:22 UTC
Oh I see, that was my mistake (as I said, didn't test much). I was originally trying feedparser-5 because of the blocker which didn't depend on sgmllib3k.

It's a dep of feedparser6 and it's already there, so ignore this dep.

Seem rss2email only needs a trivial fix then.
Comment 5 Sebastian Pipping gentoo-dev 2021-01-31 23:33:14 UTC
(In reply to Ionen Wolkens from comment #4)
> Oh I see, that was my mistake (as I said, didn't test much). I was
> originally trying feedparser-5 because of the blocker which didn't depend on
> sgmllib3k.
> 
> It's a dep of feedparser6 and it's already there, so ignore this dep.
> 
> Seem rss2email only needs a trivial fix then.

I see, thanks for clarification.
Comment 6 Christopher Head 2021-06-05 01:57:19 UTC
The ticket pointed to in the URL field is closed. The title of this ticket suggests that rss2email is no longer problematic. However, no rss2email ebuilds in ::gentoo list PYTHON_COMPAT=python3_9, so I am not sure why it claims to be fixed for r2e?
Comment 7 Ionen Wolkens gentoo-dev 2021-06-05 02:14:16 UTC
The upstream issues wrt tests is still open:
https://github.com/rss2email/rss2email/issues/178

However, I've been using it with 3.9 for a long time and it doesn't need workarounds anymore. Personally think it'd be fair to have 3.9 (at least) in ~arch.
Comment 8 Sebastian Pipping gentoo-dev 2021-06-05 12:53:07 UTC
(In reply to Ionen Wolkens from comment #7)
> The upstream issues wrt tests is still open:
> https://github.com/rss2email/rss2email/issues/178

Yes, good find, I was about to post it.
I think the URL field here can hold multiple URLs, let me try.


> However, I've been using it with 3.9 for a long time and it doesn't need
> workarounds anymore. Personally think it'd be fair to have 3.9 (at least) in
> ~arch.

I'm a bit torn between supporting that idea and raising concerns about it, also due to https://github.com/rss2email/rss2email/pull/181/files#diff-86d7b95911fb37a51f57d39f3ab50678bdf8f85d9d6a1853bf05eb75729e8461R413 .
Comment 9 Ionen Wolkens gentoo-dev 2021-06-05 13:23:22 UTC
fwiw can use see also, it's more picky about what urls it allows though.

wrt PR, I admit didn't try the affected file:/ feeds
Comment 10 Larry the Git Cow gentoo-dev 2021-09-17 19:38:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=afb290f53884bc10c6558c87d0ac514d127ad02b

commit afb290f53884bc10c6558c87d0ac514d127ad02b
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2021-09-17 19:36:07 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2021-09-17 19:36:12 +0000

    net-mail/rss2email: enable py3.9, py3.10
    
    All issues were fixed in feedparser 6.0.5, as changed
    in upstream, so bump the minimal version to address this.
    All tests passed successfully.
    
    Closes: https://bugs.gentoo.org/768120
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 net-mail/rss2email/rss2email-3.13.1.ebuild | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)