Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767256 - dev-python/braintree: missing tests, added python@ without permission
Summary: dev-python/braintree: missing tests, added python@ without permission
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 784263
  Show dependency tree
 
Reported: 2021-01-26 09:57 UTC by Michał Górny
Modified: 2021-09-05 22:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-26 09:57:11 UTC
commit 03ccc3cbd869b898ea11e85dc69f4ca07da8ea8b
Author:     Cédric Krier <cedk@gentoo.org>
AuthorDate: 2020-11-08 22:40:43 +0100
Commit:     Cédric Krier <cedk@gentoo.org>
CommitDate: 2020-11-08 22:41:09 +0100

    dev-python/braintree: new ebuild
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Cédric Krier <cedk@gentoo.org>


The ebuild is missing tests while upstream's repository clearly has tests.

cedk is not on the Python team.  The package doesn't mean quality requirements set by the Python team.  Nevertheless, he has dumped the package on Python team.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-06 07:53:43 UTC
Ping.
Comment 2 Cédric Krier gentoo-dev 2021-05-06 08:11:41 UTC
I do not understand what you are expecting from me?
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-06 08:41:10 UTC
Enabling tests in the package.  Bumping it.  Doing what maintainer is supposed to do.
Comment 4 Cédric Krier gentoo-dev 2021-05-06 09:03:04 UTC
But there is no test in the package.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-06 09:06:40 UTC
And that large 'tests' directory is a misnomer, right?
Comment 6 Cédric Krier gentoo-dev 2021-05-06 09:13:31 UTC
There is no tests directory in the package.
Comment 7 David Seifert gentoo-dev 2021-05-06 09:18:47 UTC
You might have not looked at the upstream repo:

https://github.com/braintree/braintree_python/blob/master/tests
Comment 8 Cédric Krier gentoo-dev 2021-05-06 10:12:09 UTC
I can not run tests that are not in the package.
And I do not want to maintain my own packaging.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-06 11:14:23 UTC
The GitHub repository provides archives that you can use.
Comment 10 Cédric Krier gentoo-dev 2021-05-06 12:20:30 UTC
Those archive are not stable. It is better to use the official packages distributed on PyPI.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-06 13:36:40 UTC
No, they are not.  Tests are very important.

Also, please do not repeatedly close bugs where QA is involved.
Comment 12 David Seifert gentoo-dev 2021-05-06 14:14:29 UTC
(In reply to Cédric Krier from comment #10)
> Those archive are not stable. It is better to use the official packages
> distributed on PyPI.

If you close this issue one more time, we will push for a ban from QA. Do not close QA issues.
Comment 13 Cédric Krier gentoo-dev 2021-05-06 14:29:02 UTC
(In reply to David Seifert from comment #12)
> (In reply to Cédric Krier from comment #10)
> > Those archive are not stable. It is better to use the official packages
> > distributed on PyPI.
> 
> If you close this issue one more time, we will push for a ban from QA. Do
> not close QA issues.

Please do not assign to me issue that I'm not allowed to close them.
Comment 14 David Seifert gentoo-dev 2021-05-06 14:39:19 UTC
(In reply to Cédric Krier from comment #13)
> (In reply to David Seifert from comment #12)
> > (In reply to Cédric Krier from comment #10)
> > > Those archive are not stable. It is better to use the official packages
> > > distributed on PyPI.
> > 
> > If you close this issue one more time, we will push for a ban from QA. Do
> > not close QA issues.
> 
> Please do not assign to me issue that I'm not allowed to close them.

Sure, I will just last-rite it, seeing it has no revdeps, and we generally have a policy of not packaging random python libraries.
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-07-16 06:24:10 UTC
Ping.  What's the status here?  Upstream has made another release.
Comment 16 Cédric Krier gentoo-dev 2021-07-28 16:20:27 UTC
Upstream confirmed that tests are not included because they can not pass with released code because it runs against the development API server: https://github.com/braintree/braintree_python/pull/136
Comment 17 Larry the Git Cow gentoo-dev 2021-09-05 22:02:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46b6136c9a682e4d6a80b4b44f67cd1cf1f6eccd

commit 46b6136c9a682e4d6a80b4b44f67cd1cf1f6eccd
Author:     Cédric Krier <cedk@gentoo.org>
AuthorDate: 2021-09-05 22:02:00 +0000
Commit:     Cédric Krier <cedk@gentoo.org>
CommitDate: 2021-09-05 22:02:22 +0000

    dev-python/braintree: version bumps
    
    Closes: https://bugs.gentoo.org/802567
    Closes: https://bugs.gentoo.org/767256
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Cédric Krier <cedk@gentoo.org>

 dev-python/braintree/Manifest                                         | 2 +-
 .../braintree/{braintree-4.9.0.ebuild => braintree-4.12.0.ebuild}     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)