Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762796 - dev-vcs/git[gnome-keyring]: ignores CC, CFLAGS, PKG_CONFIG
Summary: dev-vcs/git[gnome-keyring]: ignores CC, CFLAGS, PKG_CONFIG
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2020-12-31 14:55 UTC by David Michael
Modified: 2020-12-31 15:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-12-31 14:55:52 UTC
https://github.com/git/git/blob/master/contrib/credential/libsecret/Makefile#L4-L7

Reproducible: Always

Steps to Reproduce:
1. emerge -1v dev-vcs/git

Actual Results:  
Package libsecret-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsecret-1.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libsecret-1', required by 'virtual:world', not found
Package libsecret-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsecret-1.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libsecret-1', required by 'virtual:world', not found
gcc -g -O2 -Wall   -o git-credential-libsecret.o -c git-credential-libsecret.c
git-credential-libsecret.c:29:10: fatal error: glib.h: No such file or directory
   29 | #include <glib.h>
      |          ^~~~~~~~
compilation terminated.
make: *** [Makefile:19: git-credential-libsecret.o] Error 1
 * ERROR: dev-vcs/git-2.26.2::gentoo failed (compile phase):
 *   emake failed

Expected Results:  
>>> dev-vcs/git-2.26.2 merged.

--- dev-vcs/git/git-2.26.2.ebuild
+++ dev-vcs/git/git-2.26.2.ebuild
@@ -55,7 +55,10 @@
 
 # Common to both DEPEND and RDEPEND
 DEPEND="
-	gnome-keyring? ( app-crypt/libsecret )
+	gnome-keyring? (
+		app-crypt/libsecret
+		dev-libs/glib:2
+	)
 	!libressl? ( dev-libs/openssl:0= )
 	libressl? ( dev-libs/libressl:= )
 	sys-libs/zlib
@@ -372,7 +375,7 @@
 
 	if use gnome-keyring ; then
 		pushd contrib/credential/libsecret &>/dev/null || die
-		git_emake || die "emake git-credential-libsecret failed"
+		git_emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}" PKG_CONFIG="$(tc-getPKG_CONFIG)"
 		popd &>/dev/null || die
 	fi
Comment 1 Ionen Wolkens 2020-12-31 15:12:44 UTC
Did a quick try to confirm:
    make: gcc: No such file or directory