Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759352 - dev-lang/php-7.2.34 - ext/intl/collator/collator_sort.c:349:26: error: ‘TRUE’ undeclared
Summary: dev-lang/php-7.2.34 - ext/intl/collator/collator_sort.c:349:26: error: ‘TRUE’...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: icu-68.1
  Show dependency tree
 
Reported: 2020-12-10 15:16 UTC by Brian Evans (RETIRED)
Modified: 2020-12-20 22:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,338.91 KB, text/plain)
2020-12-10 15:18 UTC, Brian Evans (RETIRED)
Details
php-7.2.34-icu-68.1.patch (php-7.2.34-icu-68.1.patch,5.54 KB, patch)
2020-12-10 18:31 UTC, Attila Tóth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2020-12-10 15:16:21 UTC
During a rebuild for icu-68:

/bin/sh /var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/libtool --silent --preserve-dup-deps --mode=compile x86_64-pc-linux-gnu-gcc  -Wno-write-strings -D__STDC_LIMIT_MACROS -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -Iext/intl/ -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/ -DPHP_ATOM_INC -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/include -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/main -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/date/lib -I/usr/include/libxml2 -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/mbstring/libmbfl -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/mbstring/libmbfl/mbfl -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/TSRM -I/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/Zend    -I/usr/include -O2 -pipe -march=core2 -mtune=sandybridge -fno-common -fvisibility=hidden -DZEND_SIGNALS   -c /var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_convert.c -o ext/intl/collator/collator_convert.lo
/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_sort.c: In function ‘zif_collator_sort’:
/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_sort.c:349:26: error: ‘TRUE’ undeclared (first use in this function)
  349 |  collator_sort_internal( TRUE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
      |                          ^~~~
/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_sort.c:349:26: note: each undeclared identifier is reported only once for each function it appears in
/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_sort.c: In function ‘zif_collator_asort’:
/var/tmp/portage/dev-lang/php-7.2.34/work/sapis-build/cli/ext/intl/collator/collator_sort.c:543:26: error: ‘FALSE’ undeclared (first use in this function)
  543 |  collator_sort_internal( FALSE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
      |                          ^~~~~
Comment 1 Brian Evans (RETIRED) gentoo-dev 2020-12-10 15:18:37 UTC
Created attachment 677581 [details]
build.log
Comment 2 Brian Evans (RETIRED) gentoo-dev 2020-12-10 15:20:13 UTC
Portage 3.0.12 (python 3.7.9-final-0, default/linux/amd64/17.1, gcc-10.2.0, glibc-2.32-r5, 5.4.48-ck x86_64)
=================================================================
System uname: Linux-5.4.48-ck-x86_64-Intel_Xeon_E3-12xx_v2_-Ivy_Bridge,_IBRS-with-gentoo-2.7
KiB Mem:     8156024 total,   1742976 free
KiB Swap:    1048572 total,   1048052 free
Head commit of repository gentoo: 742c96f8422f8b3fa833a83efce4af2eed7cf2f1

Head commit of repository grknight: 75ea1f3494db89919cd925fdc94dc17ad6887be7

sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          3.7.9::gentoo, 3.8.6::gentoo, 3.9.0::gentoo
dev-util/cmake:           3.19.1::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.69-r5::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            10.2.0-r3::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r5::gentoo
Repositories:

gentoo
    location: /var/repo/portage
    sync-type: git
    sync-uri: git+ssh://git@git.gentoo.org/repo/gentoo.git
    sync-user: grknight
    priority: -1000
    sync-git-pull-extra-opts: -4

crossdev
    location: /var/repo/crossdev
    masters: gentoo

local
    location: /var/repo/local
    masters: gentoo

grknight
    location: /var/repo/grknight
    sync-type: git
    sync-uri: git+ssh://git@github.com:grknight/gentoo.git
    sync-user: grknight
    masters: gentoo
    priority: 60

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=core2 -mtune=sandybridge -fno-common"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /et
c/php/apache2-php7.3/ext-active/ /etc/php/apache2-php7.4/ext-active/ /etc/php/apache2-php8.0/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cgi-
php7.3/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/php/cli-php7.3/ext-active/ /et
c/php/cli-php7.4/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=core2 -mtune=sandybridge"
DISTDIR="/var/lib/portage/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=y --keep-going --autounmask-write=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACH
E_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-s
ync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign strict
unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/var/lib/portage/distfiles/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readabl
e --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl adns amd64 berkdb bzip2 cli crypt dri elogind fortran gcrypt gdbm iconv ipv6 libglvnd libtirpc multilib mysql ncurses nls nptl openmp pam pcr
e readline seccomp split-usr ssl unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" CPU_FLAGS_X86="mmx mmxext sse sse2" CURL_SSL="gnutls" ELIBC="
glibc" GRUB_PLATFORMS="pc" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-US" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATI
ON="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4 php8-0" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="p
ython3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="modesetting"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS,
 PORTAGE_RSYNC_EXTRA_OPTS
Comment 3 Attila Tóth 2020-12-10 18:31:18 UTC
Created attachment 677674 [details, diff]
php-7.2.34-icu-68.1.patch

Proposed patch until there is an official solution.
Comment 4 Andreas Sturmlechner gentoo-dev 2020-12-20 18:05:21 UTC
So, >=7.3.25 are fine?
Comment 5 Larry the Git Cow gentoo-dev 2020-12-20 22:11:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b878520dc290dfc30177193882ac622ad99c799

commit 7b878520dc290dfc30177193882ac622ad99c799
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-12-20 22:11:03 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-12-20 22:11:44 +0000

    dev-lang/php: allow building against >=dev-lilbs/icu-68.1
    
    Upstream's official solution is to restore previous ICU behavior using
    -DU_DEFINE_FALSE_AND_TRUE=1 [Link 1].
    
    But this patch alone is not enough for PHP 7.2. However, PHP 7.2 has reached EOL
    so we will do same like upstream but via global {C,CXX}FLAGS.
    
    Link 1: https://github.com/php/php-src/commit/8eaaabdd58a395853d3658418622ee24635cb871
    Closes: https://bugs.gentoo.org/759352
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/php/php-7.2.34.ebuild | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)