Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758062 - media-video/vlc-3.0.11.1 USE="srt" fails to build with net-libs/srt-1.4.2
Summary: media-video/vlc-3.0.11.1 USE="srt" fails to build with net-libs/srt-1.4.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL: https://github.com/Haivision/srt/pull...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 761547
  Show dependency tree
 
Reported: 2020-12-02 16:00 UTC by Attila Tóth
Modified: 2020-12-25 02:35 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vlc-3.0.11.1_srt-1.4.2.patch (vlc-3.0.11.1_srt-1.4.2.patch,1.21 KB, patch)
2020-12-02 16:03 UTC, Attila Tóth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Tóth 2020-12-02 16:00:35 UTC
access/srt.c: In function ‘srt_schedule_reconnect’:
access/srt.c:144:5: warning: ‘srt_socket’ is deprecated [-Wdeprecated-declarations]
  144 |     p_sys->sock = srt_socket( res->ai_family, SOCK_DGRAM, 0 );
      |     ^~~~~
In file included from access/srt.c:38:
/usr/include/srt/srt.h:754:41: note: declared here
  754 | SRT_ATR_DEPRECATED_PX SRT_API SRTSOCKET srt_socket(int, int, int) SRT_ATR_DEPRECATED;
      |                                         ^~~~~~~~~~
access/srt.c:168:37: error: ‘SRTO_TSBPDDELAY’ undeclared (first use in this function); did you mean ‘SRTO_TSBPDMODE’?
  168 |     srt_setsockopt( p_sys->sock, 0, SRTO_TSBPDDELAY,
      |                                     ^~~~~~~~~~~~~~~
      |                                     SRTO_TSBPDMODE
access/srt.c:168:37: note: each undeclared identifier is reported only once for each function it appears in

access_output/srt.c: In function ‘srt_schedule_reconnect’:
access_output/srt.c:141:5: warning: ‘srt_socket’ is deprecated [-Wdeprecated-declarations]
  141 |     p_sys->sock = srt_socket( res->ai_family, SOCK_DGRAM, 0 );
      |     ^~~~~
In file included from access_output/srt.c:37:
/usr/include/srt/srt.h:754:41: note: declared here
  754 | SRT_ATR_DEPRECATED_PX SRT_API SRTSOCKET srt_socket(int, int, int) SRT_ATR_DEPRECATED;
      |                                         ^~~~~~~~~~
access_output/srt.c:165:37: error: ‘SRTO_TSBPDDELAY’ undeclared (first use in this function); did you mean ‘SRTO_TSBPDMODE’?
  165 |     srt_setsockopt( p_sys->sock, 0, SRTO_TSBPDDELAY,
      |                                     ^~~~~~~~~~~~~~~
      |                                     SRTO_TSBPDMODE
access_output/srt.c:165:37: note: each undeclared identifier is reported only once for each function it appears in

Reproducible: Always
Comment 1 Attila Tóth 2020-12-02 16:03:48 UTC
Created attachment 676300 [details, diff]
vlc-3.0.11.1_srt-1.4.2.patch

Suggested trivial patch to solve this breakage.

Note that srt_socket is about to be replaced with srt_create_socket with no apparent arguments (ipv4 vs ipv6 will be determined during srt_connect or srt_bind from now on - as srt documentation tells us). I don't address this trivial change in this patch to concentrate only on the exact problem. The use of srt_socket only brings up deprecated warning.
Comment 2 Luíza Utsch 2020-12-13 16:11:17 UTC
Can confirm the issue on ~amd64, provided patch fixed it.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-25 02:35:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e014d41451b0d3fc3f9037d37703a20de1d197e3

commit e014d41451b0d3fc3f9037d37703a20de1d197e3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-12-25 02:26:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-12-25 02:35:51 +0000

    media-video/vlc: fix USE=srt with >=net-libs/srt-1.4.2
    
    Thanks-to: Attila Tóth <atoth@atoth.sote.hu>
    Closes: https://bugs.gentoo.org/758062
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/vlc/files/vlc-3.0.11.1-srt-1.4.2.patch |  25 ++
 media-video/vlc/vlc-3.0.11.1-r1.ebuild             | 492 +++++++++++++++++++++
 ...0.11.1-r100.ebuild => vlc-3.0.11.1-r101.ebuild} |   3 +-
 3 files changed, 519 insertions(+), 1 deletion(-)