Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 757282 - dev-db/firebird-3.0.7 version bump
Summary: dev-db/firebird-3.0.7 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-27 22:09 UTC by Alessandro Barbieri
Modified: 2022-12-03 07:50 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
3.0.7 ebuild (firebird-3.0.7.33374.0.ebuild,6.60 KB, text/plain)
2021-08-13 09:41 UTC, Thomas J. Moore
Details
4.0 ebuild (firebird-4.0.0.2496.0.ebuild,6.67 KB, text/plain)
2021-08-13 09:42 UTC, Thomas J. Moore
Details
patch used by 4.0 ebuild to fix extauth compile (extauth.patch,569 bytes, patch)
2021-08-13 09:48 UTC, Thomas J. Moore
Details | Diff
4.0 ebuild (firebird-4.0.0.2496.0.ebuild,6.67 KB, text/plain)
2021-08-16 02:53 UTC, Thomas J. Moore
Details
patch used by 4.0 ebuild to fix extauth compile (extauth.patch,699 bytes, patch)
2021-08-17 06:10 UTC, Thomas J. Moore
Details | Diff
dev-db/firebird that respects C(XX)FLAGS (firebird-3.0.7.33374.0.ebuild,6.57 KB, text/plain)
2021-08-19 17:42 UTC, Thomas J. Moore
Details
patch required by attachment #734299 (firebird-3.0.7-comp_flags.patch,1.73 KB, patch)
2021-08-19 17:44 UTC, Thomas J. Moore
Details | Diff
dev-db/firebird that respects C(XX)FLAGS (firebird-4.0.0.2496.0.ebuild,6.72 KB, text/plain)
2021-08-19 17:44 UTC, Thomas J. Moore
Details
patch required by attachment #734305 (firebird-4.0.0-comp_flags.patch,2.48 KB, patch)
2021-08-19 17:46 UTC, Thomas J. Moore
Details | Diff
2nd patch required by attachment #734305 (firebird-4.0.0-extauth.patch,875 bytes, patch)
2021-08-19 17:46 UTC, Thomas J. Moore
Details | Diff
acct-user/firebird (firebird-0.ebuild,422 bytes, text/plain)
2021-08-19 17:52 UTC, Thomas J. Moore
Details
acct-group/firebird (firebird-0.ebuild,194 bytes, text/plain)
2021-08-19 17:53 UTC, Thomas J. Moore
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2020-11-27 22:09:16 UTC
https://firebirdsql.org/en/firebird-3-0-7/

maybe bumping will help fixing some issues
Comment 1 Thomas J. Moore 2021-08-13 09:41:52 UTC
Created attachment 732559 [details]
3.0.7 ebuild
Comment 2 Thomas J. Moore 2021-08-13 09:42:34 UTC
Created attachment 732561 [details]
4.0 ebuild
Comment 3 Thomas J. Moore 2021-08-13 09:44:41 UTC
I have successfully tested 3.0.7 and 4.0.0 on my system, but I don't use firebird very much.  The main issues wrt the 3.0.4 ebuild are that both patches are obsolete.  The system btyacc no longer works as of 3.0.5; the bundled version must be used.  Otherwise, you get compile errors in 3.0.5-7 and table overflow in 4.0.0, at least.  The cloop patch, even when adjusted to the new makefile, does nothing.  I have attached my working ebuilds.  Note that I also dropped the ibase-6 docs and replaced them with more recent versions.

I would not recommend 4.0 for now, as it is a major version bump and therefore no longer supports version 3 database files (including the security database).  Maybe if this were slotted, or the version 3 engine were added as a plugin.
Comment 4 Thomas J. Moore 2021-08-13 09:48:35 UTC
Created attachment 732563 [details, diff]
patch used by 4.0 ebuild to fix extauth compile
Comment 5 Thomas J. Moore 2021-08-16 02:53:09 UTC
Created attachment 733183 [details]
4.0 ebuild

Compiling ODBC driver didn't work w/ my previous 4.0 ebuild
Comment 6 dsar 2021-08-16 23:17:41 UTC
Hi Thomas, thank for your work.

Unfortunately it doesn't build here:

c++ -std=c++11 -pthread -I/var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/include -I/var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/src/include -fPIC -DLTC_PTHREAD -DUSE_LTM -DLTM_DESC -c ExtAuth.cpp -o /var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/temp/Release/examples/extauth/ExtAuth.o
can't format message 17:10 -- message file /usr/share/firebird/msg/firebird.msg not found
Server version:
Firebird/Linux/AMD/Intel/x64 (access method), version "LI-V4.0.0.2496 Firebird 4.0"
on disk structure version 13.0
c++ -pthread -L/var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/lib -Wl,-rpath,'$ORIGIN/../lib'  /var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/temp/Release/examples/extauth/keygen.o /var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/temp/Release/examples/extauth/TcWrapper.o -o /var/tmp/portage/dev-db/firebird-4.0.0.2496.0/work/Firebird-4.0.0.2496-0/gen/Release/firebird/examples/prebuilt/bin/fbSampleExtAuthKeygen -lfbclient -ltomcrypt -ltommath
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lfbclient
collect2: error: ld returned 1 exit status
Comment 7 Thomas J. Moore 2021-08-17 06:10:58 UTC
Created attachment 733433 [details, diff]
patch used by 4.0 ebuild to fix extauth compile

Previous patch was insufficient if no system libfbclient at build time (i.e., some version of firebird already intalled).
Comment 8 Thomas J. Moore 2021-08-17 06:38:58 UTC
(In reply to Diego Sardina from comment #6)
> can't format message 17:10 -- message file
> /usr/share/firebird/msg/firebird.msg not found

Don't worry about these errors:  17:3 and 17:10 are just informational messages.

> ld: cannot find -lfbclient

Try my updated extauth.patch.
Comment 9 dsar 2021-08-17 15:51:02 UTC
It's ok now :-)

I also tried the ebuild for 3.0.7 and it builds good (but I didn't test it since I moved to Firebird 4). However the 3.0.4 version currently in the portage should be removed as soon as possible because there are some crashes that corrupt the database.

Both ebuild should be updated in some places, for example these lines:

append-cflags -fno-sized-deallocation -fno-delete-null-pointer-checks
append-cxxflags -fno-sized-deallocation -fno-delete-null-pointer-checks -std=c++11

are not needed anymore.

I see there is acct-group/firebird but it doesn't seem actually used
Comment 10 Thomas J. Moore 2021-08-19 17:41:38 UTC
(In reply to Diego Sardina from comment #9)
> Both ebuild should be updated in some places

Well, I didn't want to do much more than get them to work, since I don't actually use firebird that much (it's just one of four databases I'm trying to support with my application).

I went ahead and removed the lines you mentioned, though, along with the filter-flags commands.  None of that did anything, anyway, since firebird overrides CXXFLAGS.  I think that the ebuild in the repository maintained by William L. Thompson, Jr (https://bugs.gentoo.org/81588#c5) should be used, instead of mine, but he didn't post it here, so I did.  I have not actually looked at his ebuild other than a glance, but it looks like he did most of the work needed to make CXXFLAGS work right, at least.  I've gone ahead and done something independently to achieve a similar effect:  at least my CFLAGS and CXXFLAGS are now being used by all compiles, in addition to/overriding the ones Firebird insists on using.  Of course that's just inviting new bug reports on obscure gcc flags causing bugs, but I'll let someone else deal with it.  I guess this fixes bug #726856.  I am not a gentoo maintainer and in fact am trying to get away from gentoo, permanently (but have been for years, now, so I'm not sure I ever will).  I also, as I said, am not all that interested in Firebird.

> I see there is acct-group/firebird but it doesn't seem actually used

The last keyword in the user creation is firebird's primary group, firebird.  It's also used in the install portion; look for "-g firebird".  In any case, I converted to using acct.eclass, and added the acct-user/firebird and acct-group/firebird ebuilds.  I guess this also fixes bug #781275.  I also moved firebird's home dir to /var/lib, since writable dirs shouldn't really be in /usr.

Rather than obsolete my previous proposed ebuilds, I will add them and their associated patches (and the new acct ebuilds) separately.

I should also have noted that both sets of ebuilds of mine fix bug #648956, at least as I interpreted it.

Now, if only someone other than me would address #81588, that would be nice.  I have a working ebuild, but I didn't put much effort into it.
Comment 11 Thomas J. Moore 2021-08-19 17:42:53 UTC
Created attachment 734299 [details]
dev-db/firebird that respects C(XX)FLAGS
Comment 12 Thomas J. Moore 2021-08-19 17:44:16 UTC
Created attachment 734302 [details, diff]
patch required by attachment #734299 [details]
Comment 13 Thomas J. Moore 2021-08-19 17:44:51 UTC
Created attachment 734305 [details]
dev-db/firebird that respects C(XX)FLAGS
Comment 14 Thomas J. Moore 2021-08-19 17:46:01 UTC
Created attachment 734308 [details, diff]
patch required by attachment #734305 [details]
Comment 15 Thomas J. Moore 2021-08-19 17:46:55 UTC
Created attachment 734311 [details, diff]
2nd patch required by attachment #734305 [details]
Comment 16 Thomas J. Moore 2021-08-19 17:52:59 UTC
Created attachment 734314 [details]
acct-user/firebird
Comment 17 Thomas J. Moore 2021-08-19 17:53:34 UTC
Created attachment 734317 [details]
acct-group/firebird
Comment 18 Larry the Git Cow gentoo-dev 2022-12-03 06:06:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59693b49cfd41df01375b0e4bb8c588e654ff2f3

commit 59693b49cfd41df01375b0e4bb8c588e654ff2f3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-03 06:00:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-03 06:06:10 +0000

    dev-db/firebird: add 3.0.10.33601.0
    
    Closes: https://bugs.gentoo.org/757282
    Closes: https://bugs.gentoo.org/828067
    Closes: https://bugs.gentoo.org/881327
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/firebird/Manifest                           |  1 +
 ...ird-3.0.10.33601.0-configure-autoconf2.72.patch | 21 +++++
 ...firebird-3.0.10.33601.0-configure-clang16.patch | 48 +++++++++++
 .../files/firebird-3.0.10.33601.0-unbundle.patch   | 97 ++++++++++++++++++++++
 ....0-r3.ebuild => firebird-3.0.10.33601.0.ebuild} | 21 +++--
 5 files changed, 181 insertions(+), 7 deletions(-)
Comment 19 Larry the Git Cow gentoo-dev 2022-12-03 07:50:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cbddf475ce279474be6138873223f0e751af6183

commit cbddf475ce279474be6138873223f0e751af6183
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-03 07:16:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-03 07:47:51 +0000

    dev-db/firebird: incorporate suggestions to 3.0.10
    
    Includes Thomas J. Moore's suggestions & patches.
    
    Bug: https://bugs.gentoo.org/757282
    Closes: https://bugs.gentoo.org/648956
    Closes: https://bugs.gentoo.org/726856
    Thanks-to: Thomas J. Moore <darktjm@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/firebird/Manifest                           | 15 ++++++
 .../files/firebird-3.0.10.33601.0-flags.patch      | 25 +++++++++
 ....0.ebuild => firebird-3.0.10.33601.0-r1.ebuild} | 63 ++++++++++++----------
 3 files changed, 76 insertions(+), 27 deletions(-)