Related to https://bugs.gentoo.org/show_bug.cgi?id=werror and https://bugs.gentoo.org/show_bug.cgi?id=754120 This would avoid having to pass that parameter to all meson ebuilds, while it's a policy to disable -Werror ( https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#-werror-compiler-flag-not-removed ). Reproducible: Always
I don't think werror is a valid meson option for all projects.
Ok, I see it is documented here: https://mesonbuild.com/Builtin-options.html#core-options The same page says it defaults to false. If individual projects override this, I think it is more appropriate for individual ebuilds to force it off again.
(In reply to Mike Gilbert from comment #2) > Ok, I see it is documented here: > > https://mesonbuild.com/Builtin-options.html#core-options > > The same page says it defaults to false. If individual projects override > this, I think it is more appropriate for individual ebuilds to force it off > again. Well projects probably use it for development but why would we risk keeping -Werror (specially a global one) in gentoo and so break stability?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f7408ada0c4655827e7bea46c57d7af1b9004433 commit f7408ada0c4655827e7bea46c57d7af1b9004433 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-04-19 18:07:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-04-25 15:57:56 +0000 meson.eclass: disable werror It's Gentoo policy to disable Werror where possible and this is a builtin Meson option, so let's use it, to save needing to add this all the time in ebuilds. Closes: https://bugs.gentoo.org/754279 Signed-off-by: Sam James <sam@gentoo.org> eclass/meson.eclass | 4 ++++ 1 file changed, 4 insertions(+)
