Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753677 - sys-block/parted-3.3-r2 fails test t0251-gpt-unicode
Summary: sys-block/parted-3.3-r2 fails test t0251-gpt-unicode
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michał Górny
URL: https://debbugs.gnu.org/cgi/bugreport...
Whiteboard:
Keywords: PATCH, TESTFAILURE, UPSTREAM
Depends on:
Blocks:
 
Reported: 2020-11-09 10:30 UTC by tka
Modified: 2024-05-12 03:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,21.07 KB, application/x-xz)
2020-11-09 10:32 UTC, tka
Details
test-suite.log (test-suite.log,161.52 KB, text/plain)
2020-11-09 10:32 UTC, tka
Details
0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch (0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch,2.07 KB, patch)
2023-01-25 16:52 UTC, kfm
Details | Diff
0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch (r1) (0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch,2.07 KB, patch)
2023-01-25 16:59 UTC, kfm
Details | Diff
0001-Use-any-available-UTF-8-locale-in-t0251-skip-if-none.patch (0001-Use-any-available-UTF-8-locale-in-t0251-skip-if-none.patch,2.13 KB, patch)
2023-01-29 00:54 UTC, kfm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tka 2020-11-09 10:30:59 UTC
+ dd if=loop-file bs=1 skip=2104 count=10
+ od -An -tx1
+ echo ' 66 00 6f 00 6f 00 24 1d 00 00'
+ compare exp out
+ compare_dev_null_ exp out
+ test 2 = 2
+ test xexp = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ exp out
+ diff -u exp out
--- exp 2020-11-09 10:20:12.768299227 +0000
+++ out 2020-11-09 10:20:12.768299227 +0000
@@ -1 +1 @@
- 66 00 6f 00 6f 00 24 1d 00 00
+ 66 00 6f 00 6f 00 6d 00 61 00
+ fail=1
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ cleanup_fn_
+ :
+ cleanup_final_
+ scsi_debug_cleanup_
+ test -n ''
+ rm -fr /var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests/scsi_debug.lock
+ cd /var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests
+ chmod -R u+rwx /var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests/gt-t0251-gpt-unicode.sh.paiR
+ rm -rf /var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests/gt-t0251-gpt-unicode.sh.paiR
+ exit 1
FAIL t0251-gpt-unicode.sh (exit status: 1)



============================================================================
Testsuite summary for GNU parted 3.3
============================================================================
# TOTAL: 85
# PASS:  42
# SKIP:  42
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to bug-parted@gnu.org
============================================================================
make[5]: *** [Makefile:1941: test-suite.log] Error 1
make[5]: Leaving directory '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests'
make[4]: *** [Makefile:2049: check-TESTS] Error 2
make[4]: Leaving directory '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests'
make[3]: *** [Makefile:2116: check-am] Error 2
make[3]: Leaving directory '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3/tests'
make[2]: *** [Makefile:1568: check-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3'
make[1]: *** [Makefile:2046: ss-1024] Error 2
make[1]: Leaving directory '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3'
make: *** [Makefile:2052: check-other-sector_sizes] Error 2
 * ERROR: sys-block/parted-3.3-r2::gentoo failed (test phase):
 *   Make check failed. See above for details.
 * 
 * Call stack:
 *            ebuild.sh, line  125:  Called src_test
 *          environment, line 1592:  Called default
 *   phase-functions.sh, line  855:  Called default_src_test
 *   phase-functions.sh, line  884:  Called __eapi0_src_test
 *     phase-helpers.sh, line  778:  Called die
 * The specific snippet of code:
 *              $emake_cmd ${internal_opts} check || \
 *                      die "Make check failed. See above for details."
 * 
 * If you need support, post the output of `emerge --info '=sys-block/parted-3.3-r2::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-block/parted-3.3-r2::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/sys-block/parted-3.3-r2/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-block/parted-3.3-r2/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3'
 * S: '/var/tmp/portage/sys-block/parted-3.3-r2/work/parted-3.3'


Reproducible: Always
Comment 1 tka 2020-11-09 10:32:03 UTC
Created attachment 670574 [details]
build.log.xz

# emerge -pqv '=sys-block/parted-3.3-r2::gentoo'
[ebuild     U ] sys-block/parted-3.3-r2 [3.3-r1] USE="debug readline -device-mapper -nls (-selinux) (-static-libs%)" 

# emerge --info '=sys-block/parted-3.3-r2::gentoo'
Portage 3.0.9 (python 3.7.9-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-10.2.0, glibc-2.32-r2, 5.9.6 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.9.6-x86_64-Intel-R-_Core-TM-_i7-4810MQ_CPU_@_2.80GHz-with-gentoo-2.7
KiB Mem:    16292312 total,  13709720 free
KiB Swap:   20971516 total,  20971516 free
Timestamp of repository gentoo: Mon, 09 Nov 2020 10:00:01 +0000
Head commit of repository gentoo: d9268afce49d337307bb9cee35410bb44253a424
sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p1) 2.35.1
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r4::gentoo, 3.7.9::gentoo, 3.8.6::gentoo, 3.9.0::gentoo
dev-util/cmake:           3.18.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.35.1::gentoo
sys-devel/gcc:            10.2.0-r3::gentoo
sys-devel/gcc-config:     2.3.2::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: --new-compress
    sync-rsync-verify-max-age: 24

local
    location: /var/lib/portage-local/local
    masters: gentoo
    priority: 0

testing
    location: /var/lib/portage-local/testing
    masters: gentoo
    priority: 1

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS=""
MAKEOPTS="-j8"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--new-compress"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 acl acpi alsa amd64 avx bzip2 cairo caps cdda cddb cdparanoia crypt cups dbus dri dts dvd elogind fam ffmpeg fftw flac fontconfig gif gimp gmp gnutls gtk hardened iconv icu idn ipv6 jpeg lame lcms libglvnd libnotify libtirpc lzma mad matroska mmap mmx mmxext mp3 mpeg ncurses networkmanager nptl ogg opengl openmp pam pcre pie png policykit ppds readline sasl sdl seccomp split-usr sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg test theora threads tiff truetype udev udisks unicode upower vaapi vorbis wayland x264 xattr xcb xinerama xml xtpax xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25 ruby26" USERLAND="GNU" VIDEO_CARDS="i965 intel nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 2 tka 2020-11-09 10:32:52 UTC
Created attachment 670577 [details]
test-suite.log
Comment 3 kfm 2023-01-25 16:14:12 UTC
The test in question is not well-devised. It tries to match en_US.utf8 from `locale -a`, badly, then falls back to C.UTF-8, irrespective of whether it is available or not. At this point, the issue will be difficult to reproduce because C.UTF-8 is always incorporated into the glibc locale archive by Gentoo. Nevertheless, it remains a legitimate bug. I shall submit a patch soon.
Comment 4 kfm 2023-01-25 16:52:28 UTC
Created attachment 849191 [details, diff]
0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch

Tested by arranging for the system to offer neither a en.US.utf8 locale, nor a C.UTF-8 locale, and building with LANG=C. The test correctly selected the UTF-8 locale that I happen to have available and was able to pass the test. Further, and as noted by the commit message, the test will now be skipped in the event that no UTF-8 locale is available.
Comment 5 kfm 2023-01-25 16:59:13 UTC
Created attachment 849193 [details, diff]
0001-tests-Use-any-available-UTF-8-locale-in-t0251-skip-i.patch (r1)

Addresses a minor wording issue in the commit message. No other changes relative to the previously attached patch.
Comment 6 kfm 2023-01-29 00:54:32 UTC
Created attachment 849391 [details, diff]
0001-Use-any-available-UTF-8-locale-in-t0251-skip-if-none.patch

This is the patch that was submitted upstream.
Comment 7 Larry the Git Cow gentoo-dev 2023-06-16 03:05:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8489bdccc712eb390d43de5f3b0918bb839e8361

commit 8489bdccc712eb390d43de5f3b0918bb839e8361
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-06-16 02:56:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-06-16 02:56:01 +0000

    sys-block/parted: fix test portability issues
    
    Closes: https://bugs.gentoo.org/753677
    Closes: https://bugs.gentoo.org/890869
    Thanks-to: Kerin Millar <kfm@plushkava.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../parted/files/parted-3.6-tests-non-bash.patch   | 86 ++++++++++++++++++++++
 .../parted/files/parted-3.6-tests-unicode.patch    | 59 +++++++++++++++
 sys-block/parted/parted-3.6.ebuild                 |  6 +-
 3 files changed, 150 insertions(+), 1 deletion(-)