Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753617 - [Feature Request] sys-kernel/genkernel - plymouth support
Summary: [Feature Request] sys-kernel/genkernel - plymouth support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2020-11-08 22:07 UTC by FlyingWaffle
Modified: 2023-10-21 16:35 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
plymouth support patch (9999-plymouth-support.patch,15.89 KB, patch)
2021-03-19 19:47 UTC, FlyingWaffle
Details | Diff
plymouth support patch - old (genkernel-4.1.2-plymouth-support.patch,18.72 KB, patch)
2021-03-19 19:48 UTC, FlyingWaffle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description FlyingWaffle 2020-11-08 22:07:42 UTC
I would like to request the addition of Plymouth boot splash support in Genkernel.  With genkernel-next no longer supported or available on the repo a replacement would be nice.  This is also (as far as I can tell) the last major feature from gk-next that gk does not have.

I have coded and tested my own implementation of this and submitted a pull request on the genkernel GitHub page: https://github.com/gentoo/genkernel/pull/29

Please let me know if this is feasible, or if there are any changes I need to make.
Comment 2 FlyingWaffle 2021-03-19 19:47:51 UTC
Created attachment 692472 [details, diff]
plymouth support patch

Saw that my previous patch had merge conflicts, so I resolved those.  Patch for current 9999 ebuild in official repos attached.
Comment 3 FlyingWaffle 2021-03-19 19:48:36 UTC
Created attachment 692475 [details, diff]
plymouth support patch - old

Also uploading old patch for 4.1.2 ebuild.
Comment 4 Patrick Holthaus 2022-11-22 20:52:54 UTC
Thanks for the effort you put in here FlyingWaffle, that's much appreciated. I don't know what the exact status is of this patch, but I have generated one that works for genkernel-4.3.1 for those interested:

https://raw.githubusercontent.com/pholthaus/gentoo-patches/7bb77bd5579af5ba18f157c03a918915277efcb1/sys-kernel/genkernel-4.3.1/plymouth.patch
Comment 5 timkenhan 2023-08-21 03:53:19 UTC
(In reply to Patrick Holthaus from comment #4)

> https://raw.githubusercontent.com/pholthaus/gentoo-patches/
> 7bb77bd5579af5ba18f157c03a918915277efcb1/sys-kernel/genkernel-4.3.1/plymouth.
> patch

I've tested this patch to work. How can we move forward with this?
Comment 6 Larry the Git Cow gentoo-dev 2023-08-30 05:48:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=cbb69958759cef4d4df4b3e24b3348a9601deb3e

commit cbb69958759cef4d4df4b3e24b3348a9601deb3e
Author:     FlyingWaffle <flyingwaffle@pm.me>
AuthorDate: 2022-05-28 22:59:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-30 05:47:44 +0000

    Changed firmware and modules requirements to warnings.
    
    Depending on system configuration and hardware, added firmware and
    modules might not be required for Plymouth to function.
    
    Bug: https://bugs.gentoo.org/753617
    Signed-off-by: FlyingWaffle <flyingwaffle@pm.me>
    Closes: https://github.com/gentoo/genkernel/pull/29
    Signed-off-by: Sam James <sam@gentoo.org>

 gen_determineargs.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=732bd70737b784aa5e6b15430b7cf9f4e28948a1

commit 732bd70737b784aa5e6b15430b7cf9f4e28948a1
Author:     FlyingWaffle <flyingwaffle@pm.me>
AuthorDate: 2022-05-19 23:43:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-30 05:47:41 +0000

    Plymouth support for genkernel (squashed).
    
    Bug: https://bugs.gentoo.org/753617
    Signed-off-by: FlyingWaffle <flyingwaffle@pm.me>
    Signed-off-by: Sam James <sam@gentoo.org>

 defaults/initrd.scripts | 95 +++++++++++++++++++++++++++++++++++++++++++++++--
 defaults/linuxrc        | 19 ++++++++--
 doc/genkernel.8.txt     |  7 ++++
 gen_cmdline.sh          | 14 ++++++++
 gen_determineargs.sh    | 16 +++++++++
 gen_initramfs.sh        | 57 +++++++++++++++++++++++++++++
 genkernel.conf          |  7 ++++
 7 files changed, 210 insertions(+), 5 deletions(-)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-21 16:35:14 UTC
This is in 4.3.7.