Issue: sys-boot/lilo-24.2 does not respect CFLAGS.
Discovered on: amd64 (internal ref: ci)
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS. If this is not something about c/c++ context see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS.
Created attachment 670514 [details]
build log and emerge --info
I am not sure that we want arbitrary CFLAGS getting used with a bootloader. This is one of the few cases where you want to respect upstream's choices. There's no real performance benefit since bootloaders are only used during boot and you generally want them to work the first time around...
(In reply to Joshua Kinard from comment #2)
> I am not sure that we want arbitrary CFLAGS getting used with a bootloader.
> This is one of the few cases where you want to respect upstream's choices.
> There's no real performance benefit since bootloaders are only used during
> boot and you generally want them to work the first time around...
If there is no benefit, hide the qa notice is enough ;)
(In reply to Agostino Sarubbo from comment #3)
> If there is no benefit, hide the qa notice is enough ;)
Please change summary to "sys-boot/lilo-24.2 does not set QA_FLAGS_IGNORED" ?
The bug has been closed via the following commit(s):
Author: Joshua Kinard <firstname.lastname@example.org>
AuthorDate: 2021-06-06 20:01:25 +0000
Commit: Joshua Kinard <email@example.com>
CommitDate: 2021-06-06 20:01:45 +0000
sys-boot/lilo: Fix bugs #753608 and #715580
Add QA_FLAGS_IGNORED for '/sbin/lilo' to address Bug #753608 and
Add a small patch to check for '__GLIBC__' before a printf() call
that references it to avoid compilation errors on non-glibc systems
to fix Bug #715580. Also remove the unneeded 'eutils' inherit.
Signed-off-by: Joshua Kinard <firstname.lastname@example.org>
Package-Manager: Portage-3.0.19, Repoman-3.0.3
.../lilo/files/lilo-24.x-check-for-__GLIBC__.patch | 18 ++++++++++++++++++
sys-boot/lilo/lilo-24.2.ebuild | 7 ++++++-
2 files changed, 24 insertions(+), 1 deletion(-)